All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: openembeded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [PATCHv2][meta-browser 2/2] recipes: Replace "mv" with "cp -R --no-dereference --preserve=mode, links"
Date: Fri, 26 Feb 2016 11:20:04 -0800	[thread overview]
Message-ID: <2C567B48-8897-4E40-B513-FE5E009691F5@gmail.com> (raw)
In-Reply-To: <1456509790-23305-2-git-send-email-Martin.Jansa@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]


> On Feb 26, 2016, at 10:03 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> 
> * Using "cp -a" leaks UID of user running the builds, causing
>  many QA warnings.
> * See this thread for details:
>  http://lists.openembedded.org/pipermail/openembedded-core/2015-November/112904.html
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
> recipes-mozilla/firefox-addon/firefox-addon.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-mozilla/firefox-addon/firefox-addon.inc b/recipes-mozilla/firefox-addon/firefox-addon.inc
> index a886201..88dd5aa 100644
> --- a/recipes-mozilla/firefox-addon/firefox-addon.inc
> +++ b/recipes-mozilla/firefox-addon/firefox-addon.inc
> @@ -30,7 +30,7 @@ do_install() {
>         [ -z "$EXTENSION" ] && exit 1
> 
>         mkdir -p ${D}${libdir}/firefox/extensions/
> -        mv $e ${D}${libdir}/firefox/extensions/${EXTENSION}
> +        cp -R --no-dereference --preserve=mode,links -v $e ${D}${libdir}/firefox/extensions/${EXTENSION}

can we use install utility to have better control over perms

>     done
> }
> 
> --
> 2.7.1
> 
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

      reply	other threads:[~2016-02-26 19:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 18:03 [PATCHv2][meta-browser 1/2] chromium: fix build with newer gcc Martin Jansa
2016-02-26 18:03 ` [PATCHv2][meta-browser 2/2] recipes: Replace "mv" with "cp -R --no-dereference --preserve=mode, links" Martin Jansa
2016-02-26 19:20   ` Khem Raj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2C567B48-8897-4E40-B513-FE5E009691F5@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.