From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg
Date: Mon, 25 Jan 2010 17:58:26 +0100
Message-ID: <2CE27313-0F43-4A93-905F-3DF4815BC0B5@suse.de>
References: <4B5DCAF2.3010105@redhat.com> <4B5DCB93.7050007@redhat.com> <4B5DCC53.508@redhat.com>
Mime-Version: 1.0 (Apple Message framework v1077)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8BIT
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	KVM General <kvm@vger.kernel.org>,
	Kevin O'Connor <kevin@koconnor.net>,
	Avi Kivity <avi@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cantor2.suse.de ([195.135.220.15]:41216 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754213Ab0AYQ6b convert rfc822-to-8bit (ORCPT
	<rfc822;kvm@vger.kernel.org>); Mon, 25 Jan 2010 11:58:31 -0500
In-Reply-To: <4B5DCC53.508@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


On 25.01.2010, at 17:52, Jes Sorensen wrote:

> Hi,
> 
> This is the QEMU patch for providing the e820-reserve space through
> qemu-cfg.

Howdy. Congratulations to the new mail address - looks neat ;-).


Two comments:

1) I don't see how passing a single region is any help. I'd rather like to see a device tree like table structure
You'd get one variable for len of the table, one with the contents. So for a universal reserved region specifier you'd get:

<u64 base><u64 len>

Then have len=2 and put data in the table:

<u64 base1><u64 len1><u64 base2><u64 len2>

That way we'd get 2 entries and the chance to enhance them later on. In fact, it might even make sense to pass the whole table in such a form. That way qemu generates all of the e820 tables and we can declare whatever we want. Just add a type field in the table.

2) Please inline patches. They showed up as attachments here, making them really hard to comment on.


Alex
From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZSGp-0000es-Lp
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 11:58:35 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZSGl-0000bP-Qy
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 11:58:35 -0500
Received: from [199.232.76.173] (port=37263 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZSGl-0000b9-LM
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 11:58:31 -0500
Received: from cantor2.suse.de ([195.135.220.15]:41217 helo=mx2.suse.de)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <agraf@suse.de>) id 1NZSGl-0006qN-8L
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 11:58:31 -0500
Mime-Version: 1.0 (Apple Message framework v1077)
Content-Type: text/plain; charset=us-ascii
From: Alexander Graf <agraf@suse.de>
In-Reply-To: <4B5DCC53.508@redhat.com>
Date: Mon, 25 Jan 2010 17:58:26 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <2CE27313-0F43-4A93-905F-3DF4815BC0B5@suse.de>
References: <4B5DCAF2.3010105@redhat.com> <4B5DCB93.7050007@redhat.com>
	<4B5DCC53.508@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through
	qemu_cfg
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Kevin O'Connor <kevin@koconnor.net>, QEMU Developers <qemu-devel@nongnu.org>, KVM General <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>


On 25.01.2010, at 17:52, Jes Sorensen wrote:

> Hi,
>=20
> This is the QEMU patch for providing the e820-reserve space through
> qemu-cfg.

Howdy. Congratulations to the new mail address - looks neat ;-).


Two comments:

1) I don't see how passing a single region is any help. I'd rather like =
to see a device tree like table structure
You'd get one variable for len of the table, one with the contents. So =
for a universal reserved region specifier you'd get:

<u64 base><u64 len>

Then have len=3D2 and put data in the table:

<u64 base1><u64 len1><u64 base2><u64 len2>

That way we'd get 2 entries and the chance to enhance them later on. In =
fact, it might even make sense to pass the whole table in such a form. =
That way qemu generates all of the e820 tables and we can declare =
whatever we want. Just add a type field in the table.

2) Please inline patches. They showed up as attachments here, making =
them really hard to comment on.


Alex=