All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kai Heng Feng <kai.heng.feng@canonical.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
	Kernel development list <linux-kernel@vger.kernel.org>,
	Anthony Wong <anthony.wong@canonical.com>,
	Jason Yen <jason.yen@canonical.com>
Subject: SFP+ support for 8168fp/8117
Date: Thu, 2 Jan 2020 14:59:42 +0800	[thread overview]
Message-ID: <2D8F5FFE-3EC3-480B-9D15-23CACE5556DF@canonical.com> (raw)

Hi Heiner,

There's an 8168fp/8117 chip has SFP+ port instead of RJ45, the phy device ID matches "Generic FE-GE Realtek PHY" nevertheless.
The problems is that, since it uses SFP+, both BMCR and BMSR read are always zero, so Realtek phylib never knows if the link is up.

However, the old method to read through MMIO correctly shows the link is up:
static unsigned int rtl8169_xmii_link_ok(struct rtl8169_private *tp)
{
       return RTL_R8(tp, PHYstatus) & LinkStatus;
}

Few ideas here:
- Add a link state callback for phylib like phylink's phylink_fixed_state_cb(). However there's no guarantee that other parts of this chip works.
- Add SFP+ support for this chip. However the phy device matches to "Generic FE-GE Realtek PHY" which may complicate things.

Any advice will be welcome.

Kai-Heng

             reply	other threads:[~2020-01-02  6:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02  6:59 Kai Heng Feng [this message]
2020-01-02 15:21 ` SFP+ support for 8168fp/8117 Andrew Lunn
2020-01-02 16:46   ` Kai-Heng Feng
2020-01-02 21:24     ` Heiner Kallweit
2020-01-03  4:53       ` Kai-Heng Feng
2020-02-13  6:14         ` Kai-Heng Feng
2020-02-14  9:07           ` Hau
2020-02-17  6:37             ` Kai Heng Feng
2020-02-19 14:22               ` Hau
2020-02-19 14:48                 ` Kai-Heng Feng
2020-02-27  8:49                   ` Kai-Heng Feng
2020-03-04 15:24                     ` Hau
2020-03-04 15:28                       ` Andrew Lunn
2020-03-05 12:36                         ` Hau
2020-03-06 15:34                         ` Hau
2020-03-06 15:58                           ` Andrew Lunn
2020-03-06 16:33                             ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2D8F5FFE-3EC3-480B-9D15-23CACE5556DF@canonical.com \
    --to=kai.heng.feng@canonical.com \
    --cc=anthony.wong@canonical.com \
    --cc=hkallweit1@gmail.com \
    --cc=jason.yen@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.