From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755058Ab1H2VgS (ORCPT ); Mon, 29 Aug 2011 17:36:18 -0400 Received: from mx2.netapp.com ([216.240.18.37]:32295 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754738Ab1H2VgR convert rfc822-to-8bit (ORCPT ); Mon, 29 Aug 2011 17:36:17 -0400 X-IronPort-AV: E=Sophos;i="4.68,298,1312182000"; d="scan'208";a="576088402" X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Subject: RE: [PATCH 19/24] sunrpc: Remove unnecessary OOM logging messages Date: Mon, 29 Aug 2011 14:36:17 -0700 Message-ID: <2E1EB2CF9ED1CB4AA966F0EB76EAB4430AEB4EE9@SACMVEXC2-PRD.hq.netapp.com> In-Reply-To: <8a6378b3fef105983db001fb720c84b669491439.1314650069.git.joe@perches.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 19/24] sunrpc: Remove unnecessary OOM logging messages Thread-Index: AcxmkiUvy7D3U+PXQ9CHtVBvQnKRewAAQvqA References: <8a6378b3fef105983db001fb720c84b669491439.1314650069.git.joe@perches.com> From: "Myklebust, Trond" To: "Joe Perches" , "J. Bruce Fields" , "Neil Brown" Cc: "David S. Miller" , , , X-OriginalArrivalTime: 29 Aug 2011 21:36:15.0660 (UTC) FILETIME=[AE40A6C0:01CC6693] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Joe Perches [mailto:joe@perches.com] > Sent: Monday, August 29, 2011 5:18 PM > To: Myklebust, Trond; J. Bruce Fields; Neil Brown > Cc: David S. Miller; linux-nfs@vger.kernel.org; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: [PATCH 19/24] sunrpc: Remove unnecessary OOM logging messages > > Removing unnecessary messages saves code and text. > > Site specific OOM messages are duplications of a generic MM > out of memory message and aren't really useful, so just > delete them. > > Signed-off-by: Joe Perches > --- > net/sunrpc/auth_gss/gss_krb5_crypto.c | 10 ++-------- > net/sunrpc/auth_gss/gss_krb5_mech.c | 2 -- > net/sunrpc/backchannel_rqst.c | 9 +++------ > net/sunrpc/clnt.c | 3 --- > net/sunrpc/rpc_pipe.c | 3 +-- > net/sunrpc/rpcb_clnt.c | 2 -- > net/sunrpc/xprtrdma/svc_rdma.c | 8 ++------ > net/sunrpc/xprtrdma/transport.c | 5 +---- > net/sunrpc/xprtrdma/verbs.c | 14 -------------- > net/sunrpc/xprtsock.c | 5 +---- > 10 files changed, 10 insertions(+), 51 deletions(-) > Big NACK... By whose standard are those "not useful"? Trond