From: "Patel, Vedang" <vedang.patel@intel.com>
To: "Dorileo, Leandro" <leandro.maciel.dorileo@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S . Miller" <davem@davemloft.net>,
"Gomes, Vinicius" <vinicius.gomes@intel.com>
Subject: Re: [PATCH net V3 0/2] net/sched: taprio: cbs: Fix using invalid link speed
Date: Tue, 19 Mar 2019 00:07:15 +0000 [thread overview]
Message-ID: <2E21E7FA-35CF-4363-91A6-4C4EE5B6ED93@intel.com> (raw)
In-Reply-To: <20190315211626.300-1-leandro.maciel.dorileo@intel.com>
I agree with Florian's minor comment regarding pr_info->netdev_dgb change.
But, apart from that, I reviewed both the patches look good to me:
Reviewed-By: Vedang Patel <vedang.patel@intel.com>
On 3/15/19, 2:17 PM, "netdev-owner@vger.kernel.org on behalf of Leandro Dorileo" <netdev-owner@vger.kernel.org on behalf of leandro.maciel.dorileo@intel.com> wrote:
This set fixes miscalculations based on invalid link speed values.
Changes in v3:
+ yep pr_info() format warnings;
Changes in v2:
+ fixed pr_info() format both on cbs and taprio patches;
Leandro Dorileo (2):
net/sched: taprio: fix picos_per_byte miscalculation
net/sched: cbs: fix port_rate miscalculation
net/sched/sch_cbs.c | 91 +++++++++++++++++++++++++++++++++++-------
net/sched/sch_taprio.c | 90 +++++++++++++++++++++++++++++++++--------
2 files changed, 151 insertions(+), 30 deletions(-)
--
2.21.0
prev parent reply other threads:[~2019-03-19 0:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 21:16 [PATCH net V3 0/2] net/sched: taprio: cbs: Fix using invalid link speed Leandro Dorileo
2019-03-15 21:16 ` [PATCH net V3 1/2] net/sched: taprio: fix picos_per_byte miscalculation Leandro Dorileo
2019-03-15 21:36 ` Florian Fainelli
2019-03-18 21:13 ` Leandro Dorileo
2019-03-16 9:00 ` kbuild test robot
2019-03-15 21:16 ` [PATCH net V3 2/2] net/sched: cbs: fix port_rate miscalculation Leandro Dorileo
2019-03-19 0:07 ` Patel, Vedang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2E21E7FA-35CF-4363-91A6-4C4EE5B6ED93@intel.com \
--to=vedang.patel@intel.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=leandro.maciel.dorileo@intel.com \
--cc=netdev@vger.kernel.org \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.