From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759196AbdACNxh convert rfc822-to-8bit (ORCPT ); Tue, 3 Jan 2017 08:53:37 -0500 Received: from mail1.bemta3.messagelabs.com ([195.245.230.161]:40468 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759143AbdACNwG (ORCPT ); Tue, 3 Jan 2017 08:52:06 -0500 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCKsWRWlGSWpSXmKPExsUSt3OpsW7Nmuw Ig6XH5CxWXHvDYrG29yiLxad7/WwWv94dYbdY9uA0o8Wmx9dYLS7vmsNmcWPdPnaLJwvPMFns vn6O0eLpzM1sFu9WP2G0uDXjBasDr8es+2fZPHbOusvucW2zmMfeLVkem5fUe+z83sDuMbfhF pPH501yARxRrJl5SfkVCawZ0w/8ZSuYw10x59xv5gbGK5xdjJwcQgJLGCW+zREEsdkELCQmn3 jA1sXIxSEicJ9V4srfbjaQhLCAs8TjOZOYQWwRAReJD+0P2CFsI4nZG7aC1bAIqEg8f3qdFcT mFQiQuPX9MCvEAieJn/v3sIDYnEBzTrVdYAKxGQVkJb40rgabySwgLnHryXywuISAgMSSPeeZ IWxRiZeP/7FC2PIS27/9Zoew7SVe33sHNJMDyNaX6GsshggbSqyadoAFwjaXePO9G2q8jsSC3 Z/YIGxtiWULXzNDnCkocXLmE5YJjGKzkFwxC0nLLCQts5C0LGBkWcWoUZxaVJZapGtoqpdUlJ meUZKbmJmja2hgrJebWlycmJ6ak5hUrJecn7uJERj7DECwg3HNds9DjJIcTEqivNEM2RFCfEn 5KZUZicUZ8UWlOanFhxhlODiUJHhLVgPlBItS01Mr0jJzgEkIJi3BwaMkwvt5FVCat7ggMbc4 Mx0idYpRUUqc1xKkTwAkkVGaB9cGS3yXGGWlhHkZgQ4R4ilILcrNLEGVf8UozsGoJMzbDDKFJ zOvBG76K6DFTECLtweALS5JREhJNTCqOMzR/rMyvue8Favq65suR6ZtnN3h8U9WeNP/+0uc// +15+01zE/oVvOYLc/GtNp3mtBmtcAT++7Mnmo4IUty+/uVuiJfrd9uXrK8zism9sTy8roCt5c 7mE78u3hcZOr/+0v74tQ2T5WrdXkyx6VEjmP2pbdTHwpzGbDU6Hy6UsKUlJr60t5RiaU4I9FQ i7moOBEAiU7tEXcDAAA= X-Env-Sender: Adam.Thomson.Opensource@diasemi.com X-Msg-Ref: server-8.tower-217.messagelabs.com!1483451516!73186556!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked From: Adam Thomson To: Bhumika Goyal , "julia.lawall@lip6.fr" , "wim@iguana.be" , "linux@roeck-us.net" , "f.fainelli@gmail.com" , "rjui@broadcom.com" , "sbranden@broadcom.com" , "bcm-kernel-feedback-list@broadcom.com" , Support Opensource , "baruch@tkos.co.il" , "manabian@gmail.com" , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v2] watchdog: constify watchdog_info structures Thread-Topic: [PATCH v2] watchdog: constify watchdog_info structures Thread-Index: AQHSX5pKn95XJ00Q7Um50Znwf/cih6Em0J2w Date: Tue, 3 Jan 2017 13:51:54 +0000 Message-ID: <2E89032DDAA8B9408CB92943514A03370142A7539F@SW-EX-MBX01.diasemi.com> References: <1482771911-13548-1-git-send-email-bhumirks@gmail.com> In-Reply-To: <1482771911-13548-1-git-send-email-bhumirks@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.24.43] x-kse-attachmentfiltering-interceptor-info: protection disabled x-kse-serverinfo: sw-ex-cashub01.diasemi.com, 9 x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: Clean, bases: 03/01/2017 07:06:00 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26 December 2016 17:05, Bhumika Goyal wrote: > Declare watchdog_info structures as const as they are only stored in the > info field of watchdog_device structures. This field is of type const > struct watchdog_info *, so watchdog_info structures having this property > can be declared const too. > diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c > index 2fc19a3..d86a57e 100644 > --- a/drivers/watchdog/da9052_wdt.c > +++ b/drivers/watchdog/da9052_wdt.c > @@ -140,7 +140,7 @@ static int da9052_wdt_ping(struct watchdog_device > *wdt_dev) > return ret; > } > > -static struct watchdog_info da9052_wdt_info = { > +static const struct watchdog_info da9052_wdt_info = { > .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > .identity = "DA9052 Watchdog", > }; > diff --git a/drivers/watchdog/da9055_wdt.c b/drivers/watchdog/da9055_wdt.c > index 8377c43..4f30818 100644 > --- a/drivers/watchdog/da9055_wdt.c > +++ b/drivers/watchdog/da9055_wdt.c > @@ -108,7 +108,7 @@ static int da9055_wdt_stop(struct watchdog_device > *wdt_dev) > return da9055_wdt_set_timeout(wdt_dev, 0); > } > > -static struct watchdog_info da9055_wdt_info = { > +static const struct watchdog_info da9055_wdt_info = { > .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > .identity = "DA9055 Watchdog", > }; For DA9052 and DA9055: Acked-by: Adam Thomson From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: From: Adam Thomson To: Bhumika Goyal , "julia.lawall@lip6.fr" , "wim@iguana.be" , "linux@roeck-us.net" , "f.fainelli@gmail.com" , "rjui@broadcom.com" , "sbranden@broadcom.com" , "bcm-kernel-feedback-list@broadcom.com" , Support Opensource , "baruch@tkos.co.il" , "manabian@gmail.com" , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v2] watchdog: constify watchdog_info structures Date: Tue, 3 Jan 2017 13:51:54 +0000 Message-ID: <2E89032DDAA8B9408CB92943514A03370142A7539F@SW-EX-MBX01.diasemi.com> References: <1482771911-13548-1-git-send-email-bhumirks@gmail.com> In-Reply-To: <1482771911-13548-1-git-send-email-bhumirks@gmail.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 List-ID: On 26 December 2016 17:05, Bhumika Goyal wrote: > Declare watchdog_info structures as const as they are only stored in the > info field of watchdog_device structures. This field is of type const > struct watchdog_info *, so watchdog_info structures having this property > can be declared const too. > diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.= c > index 2fc19a3..d86a57e 100644 > --- a/drivers/watchdog/da9052_wdt.c > +++ b/drivers/watchdog/da9052_wdt.c > @@ -140,7 +140,7 @@ static int da9052_wdt_ping(struct watchdog_device > *wdt_dev) > return ret; > } >=20 > -static struct watchdog_info da9052_wdt_info =3D { > +static const struct watchdog_info da9052_wdt_info =3D { > .options =3D WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > .identity =3D "DA9052 Watchdog", > }; > diff --git a/drivers/watchdog/da9055_wdt.c b/drivers/watchdog/da9055_wdt.= c > index 8377c43..4f30818 100644 > --- a/drivers/watchdog/da9055_wdt.c > +++ b/drivers/watchdog/da9055_wdt.c > @@ -108,7 +108,7 @@ static int da9055_wdt_stop(struct watchdog_device > *wdt_dev) > return da9055_wdt_set_timeout(wdt_dev, 0); > } >=20 > -static struct watchdog_info da9055_wdt_info =3D { > +static const struct watchdog_info da9055_wdt_info =3D { > .options =3D WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > .identity =3D "DA9055 Watchdog", > }; For DA9052 and DA9055: Acked-by: Adam Thomson From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam.Thomson.Opensource@diasemi.com (Adam Thomson) Date: Tue, 3 Jan 2017 13:51:54 +0000 Subject: [PATCH v2] watchdog: constify watchdog_info structures In-Reply-To: <1482771911-13548-1-git-send-email-bhumirks@gmail.com> References: <1482771911-13548-1-git-send-email-bhumirks@gmail.com> Message-ID: <2E89032DDAA8B9408CB92943514A03370142A7539F@SW-EX-MBX01.diasemi.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 26 December 2016 17:05, Bhumika Goyal wrote: > Declare watchdog_info structures as const as they are only stored in the > info field of watchdog_device structures. This field is of type const > struct watchdog_info *, so watchdog_info structures having this property > can be declared const too. > diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c > index 2fc19a3..d86a57e 100644 > --- a/drivers/watchdog/da9052_wdt.c > +++ b/drivers/watchdog/da9052_wdt.c > @@ -140,7 +140,7 @@ static int da9052_wdt_ping(struct watchdog_device > *wdt_dev) > return ret; > } > > -static struct watchdog_info da9052_wdt_info = { > +static const struct watchdog_info da9052_wdt_info = { > .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > .identity = "DA9052 Watchdog", > }; > diff --git a/drivers/watchdog/da9055_wdt.c b/drivers/watchdog/da9055_wdt.c > index 8377c43..4f30818 100644 > --- a/drivers/watchdog/da9055_wdt.c > +++ b/drivers/watchdog/da9055_wdt.c > @@ -108,7 +108,7 @@ static int da9055_wdt_stop(struct watchdog_device > *wdt_dev) > return da9055_wdt_set_timeout(wdt_dev, 0); > } > > -static struct watchdog_info da9055_wdt_info = { > +static const struct watchdog_info da9055_wdt_info = { > .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > .identity = "DA9055 Watchdog", > }; For DA9052 and DA9055: Acked-by: Adam Thomson