From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751108AbdAQOTi convert rfc822-to-8bit (ORCPT ); Tue, 17 Jan 2017 09:19:38 -0500 Received: from mail1.bemta5.messagelabs.com ([195.245.231.153]:35059 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750965AbdAQOTh (ORCPT ); Tue, 17 Jan 2017 09:19:37 -0500 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBKsWRWlGSWpSXmKPExsUSt3Opse4X9bo Ig097tCwu75rDZnFj3T52iycLzzBZ3JrxgtWBxePaZjGPnd8b2D0+b5ILYI5izcxLyq9IYM3o +D6brWAOe8WW7d1sDYxT2LoYuTiEBJYySjRsPcvYxcjJwSZgITH5xAM2EFtEwENi++ulLCBFz AJ7GSV+TrsAViQsECnxfMUqdoiiKIkLd15B2UYSK97sZgKxWQRUJVY8mA9m8woESHx6PJcZxB YSqJTYfvYiWJxTwFni8L7jYDMZBWQlvjSuBqthFhCXuPUEoldCQEBiyZ7zzBC2qMTLx/9YIWx 5ie3ffrND2PYSr++9AzqUA8jWl+hrLIYIG0qsmnYAKmwuse4nN8R0HYkFuz+xQdjaEssWvmaG uFJQ4uTMJywTGMVnITliFpKWWUhaZiFpWcDIsopRozi1qCy1SNfIUC+pKDM9oyQ3MTNH19DAV C83tbg4MT01JzGpWC85P3cTIzAW6xkYGHcw3p3sd4hRkoNJSZS343FthBBfUn5KZUZicUZ8UW lOavEhRhkODiUJ3vtqdRFCgkWp6akVaZk5wKQAk5bg4FES4Z0OkuYtLkjMLc5Mh0idYtTlOPX pwksmIZa8/LxUKXHeDSBFAiBFGaV5cCNgCeoSo6yUMC8jAwODEE9BalFuZgmq/CtGcQ5GJWFe X2C6E+LJzCuB2/QK6AgmoCOu61SDHFGSiJCSamAs5F/2tKn340uumDVV+qvcJmnFPM+b9crm5 ZMVgsG1Ks9n1DBpc9iHhDCqS8+UmLb7gLzZkq/bND8s/X5GxLjyXMaMv9MF3bmmB5yI+OklN9 8w+Q/D6YNGF9//v3FputEmRWcT61yFLTfPa7/xOKkYERnJl3nH+njHmuzPZbc/xSQ3GgZ7/1N VYinOSDTUYi4qTgQAf85hOUsDAAA= X-Env-Sender: Adam.Thomson.Opensource@diasemi.com X-Msg-Ref: server-12.tower-179.messagelabs.com!1484662772!76604533!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked From: Adam Thomson To: Guenter Roeck , Wim Van Sebroeck CC: "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Support Opensource" Subject: RE: [PATCH 14/62] watchdog: da9063_wdt: Convert to use device managed functions Thread-Topic: [PATCH 14/62] watchdog: da9063_wdt: Convert to use device managed functions Thread-Index: AQHSa5p2+WRbqmCoUU2FxQVTr5rWG6E8waEQ Date: Tue, 17 Jan 2017 14:19:31 +0000 Message-ID: <2E89032DDAA8B9408CB92943514A03370142A77D5D@SW-EX-MBX01.diasemi.com> References: <1484091325-9199-1-git-send-email-linux@roeck-us.net> <1484091325-9199-15-git-send-email-linux@roeck-us.net> In-Reply-To: <1484091325-9199-15-git-send-email-linux@roeck-us.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.24.43] x-kse-attachmentfiltering-interceptor-info: protection disabled x-kse-serverinfo: sw-ex-cashub01.diasemi.com, 9 x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: Clean, bases: 17/01/2017 11:36:00 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10 January 2017 23:35, Guenter Roeck wrote: > Use device managed functions to simplify error handling, reduce > source code size, improve readability, and reduce the likelyhood of bugs. > > The conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts used > to generate this commit log are available at > https://github.com/groeck/coccinelle-patches > > - Replace 'val = e; return val;' with 'return e;' > - Replace 'if (e) return e; return 0;' with 'return e;' > - Drop assignments to otherwise unused variables > - Drop unused variables > - Drop remove function > - Drop dev_set_drvdata() > - Use devm_watchdog_register_driver() to register watchdog device > > Cc: Support Opensource > Signed-off-by: Guenter Roeck > --- Acked-by: Adam Thomson