From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753597AbbHCPXi (ORCPT ); Mon, 3 Aug 2015 11:23:38 -0400 Received: from mail1.bemta14.messagelabs.com ([193.109.254.110]:24639 "EHLO mail1.bemta14.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751756AbbHCPXf (ORCPT ); Mon, 3 Aug 2015 11:23:35 -0400 X-Env-Sender: Adam.Thomson.Opensource@diasemi.com X-Msg-Ref: server-6.tower-194.messagelabs.com!1438615391!33266517!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 6.13.17; banners=-,-,- X-VirusChecked: Checked From: "Opensource [Adam Thomson]" To: Sebastian Reichel , "Opensource [Adam Thomson]" CC: Lee Jones , Samuel Ortiz , Dmitry Eremin-Solenikov , David Woodhouse , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Support Opensource" Subject: RE: [PATCH v3 3/6] power: Add support for DA9150 Fuel-Gauge Thread-Topic: [PATCH v3 3/6] power: Add support for DA9150 Fuel-Gauge Thread-Index: AQHQuNLH/LBHj9ABn0+op+/AwlpyXJ3se+KAgA4JQHA= Date: Mon, 3 Aug 2015 15:23:11 +0000 Message-ID: <2E89032DDAA8B9408CB92943514A0337AB5690C3@SW-EX-MBX01.diasemi.com> References: <20150725172715.GA1697@earth> In-Reply-To: <20150725172715.GA1697@earth> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.15] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t73FNixU026490 On July 25, 2015 18:27, Sebastian Reichel wrote: > Hi Adam, > > The driver looks mostly fine. I have a few comments, though: > > On Tue, Jul 07, 2015 at 05:34:19PM +0100, Adam Thomson wrote: > > Signed-off-by: Adam Thomson > > Please add a short description to the commit message. > Ok, I can add something. Didn't feel like it needed to be too descriptive, but can make it a little more verbose. > > [...] > > > > +config FG_DA9150 > > Please name the config entry BATTERY_DA9150 to be consistent with > the other fuel gauges. > Ok no problem. > > [...] > > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > I wonder if the "depends CHARGER_DA9150" in Kconfig should be > "depends MFD_DA9150" instead. > I did think about this, but it felt like it was a bit pointless having the fuel-gauge driver without the charger driver, as they're intrinsically tied in HW. I guess if you don't want the charging reporting but still wanted fuel-gauge information then maybe. I don't mind making the change you mention as there should be no functional impact. > > [...] > > + > > +/* Power Supply attributes */ > > +static int da9150_fg_capacity(struct da9150_fg *fg, > > + union power_supply_propval *val) > > +{ > > + da9150_fg_read_sync_start(fg); > > + val->intval = da9150_fg_read_attr(fg, DA9150_QIF_SOC_PCT, > > + DA9150_QIF_SOC_PCT_SIZE); > > + da9150_fg_read_sync_end(fg); > > Create a wrapper function for this. Reading a single value > with sync guards is done multiple times. > > da9150_fg_read_attr_sync(fg, ...) { > da9150_fg_read_sync_start(fg); > da9150_fg_read_attr(fg, ...); > da9150_fg_read_sync_end(fg); > } > Yep, fair point. Can add something for the single attribute accesses. > > + if (val->intval > 100) > > + val->intval = 100; > > + > > + return 0; > > +} > > + > > > > [...] > > + DA9150_QIF_E_FG_STATUS_SIZE); > > + > > + /* Handle warning/critical threhold events */ > > + if ((DA9150_FG_IRQ_LOW_SOC_MASK | DA9150_FG_IRQ_HIGH_SOC_MASK) > & > > + e_fg_status) > > Please make this (e_fg_status & CONSTANT_MASK). > Fine, not a problem. > > + da9150_fg_soc_event_config(fg); > > + > > + /* Clear any FG IRQs */ > > + da9150_fg_write_attr(fg, DA9150_QIF_E_FG_STATUS, > > + DA9150_QIF_E_FG_STATUS_SIZE, e_fg_status); > > + > > + return IRQ_HANDLED; > > +} > > + > > > > [...] > > > > +static int da9150_fg_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct da9150 *da9150 = dev_get_drvdata(dev->parent); > > + struct da9150_fg_pdata *fg_pdata = dev_get_platdata(dev); > > + struct da9150_fg *fg; > > + int ver, irq, ret; > > + > > + fg = devm_kzalloc(dev, sizeof(*fg), GFP_KERNEL); > > + if (fg == NULL) > > + return -ENOMEM; > > + > > + platform_set_drvdata(pdev, fg); > > + fg->da9150 = da9150; > > + fg->dev = dev; > > + > > + mutex_init(&fg->io_lock); > > + > > + /* Enable QIF */ > > + da9150_set_bits(da9150, DA9150_CORE2WIRE_CTRL_A, > DA9150_FG_QIF_EN_MASK, > > + DA9150_FG_QIF_EN_MASK); > > + > > + fg->battery = power_supply_register(dev, &fg_desc, NULL); > > + if (IS_ERR(fg->battery)) { > > + ret = PTR_ERR(fg->battery); > > + return ret; > > + } > > Please use devm_power_supply_register(...) to simplify the driver. > > > + ver = da9150_fg_read_attr(fg, DA9150_QIF_FW_MAIN_VER, > > + DA9150_QIF_FW_MAIN_VER_SIZE); > > + dev_info(dev, "Version: 0x%x\n", ver); > > + > > + /* Handle DT data if provided */ > > + if (dev->of_node) { > > + fg_pdata = da9150_fg_dt_pdata(dev); > > + dev->platform_data = fg_pdata; > > + } > > + > > + /* Handle any pdata provided */ > > + if (fg_pdata) { > > + fg->interval = fg_pdata->update_interval; > > + > > + if (fg_pdata->warn_soc_lvl > 100) > > + dev_warn(dev, "Invalid SOC warning level provided, > Ignoring"); > > + else > > + fg->warn_soc = fg_pdata->warn_soc_lvl; > > + > > + if ((fg_pdata->crit_soc_lvl > 100) || > > + (fg_pdata->crit_soc_lvl >= fg_pdata->warn_soc_lvl)) > > + dev_warn(dev, "Invalid SOC critical level provided, > Ignoring"); > > + else > > + fg->crit_soc = fg_pdata->crit_soc_lvl; > > + > > + > > + } > > + > > + /* Configure initial SOC level events */ > > + da9150_fg_soc_event_config(fg); > > + > > + /* > > + * If an interval period has been provided then setup repeating > > + * work for reporting data updates. > > + */ > > + if (fg->interval) { > > + INIT_DELAYED_WORK(&fg->work, da9150_fg_work); > > + schedule_delayed_work(&fg->work, > > + msecs_to_jiffies(fg->interval)); > > + } > > + > > + /* Register IRQ */ > > + irq = platform_get_irq_byname(pdev, "FG"); > > + ret = request_threaded_irq(irq, NULL, da9150_fg_irq, IRQF_ONESHOT, "FG", > > + fg); > > + if (ret) > > + goto irq_fail; > > + > > + return ret; > > + > > +irq_fail: > > + cancel_delayed_work(&fg->work); > > + power_supply_unregister(fg->battery); > > + > > + return ret; > > +} > > + > > +static int da9150_fg_remove(struct platform_device *pdev) > > +{ > > + struct da9150_fg *fg = platform_get_drvdata(pdev); > > + int irq; > > + > > + irq = platform_get_irq_byname(pdev, "FG"); > > + free_irq(irq, fg); > > + > > + if (fg->interval) > > + cancel_delayed_work(&fg->work); > > It looks like the order of irq freeing and canceling of the > delayed work is not important. In that case I suggest switching > to devm_request_threaded_irq(...). > Yes, you're right. There's no ordering dependency. Will use devm. > > + power_supply_unregister(fg->battery); > > + > > + return 0; > > +} > > > > [...] > > > > + > > +MODULE_DESCRIPTION("Fuel-Gauge Driver for DA9150"); > > +MODULE_AUTHOR("Adam Thomson > "); > > +MODULE_LICENSE("GPL"); > > MODULE_LICENSE("GPL v2"); If I do this then I need to update the file license disclaimer at the top, as right now they match and are correct as far as I can tell. Is this change needed and if so is this the intention for other drivers as well, just so I'm clear? {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Opensource [Adam Thomson]" Subject: RE: [PATCH v3 3/6] power: Add support for DA9150 Fuel-Gauge Date: Mon, 3 Aug 2015 15:23:11 +0000 Message-ID: <2E89032DDAA8B9408CB92943514A0337AB5690C3@SW-EX-MBX01.diasemi.com> References: <20150725172715.GA1697@earth> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150725172715.GA1697@earth> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Sebastian Reichel , "Opensource [Adam Thomson]" Cc: Lee Jones , Samuel Ortiz , Dmitry Eremin-Solenikov , David Woodhouse , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Support Opensource List-Id: devicetree@vger.kernel.org T24gSnVseSAyNSwgMjAxNSAxODoyNywgU2ViYXN0aWFuIFJlaWNoZWwgd3JvdGU6DQoNCj4gSGkg QWRhbSwNCj4gDQo+IFRoZSBkcml2ZXIgbG9va3MgbW9zdGx5IGZpbmUuIEkgaGF2ZSBhIGZldyBj b21tZW50cywgdGhvdWdoOg0KPiANCj4gT24gVHVlLCBKdWwgMDcsIDIwMTUgYXQgMDU6MzQ6MTlQ TSArMDEwMCwgQWRhbSBUaG9tc29uIHdyb3RlOg0KPiA+IFNpZ25lZC1vZmYtYnk6IEFkYW0gVGhv bXNvbiA8QWRhbS5UaG9tc29uLk9wZW5zb3VyY2VAZGlhc2VtaS5jb20+DQo+IA0KPiBQbGVhc2Ug YWRkIGEgc2hvcnQgZGVzY3JpcHRpb24gdG8gdGhlIGNvbW1pdCBtZXNzYWdlLg0KPiANCg0KT2ss IEkgY2FuIGFkZCBzb21ldGhpbmcuIERpZG4ndCBmZWVsIGxpa2UgaXQgbmVlZGVkIHRvIGJlIHRv byBkZXNjcmlwdGl2ZSwgYnV0DQpjYW4gbWFrZSBpdCBhIGxpdHRsZSBtb3JlIHZlcmJvc2UuDQoN Cj4gPiBbLi4uXQ0KPiA+DQo+ID4gK2NvbmZpZyBGR19EQTkxNTANCj4gDQo+IFBsZWFzZSBuYW1l IHRoZSBjb25maWcgZW50cnkgQkFUVEVSWV9EQTkxNTAgdG8gYmUgY29uc2lzdGVudCB3aXRoDQo+ IHRoZSBvdGhlciBmdWVsIGdhdWdlcy4NCj4NCg0KT2sgbm8gcHJvYmxlbS4NCg0KPiA+IFsuLi5d DQo+ID4NCj4gPiArI2luY2x1ZGUgPGxpbnV4L2tlcm5lbC5oPg0KPiA+ICsjaW5jbHVkZSA8bGlu dXgvbW9kdWxlLmg+DQo+ID4gKyNpbmNsdWRlIDxsaW51eC9wbGF0Zm9ybV9kZXZpY2UuaD4NCj4g PiArI2luY2x1ZGUgPGxpbnV4L29mLmg+DQo+ID4gKyNpbmNsdWRlIDxsaW51eC9vZl9wbGF0Zm9y bS5oPg0KPiA+ICsjaW5jbHVkZSA8bGludXgvc2xhYi5oPg0KPiA+ICsjaW5jbHVkZSA8bGludXgv aW50ZXJydXB0Lmg+DQo+ID4gKyNpbmNsdWRlIDxsaW51eC9kZWxheS5oPg0KPiA+ICsjaW5jbHVk ZSA8bGludXgvcG93ZXJfc3VwcGx5Lmg+DQo+ID4gKyNpbmNsdWRlIDxsaW51eC9saXN0Lmg+DQo+ ID4gKyNpbmNsdWRlIDxhc20vZGl2NjQuaD4NCj4gPiArI2luY2x1ZGUgPGxpbnV4L21mZC9kYTkx NTAvY29yZS5oPg0KPiA+ICsjaW5jbHVkZSA8bGludXgvbWZkL2RhOTE1MC9yZWdpc3RlcnMuaD4N Cj4gDQo+IEkgd29uZGVyIGlmIHRoZSAiZGVwZW5kcyBDSEFSR0VSX0RBOTE1MCIgaW4gS2NvbmZp ZyBzaG91bGQgYmUNCj4gImRlcGVuZHMgTUZEX0RBOTE1MCIgaW5zdGVhZC4NCj4gDQoNCkkgZGlk IHRoaW5rIGFib3V0IHRoaXMsIGJ1dCBpdCBmZWx0IGxpa2UgaXQgd2FzIGEgYml0IHBvaW50bGVz cyBoYXZpbmcgdGhlDQpmdWVsLWdhdWdlIGRyaXZlciB3aXRob3V0IHRoZSBjaGFyZ2VyIGRyaXZl ciwgYXMgdGhleSdyZSBpbnRyaW5zaWNhbGx5IHRpZWQgaW4NCkhXLiBJIGd1ZXNzIGlmIHlvdSBk b24ndCB3YW50IHRoZSBjaGFyZ2luZyByZXBvcnRpbmcgYnV0IHN0aWxsIHdhbnRlZCBmdWVsLWdh dWdlDQppbmZvcm1hdGlvbiB0aGVuIG1heWJlLiBJIGRvbid0IG1pbmQgbWFraW5nIHRoZSBjaGFu Z2UgeW91IG1lbnRpb24gYXMgdGhlcmUNCnNob3VsZCBiZSBubyBmdW5jdGlvbmFsIGltcGFjdC4N Cg0KPiA+IFsuLi5dDQo+ID4gKw0KPiA+ICsvKiBQb3dlciBTdXBwbHkgYXR0cmlidXRlcyAqLw0K PiA+ICtzdGF0aWMgaW50IGRhOTE1MF9mZ19jYXBhY2l0eShzdHJ1Y3QgZGE5MTUwX2ZnICpmZywN Cj4gPiArCQkJICAgICAgdW5pb24gcG93ZXJfc3VwcGx5X3Byb3B2YWwgKnZhbCkNCj4gPiArew0K PiA+ICsJZGE5MTUwX2ZnX3JlYWRfc3luY19zdGFydChmZyk7DQo+ID4gKwl2YWwtPmludHZhbCA9 IGRhOTE1MF9mZ19yZWFkX2F0dHIoZmcsIERBOTE1MF9RSUZfU09DX1BDVCwNCj4gPiArCQkJCQkg IERBOTE1MF9RSUZfU09DX1BDVF9TSVpFKTsNCj4gPiArCWRhOTE1MF9mZ19yZWFkX3N5bmNfZW5k KGZnKTsNCj4gDQo+IENyZWF0ZSBhIHdyYXBwZXIgZnVuY3Rpb24gZm9yIHRoaXMuIFJlYWRpbmcg YSBzaW5nbGUgdmFsdWUNCj4gd2l0aCBzeW5jIGd1YXJkcyBpcyBkb25lIG11bHRpcGxlIHRpbWVz Lg0KPiANCj4gZGE5MTUwX2ZnX3JlYWRfYXR0cl9zeW5jKGZnLCAuLi4pIHsNCj4gICAgIGRhOTE1 MF9mZ19yZWFkX3N5bmNfc3RhcnQoZmcpOw0KPiAgICAgZGE5MTUwX2ZnX3JlYWRfYXR0cihmZywg Li4uKTsNCj4gICAgIGRhOTE1MF9mZ19yZWFkX3N5bmNfZW5kKGZnKTsNCj4gfQ0KPiANCg0KWWVw LCBmYWlyIHBvaW50LiBDYW4gYWRkIHNvbWV0aGluZyBmb3IgdGhlIHNpbmdsZSBhdHRyaWJ1dGUg YWNjZXNzZXMuIA0KDQo+ID4gKwlpZiAodmFsLT5pbnR2YWwgPiAxMDApDQo+ID4gKwkJdmFsLT5p bnR2YWwgPSAxMDA7DQo+ID4gKw0KPiA+ICsJcmV0dXJuIDA7DQo+ID4gK30NCj4gPiArDQo+ID4N Cj4gPiBbLi4uXQ0KPiA+ICsJCQkJCSAgREE5MTUwX1FJRl9FX0ZHX1NUQVRVU19TSVpFKTsNCj4g PiArDQo+ID4gKwkvKiBIYW5kbGUgd2FybmluZy9jcml0aWNhbCB0aHJlaG9sZCBldmVudHMgKi8N Cj4gPiArCWlmICgoREE5MTUwX0ZHX0lSUV9MT1dfU09DX01BU0sgfCBEQTkxNTBfRkdfSVJRX0hJ R0hfU09DX01BU0spDQo+ICYNCj4gPiArCSAgICBlX2ZnX3N0YXR1cykNCj4gDQo+IFBsZWFzZSBt YWtlIHRoaXMgKGVfZmdfc3RhdHVzICYgQ09OU1RBTlRfTUFTSykuDQo+DQoNCkZpbmUsIG5vdCBh IHByb2JsZW0uDQoNCj4gPiArCQlkYTkxNTBfZmdfc29jX2V2ZW50X2NvbmZpZyhmZyk7DQo+ID4g Kw0KPiA+ICsJLyogQ2xlYXIgYW55IEZHIElSUXMgKi8NCj4gPiArCWRhOTE1MF9mZ193cml0ZV9h dHRyKGZnLCBEQTkxNTBfUUlGX0VfRkdfU1RBVFVTLA0KPiA+ICsJCQkgICAgIERBOTE1MF9RSUZf RV9GR19TVEFUVVNfU0laRSwgZV9mZ19zdGF0dXMpOw0KPiA+ICsNCj4gPiArCXJldHVybiBJUlFf SEFORExFRDsNCj4gPiArfQ0KPiA+ICsNCj4gPg0KPiA+IFsuLi5dDQo+ID4NCj4gPiArc3RhdGlj IGludCBkYTkxNTBfZmdfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikNCj4gPiAr ew0KPiA+ICsJc3RydWN0IGRldmljZSAqZGV2ID0gJnBkZXYtPmRldjsNCj4gPiArCXN0cnVjdCBk YTkxNTAgKmRhOTE1MCA9IGRldl9nZXRfZHJ2ZGF0YShkZXYtPnBhcmVudCk7DQo+ID4gKwlzdHJ1 Y3QgZGE5MTUwX2ZnX3BkYXRhICpmZ19wZGF0YSA9IGRldl9nZXRfcGxhdGRhdGEoZGV2KTsNCj4g PiArCXN0cnVjdCBkYTkxNTBfZmcgKmZnOw0KPiA+ICsJaW50IHZlciwgaXJxLCByZXQ7DQo+ID4g Kw0KPiA+ICsJZmcgPSBkZXZtX2t6YWxsb2MoZGV2LCBzaXplb2YoKmZnKSwgR0ZQX0tFUk5FTCk7 DQo+ID4gKwlpZiAoZmcgPT0gTlVMTCkNCj4gPiArCQlyZXR1cm4gLUVOT01FTTsNCj4gPiArDQo+ ID4gKwlwbGF0Zm9ybV9zZXRfZHJ2ZGF0YShwZGV2LCBmZyk7DQo+ID4gKwlmZy0+ZGE5MTUwID0g ZGE5MTUwOw0KPiA+ICsJZmctPmRldiA9IGRldjsNCj4gPiArDQo+ID4gKwltdXRleF9pbml0KCZm Zy0+aW9fbG9jayk7DQo+ID4gKw0KPiA+ICsJLyogRW5hYmxlIFFJRiAqLw0KPiA+ICsJZGE5MTUw X3NldF9iaXRzKGRhOTE1MCwgREE5MTUwX0NPUkUyV0lSRV9DVFJMX0EsDQo+IERBOTE1MF9GR19R SUZfRU5fTUFTSywNCj4gPiArCQkJREE5MTUwX0ZHX1FJRl9FTl9NQVNLKTsNCj4gPiArDQo+ID4g KwlmZy0+YmF0dGVyeSA9IHBvd2VyX3N1cHBseV9yZWdpc3RlcihkZXYsICZmZ19kZXNjLCBOVUxM KTsNCj4gPiArCWlmIChJU19FUlIoZmctPmJhdHRlcnkpKSB7DQo+ID4gKwkJcmV0ID0gUFRSX0VS UihmZy0+YmF0dGVyeSk7DQo+ID4gKwkJcmV0dXJuIHJldDsNCj4gPiArCX0NCj4gDQo+IFBsZWFz ZSB1c2UgZGV2bV9wb3dlcl9zdXBwbHlfcmVnaXN0ZXIoLi4uKSB0byBzaW1wbGlmeSB0aGUgZHJp dmVyLg0KPiANCj4gPiArCXZlciA9IGRhOTE1MF9mZ19yZWFkX2F0dHIoZmcsIERBOTE1MF9RSUZf RldfTUFJTl9WRVIsDQo+ID4gKwkJCQkgIERBOTE1MF9RSUZfRldfTUFJTl9WRVJfU0laRSk7DQo+ ID4gKwlkZXZfaW5mbyhkZXYsICJWZXJzaW9uOiAweCV4XG4iLCB2ZXIpOw0KPiA+ICsNCj4gPiAr CS8qIEhhbmRsZSBEVCBkYXRhIGlmIHByb3ZpZGVkICovDQo+ID4gKwlpZiAoZGV2LT5vZl9ub2Rl KSB7DQo+ID4gKwkJZmdfcGRhdGEgPSBkYTkxNTBfZmdfZHRfcGRhdGEoZGV2KTsNCj4gPiArCQlk ZXYtPnBsYXRmb3JtX2RhdGEgPSBmZ19wZGF0YTsNCj4gPiArCX0NCj4gPiArDQo+ID4gKwkvKiBI YW5kbGUgYW55IHBkYXRhIHByb3ZpZGVkICovDQo+ID4gKwlpZiAoZmdfcGRhdGEpIHsNCj4gPiAr CQlmZy0+aW50ZXJ2YWwgPSBmZ19wZGF0YS0+dXBkYXRlX2ludGVydmFsOw0KPiA+ICsNCj4gPiAr CQlpZiAoZmdfcGRhdGEtPndhcm5fc29jX2x2bCA+IDEwMCkNCj4gPiArCQkJZGV2X3dhcm4oZGV2 LCAiSW52YWxpZCBTT0Mgd2FybmluZyBsZXZlbCBwcm92aWRlZCwNCj4gSWdub3JpbmciKTsNCj4g PiArCQllbHNlDQo+ID4gKwkJCWZnLT53YXJuX3NvYyA9IGZnX3BkYXRhLT53YXJuX3NvY19sdmw7 DQo+ID4gKw0KPiA+ICsJCWlmICgoZmdfcGRhdGEtPmNyaXRfc29jX2x2bCA+IDEwMCkgfHwNCj4g PiArCQkgICAgKGZnX3BkYXRhLT5jcml0X3NvY19sdmwgPj0gZmdfcGRhdGEtPndhcm5fc29jX2x2 bCkpDQo+ID4gKwkJCWRldl93YXJuKGRldiwgIkludmFsaWQgU09DIGNyaXRpY2FsIGxldmVsIHBy b3ZpZGVkLA0KPiBJZ25vcmluZyIpOw0KPiA+ICsJCWVsc2UNCj4gPiArCQkJZmctPmNyaXRfc29j ID0gZmdfcGRhdGEtPmNyaXRfc29jX2x2bDsNCj4gPiArDQo+ID4gKw0KPiA+ICsJfQ0KPiA+ICsN Cj4gPiArCS8qIENvbmZpZ3VyZSBpbml0aWFsIFNPQyBsZXZlbCBldmVudHMgKi8NCj4gPiArCWRh OTE1MF9mZ19zb2NfZXZlbnRfY29uZmlnKGZnKTsNCj4gPiArDQo+ID4gKwkvKg0KPiA+ICsJICog SWYgYW4gaW50ZXJ2YWwgcGVyaW9kIGhhcyBiZWVuIHByb3ZpZGVkIHRoZW4gc2V0dXAgcmVwZWF0 aW5nDQo+ID4gKwkgKiB3b3JrIGZvciByZXBvcnRpbmcgZGF0YSB1cGRhdGVzLg0KPiA+ICsJICov DQo+ID4gKwlpZiAoZmctPmludGVydmFsKSB7DQo+ID4gKwkJSU5JVF9ERUxBWUVEX1dPUksoJmZn LT53b3JrLCBkYTkxNTBfZmdfd29yayk7DQo+ID4gKwkJc2NoZWR1bGVfZGVsYXllZF93b3JrKCZm Zy0+d29yaywNCj4gPiArCQkJCSAgICAgIG1zZWNzX3RvX2ppZmZpZXMoZmctPmludGVydmFsKSk7 DQo+ID4gKwl9DQo+ID4gKw0KPiA+ICsJLyogUmVnaXN0ZXIgSVJRICovDQo+ID4gKwlpcnEgPSBw bGF0Zm9ybV9nZXRfaXJxX2J5bmFtZShwZGV2LCAiRkciKTsNCj4gPiArCXJldCA9IHJlcXVlc3Rf dGhyZWFkZWRfaXJxKGlycSwgTlVMTCwgZGE5MTUwX2ZnX2lycSwgSVJRRl9PTkVTSE9ULCAiRkci LA0KPiA+ICsJCQkJICAgZmcpOw0KPiA+ICsJaWYgKHJldCkNCj4gPiArCQlnb3RvIGlycV9mYWls Ow0KPiA+ICsNCj4gPiArCXJldHVybiByZXQ7DQo+ID4gKw0KPiA+ICtpcnFfZmFpbDoNCj4gPiAr CWNhbmNlbF9kZWxheWVkX3dvcmsoJmZnLT53b3JrKTsNCj4gPiArCXBvd2VyX3N1cHBseV91bnJl Z2lzdGVyKGZnLT5iYXR0ZXJ5KTsNCj4gPiArDQo+ID4gKwlyZXR1cm4gcmV0Ow0KPiA+ICt9DQo+ ID4gKw0KPiA+ICtzdGF0aWMgaW50IGRhOTE1MF9mZ19yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2Rl dmljZSAqcGRldikNCj4gPiArew0KPiA+ICsJc3RydWN0IGRhOTE1MF9mZyAqZmcgPSBwbGF0Zm9y bV9nZXRfZHJ2ZGF0YShwZGV2KTsNCj4gPiArCWludCBpcnE7DQo+ID4gKw0KPiA+ICsJaXJxID0g cGxhdGZvcm1fZ2V0X2lycV9ieW5hbWUocGRldiwgIkZHIik7DQo+ID4gKwlmcmVlX2lycShpcnEs IGZnKTsNCj4gPiArDQo+ID4gKwlpZiAoZmctPmludGVydmFsKQ0KPiA+ICsJCWNhbmNlbF9kZWxh eWVkX3dvcmsoJmZnLT53b3JrKTsNCj4gDQo+IEl0IGxvb2tzIGxpa2UgdGhlIG9yZGVyIG9mIGly cSBmcmVlaW5nIGFuZCBjYW5jZWxpbmcgb2YgdGhlDQo+IGRlbGF5ZWQgd29yayBpcyBub3QgaW1w b3J0YW50LiBJbiB0aGF0IGNhc2UgSSBzdWdnZXN0IHN3aXRjaGluZw0KPiB0byBkZXZtX3JlcXVl c3RfdGhyZWFkZWRfaXJxKC4uLikuDQo+IA0KDQpZZXMsIHlvdSdyZSByaWdodC4gVGhlcmUncyBu byBvcmRlcmluZyBkZXBlbmRlbmN5LiBXaWxsIHVzZSBkZXZtLg0KDQo+ID4gKwlwb3dlcl9zdXBw bHlfdW5yZWdpc3RlcihmZy0+YmF0dGVyeSk7DQo+ID4gKw0KPiA+ICsJcmV0dXJuIDA7DQo+ID4g K30NCj4gPg0KPiA+IFsuLi5dDQo+ID4NCj4gPiArDQo+ID4gK01PRFVMRV9ERVNDUklQVElPTigi RnVlbC1HYXVnZSBEcml2ZXIgZm9yIERBOTE1MCIpOw0KPiA+ICtNT0RVTEVfQVVUSE9SKCJBZGFt IFRob21zb24NCj4gPEFkYW0uVGhvbXNvbi5PcGVuc291cmNlQGRpYXNlbWkuY29tPiIpOw0KPiA+ ICtNT0RVTEVfTElDRU5TRSgiR1BMIik7DQo+IA0KPiBNT0RVTEVfTElDRU5TRSgiR1BMIHYyIik7 DQoNCklmIEkgZG8gdGhpcyB0aGVuIEkgbmVlZCB0byB1cGRhdGUgdGhlIGZpbGUgbGljZW5zZSBk aXNjbGFpbWVyIGF0IHRoZSB0b3AsIGFzDQpyaWdodCBub3cgdGhleSBtYXRjaCBhbmQgYXJlIGNv cnJlY3QgYXMgZmFyIGFzIEkgY2FuIHRlbGwuIElzIHRoaXMgY2hhbmdlIG5lZWRlZA0KYW5kIGlm IHNvIGlzIHRoaXMgdGhlIGludGVudGlvbiBmb3Igb3RoZXIgZHJpdmVycyBhcyB3ZWxsLCBqdXN0 IHNvIEknbSBjbGVhcj8NCg==