Re: [PATCH v8 6/9] Bluetooth: btintel: Add a callback function to configure data path

[Marcel Holtmann <marcel@holtmann.org>]

Hi Kiran,

> In HFP offload usecase, Intel controllers require offload use
> case id (NBS or WBS) to be set before opening SCO connection. Define
> a new callback which gets called on setsockopt SCO socket. User space
> audio module is expected to set codec via setsockopt(sk, BT_CODEC, ....)
> before opening SCO connection.
> 
> Signed-off-by: Kiran K <kiran.k@intel.com>
> Reviewed-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> Reviewed-by: Srivatsa Ravishankar <ravishankar.srivatsa@intel.com>
> ---
> 
> This callback gets called when audio module does setsockopt(sk, BT_CODEC,...)
> on SCO socket and data_path is 1 (non-HCI transport). For non-HCI transport,
> Intel controller expects presets to be set before opening SCO connection.
> Presets are pre-defined, 0 - NBS, 1 - WBS. Likewise additional presets will
> be defined for A2DP, LE Audio offload use cases.
> 
> drivers/bluetooth/btintel.c      | 50 ++++++++++++++++++++++++++++++++
> drivers/bluetooth/btintel.h      |  8 +++++
> drivers/bluetooth/btusb.c        |  1 +
> include/net/bluetooth/hci.h      |  8 +++++
> include/net/bluetooth/hci_core.h |  2 ++
> 5 files changed, 69 insertions(+)

same thing here. Please introduce the callbacks as one patch and then in a separate patch, you start using them in a driver.

Regards

Marcel