All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Alain Michaud <alainm@chromium.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v1 2/3] bluetooth: Support querying for WBS support through MGMT
Date: Fri, 28 Feb 2020 08:56:07 +0100	[thread overview]
Message-ID: <2F226B27-7F8F-4E70-AA80-24BE2DC89DA3@holtmann.org> (raw)
In-Reply-To: <20200227182938.110670-3-alainm@chromium.org>

Hi Alain,

> This patch provides a mechanism for MGMT interface client to query the
> capability of the controller to support WBS.
> 
> Signed-off-by: Alain Michaud <alainm@chromium.org>
> ---
> 
> drivers/bluetooth/btusb.c    | 3 +++
> include/net/bluetooth/hci.h  | 9 +++++++++
> include/net/bluetooth/mgmt.h | 1 +
> net/bluetooth/mgmt.c         | 4 ++++
> 4 files changed, 17 insertions(+)

patch has been applied to bluetooth-next tree.

However ..

> +
> +	/* When this quirt is set, wide band speech is supported by
> +	 * the driver since no reliable mechanism exist to report
> +	 * this from the hardware, a driver flag is use to convey
> +	 * this support
> +	 *
> +	 * This quirk must be set before hci_register_dev is called.
> +	 */
> +	HCI_QUIRK_WIDE_BAND_SPEECH_SUPPORTED,
> };

quirt - a short-handled riding whip with a braided leather lash.

.. this totally made my day and I was tempted to leave this typo in the code, but I fixed it up in the end ;)

Regards

Marcel


  reply	other threads:[~2020-02-28  7:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 18:29 [PATCH v1 0/3] This series allows a higher level HFP implementation to enable wbs Alain Michaud
2020-02-27 18:29 ` [PATCH v1 1/3] bluetooth: Add flag to define wideband speech capability Alain Michaud
2020-02-28  7:56   ` Marcel Holtmann
2020-02-27 18:29 ` [PATCH v1 2/3] bluetooth: Support querying for WBS support through MGMT Alain Michaud
2020-02-28  7:56   ` Marcel Holtmann [this message]
2020-02-27 18:29 ` [PATCH v1 3/3] bluetooth: Enable erroneous data reporting if wbs is supported Alain Michaud
2020-02-28  8:06   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2F226B27-7F8F-4E70-AA80-24BE2DC89DA3@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=alainm@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.