From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1381C2B9F4 for ; Fri, 25 Jun 2021 05:16:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB04D6141E for ; Fri, 25 Jun 2021 05:16:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233105AbhFYFSm (ORCPT ); Fri, 25 Jun 2021 01:18:42 -0400 Received: from mta-11-4.privateemail.com ([198.54.127.104]:4826 "EHLO MTA-11-4.privateemail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbhFYFSl (ORCPT ); Fri, 25 Jun 2021 01:18:41 -0400 X-Greylist: delayed 124202 seconds by postgrey-1.27 at vger.kernel.org; Fri, 25 Jun 2021 01:18:41 EDT Received: from mta-11.privateemail.com (localhost [127.0.0.1]) by mta-11.privateemail.com (Postfix) with ESMTP id 60C3680094; Fri, 25 Jun 2021 01:16:21 -0400 (EDT) Received: from [192.168.0.46] (unknown [10.20.151.241]) by mta-11.privateemail.com (Postfix) with ESMTPA id B114C8008B; Fri, 25 Jun 2021 01:16:20 -0400 (EDT) Date: Fri, 25 Jun 2021 01:16:14 -0400 From: Hamza Mahfooz Subject: Re: Question regarding the TODO in virt/kvm/kvm_main.c:226 To: Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <2ZR8VQ.IJMS3PQLNFAS3@effective-light.com> In-Reply-To: References: X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping On Tue, May 25 2021 at 07:45:53 AM -0400, Hamza Mahfooz wrote: > Would it be preferable to remove kvm_arch_vcpu_should_kick or > kvm_request_needs_ipi when merging them. I ask since, the last time I > checked, both functions are only used in kvm_main.c on Linus's tree. >