From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,PDS_BTC_ID,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1EAC38A2A for ; Fri, 8 May 2020 09:07:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0F4E20731 for ; Fri, 8 May 2020 09:07:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725825AbgEHJHh convert rfc822-to-8bit (ORCPT ); Fri, 8 May 2020 05:07:37 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:40088 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725710AbgEHJHh (ORCPT ); Fri, 8 May 2020 05:07:37 -0400 Received: from mail.corsac.net (unknown [78.194.244.226]) by smtp2-g21.free.fr (Postfix) with ESMTPS id B4963200440 for ; Fri, 8 May 2020 11:07:34 +0200 (CEST) Received: from scapa.corsac.net (unknown [IPv6:2a01:e34:ec2f:4e20:6af7:28ff:fe8d:2119]) by mail.corsac.net (Postfix) with ESMTPS id 8086290 for ; Fri, 8 May 2020 11:07:00 +0200 (CEST) Received: from corsac (uid 1000) (envelope-from corsac@debian.org) id a024a by scapa.corsac.net (DragonFly Mail Agent v0.12); Fri, 08 May 2020 11:07:00 +0200 Message-ID: <2a05f4c4362d386d298a06a67f2f528ef603a734.camel@debian.org> Subject: Re: [PATCH] drm/atomic: Take the atomic toys away from X From: Yves-Alexis Perez To: Daniel Vetter , DRI Development Cc: Intel Graphics Development , Ilia Mirkin , Maarten Lankhorst , Nicholas Kazlauskas , Michel =?ISO-8859-1?Q?D=E4nzer?= , Alex Deucher , Adam Jackson , Sean Paul , David Airlie , Rob Clark , stable@vger.kernel.org, Daniel Vetter Date: Fri, 08 May 2020 11:06:56 +0200 In-Reply-To: <20190905185318.31363-1-daniel.vetter@ffwll.ch> References: <20190903190642.32588-1-daniel.vetter@ffwll.ch> <20190905185318.31363-1-daniel.vetter@ffwll.ch> Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.2-1 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On Thu, 2019-09-05 at 20:53 +0200, Daniel Vetter wrote: > The -modesetting ddx has a totally broken idea of how atomic works: > - doesn't disable old connectors, assuming they get auto-disable like > with the legacy setcrtc > - assumes ASYNC_FLIP is wired through for the atomic ioctl > - not a single call to TEST_ONLY > > Iow the implementation is a 1:1 translation of legacy ioctls to > atomic, which is a) broken b) pointless. > > We already have bugs in both i915 and amdgpu-DC where this prevents us > from enabling neat features. > > If anyone ever cares about atomic in X we can easily add a new atomic > level (req->value == 2) for X to get back the shiny toys. > > Since these broken versions of -modesetting have been shipping, > there's really no other way to get out of this bind. Hi Daniel and Greg (especially). It seems that this patch was never applied to stable, maybe it fell through the cracks? It doesn't apply as-is in 4.19 branch but a small change in the context makes it apply. I'm experiencing issues with lightdm and vt-switch in Debian Buster (which has a 4.19 kernel) so I'd appreciate if the patch was included in at least that release. Regards, - -- Yves-Alexis -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE8vi34Qgfo83x35gF3rYcyPpXRFsFAl61ITAACgkQ3rYcyPpX RFvlaAf9HZ0DTX1fAkNeNFoAgn4pFztnFq0fAwGj5iVIL4q6upE1wE3E8cDgUHeT maQQvL3YHFXjgzgDHYNIuUMipFE1Djymoy+EB4ZoOftqsJ4CPy4pCMUAh57u7BrV T+eBtj4n0wY0SgvoPism3QdbxY7CLLgCMJKLNrCPlkDCdJyGsZX9RIgfqvbkGM36 ftwBKcyy1iW5cAv10ehiXi/1zszA8bx2gULim3abcSjjz12ckNvBPy/BDvfFx19V 8cGgG3qD9PLmxRl80H1/mX30Ddw8Md5Fu7I/ndh3EGXLu8p8zod0rQVCQjAEW4X4 ew4tajDD2l9vWzN0sZIlyjq9fNgXBw== =lPBO -----END PGP SIGNATURE----- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,PDS_BTC_ID,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB71C28CBC for ; Sat, 9 May 2020 09:05:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B71F324957 for ; Sat, 9 May 2020 09:05:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B71F324957 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 69B926E2EC; Sat, 9 May 2020 09:04:58 +0000 (UTC) Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [212.27.42.2]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F9056E147 for ; Fri, 8 May 2020 09:07:08 +0000 (UTC) Received: from mail.corsac.net (unknown [78.194.244.226]) by smtp2-g21.free.fr (Postfix) with ESMTPS id 1F23920040F for ; Fri, 8 May 2020 11:07:05 +0200 (CEST) Received: from scapa.corsac.net (unknown [IPv6:2a01:e34:ec2f:4e20:6af7:28ff:fe8d:2119]) by mail.corsac.net (Postfix) with ESMTPS id A0DC697 for ; Fri, 8 May 2020 11:07:00 +0200 (CEST) Received: from corsac (uid 1000) (envelope-from corsac@debian.org) id a024a by scapa.corsac.net (DragonFly Mail Agent v0.12); Fri, 08 May 2020 11:07:00 +0200 Message-ID: <2a05f4c4362d386d298a06a67f2f528ef603a734.camel@debian.org> Subject: Re: [PATCH] drm/atomic: Take the atomic toys away from X From: Yves-Alexis Perez To: Daniel Vetter , DRI Development Date: Fri, 08 May 2020 11:06:56 +0200 In-Reply-To: <20190905185318.31363-1-daniel.vetter@ffwll.ch> References: <20190903190642.32588-1-daniel.vetter@ffwll.ch> <20190905185318.31363-1-daniel.vetter@ffwll.ch> User-Agent: Evolution 3.36.2-1 MIME-Version: 1.0 X-Mailman-Approved-At: Sat, 09 May 2020 09:04:57 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Michel =?ISO-8859-1?Q?D=E4nzer?= , stable@vger.kernel.org, Nicholas Kazlauskas , Daniel Vetter , Sean Paul , Intel Graphics Development Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On Thu, 2019-09-05 at 20:53 +0200, Daniel Vetter wrote: > The -modesetting ddx has a totally broken idea of how atomic works: > - doesn't disable old connectors, assuming they get auto-disable like > with the legacy setcrtc > - assumes ASYNC_FLIP is wired through for the atomic ioctl > - not a single call to TEST_ONLY > > Iow the implementation is a 1:1 translation of legacy ioctls to > atomic, which is a) broken b) pointless. > > We already have bugs in both i915 and amdgpu-DC where this prevents us > from enabling neat features. > > If anyone ever cares about atomic in X we can easily add a new atomic > level (req->value == 2) for X to get back the shiny toys. > > Since these broken versions of -modesetting have been shipping, > there's really no other way to get out of this bind. Hi Daniel and Greg (especially). It seems that this patch was never applied to stable, maybe it fell through the cracks? It doesn't apply as-is in 4.19 branch but a small change in the context makes it apply. I'm experiencing issues with lightdm and vt-switch in Debian Buster (which has a 4.19 kernel) so I'd appreciate if the patch was included in at least that release. Regards, - -- Yves-Alexis -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE8vi34Qgfo83x35gF3rYcyPpXRFsFAl61ITAACgkQ3rYcyPpX RFvlaAf9HZ0DTX1fAkNeNFoAgn4pFztnFq0fAwGj5iVIL4q6upE1wE3E8cDgUHeT maQQvL3YHFXjgzgDHYNIuUMipFE1Djymoy+EB4ZoOftqsJ4CPy4pCMUAh57u7BrV T+eBtj4n0wY0SgvoPism3QdbxY7CLLgCMJKLNrCPlkDCdJyGsZX9RIgfqvbkGM36 ftwBKcyy1iW5cAv10ehiXi/1zszA8bx2gULim3abcSjjz12ckNvBPy/BDvfFx19V 8cGgG3qD9PLmxRl80H1/mX30Ddw8Md5Fu7I/ndh3EGXLu8p8zod0rQVCQjAEW4X4 ew4tajDD2l9vWzN0sZIlyjq9fNgXBw== =lPBO -----END PGP SIGNATURE----- _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,PDS_BTC_ID,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A65BFC38A2A for ; Fri, 8 May 2020 09:07:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FEA5208D6 for ; Fri, 8 May 2020 09:07:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FEA5208D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E05A6E147; Fri, 8 May 2020 09:07:10 +0000 (UTC) Received: from smtp6-g21.free.fr (smtp6-g21.free.fr [212.27.42.6]) by gabe.freedesktop.org (Postfix) with ESMTPS id 072286E147 for ; Fri, 8 May 2020 09:07:09 +0000 (UTC) Received: from mail.corsac.net (unknown [IPv6:2a01:e34:ec2f:4e20::5]) by smtp6-g21.free.fr (Postfix) with ESMTPS id F384D780389 for ; Fri, 8 May 2020 11:07:05 +0200 (CEST) Received: from scapa.corsac.net (unknown [IPv6:2a01:e34:ec2f:4e20:6af7:28ff:fe8d:2119]) by mail.corsac.net (Postfix) with ESMTPS id A342998 for ; Fri, 8 May 2020 11:07:00 +0200 (CEST) Received: from corsac (uid 1000) (envelope-from corsac@debian.org) id a024a by scapa.corsac.net (DragonFly Mail Agent v0.12); Fri, 08 May 2020 11:07:00 +0200 Message-ID: <2a05f4c4362d386d298a06a67f2f528ef603a734.camel@debian.org> From: Yves-Alexis Perez To: Daniel Vetter , DRI Development Date: Fri, 08 May 2020 11:06:56 +0200 In-Reply-To: <20190905185318.31363-1-daniel.vetter@ffwll.ch> References: <20190903190642.32588-1-daniel.vetter@ffwll.ch> <20190905185318.31363-1-daniel.vetter@ffwll.ch> User-Agent: Evolution 3.36.2-1 MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/atomic: Take the atomic toys away from X X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Michel =?ISO-8859-1?Q?D=E4nzer?= , stable@vger.kernel.org, Nicholas Kazlauskas , Adam Jackson , Alex Deucher , Daniel Vetter , Intel Graphics Development , Ilia Mirkin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On Thu, 2019-09-05 at 20:53 +0200, Daniel Vetter wrote: > The -modesetting ddx has a totally broken idea of how atomic works: > - doesn't disable old connectors, assuming they get auto-disable like > with the legacy setcrtc > - assumes ASYNC_FLIP is wired through for the atomic ioctl > - not a single call to TEST_ONLY > > Iow the implementation is a 1:1 translation of legacy ioctls to > atomic, which is a) broken b) pointless. > > We already have bugs in both i915 and amdgpu-DC where this prevents us > from enabling neat features. > > If anyone ever cares about atomic in X we can easily add a new atomic > level (req->value == 2) for X to get back the shiny toys. > > Since these broken versions of -modesetting have been shipping, > there's really no other way to get out of this bind. Hi Daniel and Greg (especially). It seems that this patch was never applied to stable, maybe it fell through the cracks? It doesn't apply as-is in 4.19 branch but a small change in the context makes it apply. I'm experiencing issues with lightdm and vt-switch in Debian Buster (which has a 4.19 kernel) so I'd appreciate if the patch was included in at least that release. Regards, - -- Yves-Alexis -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE8vi34Qgfo83x35gF3rYcyPpXRFsFAl61ITAACgkQ3rYcyPpX RFvlaAf9HZ0DTX1fAkNeNFoAgn4pFztnFq0fAwGj5iVIL4q6upE1wE3E8cDgUHeT maQQvL3YHFXjgzgDHYNIuUMipFE1Djymoy+EB4ZoOftqsJ4CPy4pCMUAh57u7BrV T+eBtj4n0wY0SgvoPism3QdbxY7CLLgCMJKLNrCPlkDCdJyGsZX9RIgfqvbkGM36 ftwBKcyy1iW5cAv10ehiXi/1zszA8bx2gULim3abcSjjz12ckNvBPy/BDvfFx19V 8cGgG3qD9PLmxRl80H1/mX30Ddw8Md5Fu7I/ndh3EGXLu8p8zod0rQVCQjAEW4X4 ew4tajDD2l9vWzN0sZIlyjq9fNgXBw== =lPBO -----END PGP SIGNATURE----- _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx