From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH v8 bpf-next 6/9] bpf: introduce BPF_RAW_TRACEPOINT Date: Wed, 28 Mar 2018 12:38:48 -0700 Message-ID: <2a0f6ac2-b13e-b8ad-31b4-a42909a34efa@fb.com> References: <20180328190540.370956-1-ast@kernel.org> <20180328190540.370956-7-ast@kernel.org> <20180328153435.5e733957@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , , , , , , To: Steven Rostedt , Alexei Starovoitov Return-path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:44980 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752377AbeC1Tjg (ORCPT ); Wed, 28 Mar 2018 15:39:36 -0400 In-Reply-To: <20180328153435.5e733957@gandalf.local.home> Sender: netdev-owner@vger.kernel.org List-ID: On 3/28/18 12:34 PM, Steven Rostedt wrote: > On Wed, 28 Mar 2018 12:05:37 -0700 > Alexei Starovoitov wrote: > >> +++ b/include/linux/tracepoint-defs.h >> @@ -35,4 +35,10 @@ struct tracepoint { >> struct tracepoint_func __rcu *funcs; >> }; >> >> +struct bpf_raw_event_map { >> + struct tracepoint *tp; >> + void *bpf_func; >> + u32 num_args; >> +} __aligned(32); >> + > > If you prefer v7, I'm fine with that. For cache issues, I can pull out > the funcs from the tracepoint structure like I posted. I very much prefer to land this v8 as-is and optimize later. I still have bpfilter/microkernel patches to finish which were practically ready two weeks ago and got delayed but this set. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH v8 bpf-next 6/9] bpf: introduce BPF_RAW_TRACEPOINT Date: Wed, 28 Mar 2018 12:38:48 -0700 Message-ID: <2a0f6ac2-b13e-b8ad-31b4-a42909a34efa@fb.com> References: <20180328190540.370956-1-ast@kernel.org> <20180328190540.370956-7-ast@kernel.org> <20180328153435.5e733957@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180328153435.5e733957@gandalf.local.home> Sender: netdev-owner@vger.kernel.org To: Steven Rostedt , Alexei Starovoitov Cc: davem@davemloft.net, daniel@iogearbox.net, torvalds@linux-foundation.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, netdev@vger.kernel.org, kernel-team@fb.com, linux-api@vger.kernel.org List-Id: linux-api@vger.kernel.org On 3/28/18 12:34 PM, Steven Rostedt wrote: > On Wed, 28 Mar 2018 12:05:37 -0700 > Alexei Starovoitov wrote: > >> +++ b/include/linux/tracepoint-defs.h >> @@ -35,4 +35,10 @@ struct tracepoint { >> struct tracepoint_func __rcu *funcs; >> }; >> >> +struct bpf_raw_event_map { >> + struct tracepoint *tp; >> + void *bpf_func; >> + u32 num_args; >> +} __aligned(32); >> + > > If you prefer v7, I'm fine with that. For cache issues, I can pull out > the funcs from the tracepoint structure like I posted. I very much prefer to land this v8 as-is and optimize later. I still have bpfilter/microkernel patches to finish which were practically ready two weeks ago and got delayed but this set.