From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1CA468 for ; Mon, 6 Dec 2021 17:39:23 +0000 (UTC) Received: from ip4d173d4a.dynamic.kabel-deutschland.de ([77.23.61.74] helo=[192.168.66.200]); authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1muHxR-0004bW-B6; Mon, 06 Dec 2021 18:39:21 +0100 Message-ID: <2a181fd4-9248-d68d-7eee-43b19db96461@leemhuis.info> Date: Mon, 6 Dec 2021 18:39:19 +0100 Precedence: bulk X-Mailing-List: mhi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] bus: mhi: core: Add support for forced PM resume Content-Language: en-BS To: Manivannan Sadhasivam , mhi@lists.linux.dev Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org, loic.poulain@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, kvalo@codeaurora.org, stable@vger.kernel.org, Pengyu Ma References: <20211206161059.107007-1-manivannan.sadhasivam@linaro.org> From: Thorsten Leemhuis In-Reply-To: <20211206161059.107007-1-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1638812363;34fe6703; X-HE-SMSGID: 1muHxR-0004bW-B6 Hi, this is your Linux kernel regression tracker speaking. On 06.12.21 17:10, Manivannan Sadhasivam wrote: > From: Loic Poulain > > For whatever reason, some devices like QCA6390, WCN6855 using ath11k > are not in M3 state during PM resume, but still functional. The > mhi_pm_resume should then not fail in those cases, and let the higher > level device specific stack continue resuming process. > > Add a new parameter to mhi_pm_resume, to force resuming, whatever the > current MHI state is. This fixes a regression with non functional > ath11k WiFi after suspend/resume cycle on some machines. > > Bug report: https://bugzilla.kernel.org/show_bug.cgi?id=214179 > > Cc: stable@vger.kernel.org #5.13 > Fixes: 020d3b26c07a ("bus: mhi: Early MHI resume failure in non M3 state") > Reported-by: Kalle Valo > Reported-by: Pengyu Ma FWIW: In case you need to send an improved patch, could you please add this before the 'Reported-by:' (see (¹) below for the reasoning): Link: https://lore.kernel.org/regressions/871r5p0x2u.fsf@codeaurora.org/ And if the patch is already good to go: could the subsystem maintainer please add it when applying? See(¹) for the reasoning. Thx. Ciao, Thorsten, your Linux kernel regression tracker. (¹) Long story: The commit message would benefit from a link to the regression report on the mailing list, for reasons explained in Documentation/process/submitting-patches.rst. To quote: ``` If related discussions or any other background information behind the change can be found on the web, add 'Link:' tags pointing to it. In case your patch fixes a bug, for example, add a tag with a URL referencing the report in the mailing list archives or a bug tracker; ``` This concept is old, but the text was reworked recently to make this use case for the Link: tag clearer. For details see: https://git.kernel.org/linus/1f57bd42b77c Yes, that "Link:" is not really crucial; but it's good to have if someone needs to look into the backstory of this change sometime in the future. But I care for a different reason. I'm tracking this regression (and others) with regzbot, my Linux kernel regression tracking bot. This bot will notice if a patch with a Link: tag to a tracked regression gets posted and record that, which allowed anyone looking into the regression to quickly gasp the current status from regzbot's webui (https://linux-regtracking.leemhuis.info/regzbot ) or its reports. The bot will also notice if a commit with a Link: tag to a regression report is applied by Linus and then automatically mark the regression as resolved then. IOW: this tag makes my life a regression tracker a lot easier, as I otherwise have to tell regzbot manually when the fix lands. :-/ P.S.: As a Linux kernel regression tracker I'm getting a lot of reports on my table. I can only look briefly into most of them. Unfortunately therefore I sometimes will get things wrong or miss something important. I hope that's not the case here; if you think it is, don't hesitate to tell me about it in a public reply. That's in everyone's interest, as what I wrote above might be misleading to everyone reading this; any suggestion I gave they thus might sent someone reading this down the wrong rabbit hole, which none of us wants. BTW, I have no personal interest in this issue, which is tracked using regzbot, my Linux kernel regression tracking bot (https://linux-regtracking.leemhuis.info/regzbot/). I'm only posting this mail to get things rolling again and hence don't need to be CC on all further activities wrt to this regression. #regzbot ^backmonitor: https://lore.kernel.org/regressions/871r5p0x2u.fsf@codeaurora.org/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64E8BC433EF for ; Mon, 6 Dec 2021 17:39:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CtaPWkGnAzSlmqPa9LMhH1TEKDpdMPFTT9sEjNQ9wbg=; b=jk5c8KptxAmxG6 xe0BQu2PysO5lId3crJCiNHL2G9bfH80ewYaWqtCyZAp6Pl7amIa3bhSGwMst1lvJ1YaCOOwvCvcT +81leJBtvTe08yhHIaeDAUaqYf/z5VUQtH/EQfRhfCwKfF6KQErDYf+ir9oV9lL5qCPWgS75e3Rwz SCxSZNeX9D7KMBzE0e3VjHTmGPGJQZMUC7dNVaspbPhX8yKhB50wgI2fVsPdzJPrqCNnKL74S+bOy jKdmkssy/moEssU98JkzYhsSgHJV/rlwH4OwQWGUsCOLJEr/kwtNi9TJC33KYHJtuCD4fkBXIdgzZ QVcujsg5iHxYpGlPxO7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muHxc-0056L1-2G; Mon, 06 Dec 2021 17:39:32 +0000 Received: from wp530.webpack.hosteurope.de ([2a01:488:42:1000:50ed:8234::]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muHxW-0056JI-OL for ath11k@lists.infradead.org; Mon, 06 Dec 2021 17:39:29 +0000 Received: from ip4d173d4a.dynamic.kabel-deutschland.de ([77.23.61.74] helo=[192.168.66.200]); authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1muHxR-0004bW-B6; Mon, 06 Dec 2021 18:39:21 +0100 Message-ID: <2a181fd4-9248-d68d-7eee-43b19db96461@leemhuis.info> Date: Mon, 6 Dec 2021 18:39:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] bus: mhi: core: Add support for forced PM resume Content-Language: en-BS To: Manivannan Sadhasivam , mhi@lists.linux.dev Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org, loic.poulain@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, kvalo@codeaurora.org, stable@vger.kernel.org, Pengyu Ma References: <20211206161059.107007-1-manivannan.sadhasivam@linaro.org> From: Thorsten Leemhuis In-Reply-To: <20211206161059.107007-1-manivannan.sadhasivam@linaro.org> X-bounce-key: webpack.hosteurope.de; regressions@leemhuis.info; 1638812366; c43d493f; X-HE-SMSGID: 1muHxR-0004bW-B6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_093926_989240_1D8FFBC6 X-CRM114-Status: GOOD ( 21.98 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org CkhpLCB0aGlzIGlzIHlvdXIgTGludXgga2VybmVsIHJlZ3Jlc3Npb24gdHJhY2tlciBzcGVha2lu Zy4KCk9uIDA2LjEyLjIxIDE3OjEwLCBNYW5pdmFubmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4gRnJv bTogTG9pYyBQb3VsYWluIDxsb2ljLnBvdWxhaW5AbGluYXJvLm9yZz4KPiAKPiBGb3Igd2hhdGV2 ZXIgcmVhc29uLCBzb21lIGRldmljZXMgbGlrZSBRQ0E2MzkwLCBXQ042ODU1IHVzaW5nIGF0aDEx awo+IGFyZSBub3QgaW4gTTMgc3RhdGUgZHVyaW5nIFBNIHJlc3VtZSwgYnV0IHN0aWxsIGZ1bmN0 aW9uYWwuIFRoZQo+IG1oaV9wbV9yZXN1bWUgc2hvdWxkIHRoZW4gbm90IGZhaWwgaW4gdGhvc2Ug Y2FzZXMsIGFuZCBsZXQgdGhlIGhpZ2hlcgo+IGxldmVsIGRldmljZSBzcGVjaWZpYyBzdGFjayBj b250aW51ZSByZXN1bWluZyBwcm9jZXNzLgo+IAo+IEFkZCBhIG5ldyBwYXJhbWV0ZXIgdG8gbWhp X3BtX3Jlc3VtZSwgdG8gZm9yY2UgcmVzdW1pbmcsIHdoYXRldmVyIHRoZQo+IGN1cnJlbnQgTUhJ IHN0YXRlIGlzLiBUaGlzIGZpeGVzIGEgcmVncmVzc2lvbiB3aXRoIG5vbiBmdW5jdGlvbmFsCj4g YXRoMTFrIFdpRmkgYWZ0ZXIgc3VzcGVuZC9yZXN1bWUgY3ljbGUgb24gc29tZSBtYWNoaW5lcy4K PiAKPiBCdWcgcmVwb3J0OiBodHRwczovL2J1Z3ppbGxhLmtlcm5lbC5vcmcvc2hvd19idWcuY2dp P2lkPTIxNDE3OQo+IAo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnICM1LjEzCj4gRml4ZXM6 IDAyMGQzYjI2YzA3YSAoImJ1czogbWhpOiBFYXJseSBNSEkgcmVzdW1lIGZhaWx1cmUgaW4gbm9u IE0zIHN0YXRlIikKPiBSZXBvcnRlZC1ieTogS2FsbGUgVmFsbyA8a3ZhbG9AY29kZWF1cm9yYS5v cmc+Cj4gUmVwb3J0ZWQtYnk6IFBlbmd5dSBNYSA8bWFwZW5neXVAZ21haWwuY29tPgoKRldJVzog SW4gY2FzZSB5b3UgbmVlZCB0byBzZW5kIGFuIGltcHJvdmVkIHBhdGNoLCBjb3VsZCB5b3UgcGxl YXNlIGFkZAp0aGlzIGJlZm9yZSB0aGUgJ1JlcG9ydGVkLWJ5OicgKHNlZSAowrkpIGJlbG93IGZv ciB0aGUgcmVhc29uaW5nKToKCkxpbms6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3JlZ3Jlc3Np b25zLzg3MXI1cDB4MnUuZnNmQGNvZGVhdXJvcmEub3JnLwoKQW5kIGlmIHRoZSBwYXRjaCBpcyBh bHJlYWR5IGdvb2QgdG8gZ286IGNvdWxkIHRoZSBzdWJzeXN0ZW0gbWFpbnRhaW5lcgpwbGVhc2Ug YWRkIGl0IHdoZW4gYXBwbHlpbmc/IFNlZSjCuSkgZm9yIHRoZSByZWFzb25pbmcuCgpUaHguCgpD aWFvLCBUaG9yc3RlbiwgeW91ciBMaW51eCBrZXJuZWwgcmVncmVzc2lvbiB0cmFja2VyLgoKKMK5 KSBMb25nIHN0b3J5OiBUaGUgY29tbWl0IG1lc3NhZ2Ugd291bGQgYmVuZWZpdCBmcm9tIGEgbGlu ayB0byB0aGUKcmVncmVzc2lvbiByZXBvcnQgb24gdGhlIG1haWxpbmcgbGlzdCwgZm9yIHJlYXNv bnMgZXhwbGFpbmVkIGluCkRvY3VtZW50YXRpb24vcHJvY2Vzcy9zdWJtaXR0aW5nLXBhdGNoZXMu cnN0LiBUbyBxdW90ZToKCmBgYApJZiByZWxhdGVkIGRpc2N1c3Npb25zIG9yIGFueSBvdGhlciBi YWNrZ3JvdW5kIGluZm9ybWF0aW9uIGJlaGluZCB0aGUKY2hhbmdlIGNhbiBiZSBmb3VuZCBvbiB0 aGUgd2ViLCBhZGQgJ0xpbms6JyB0YWdzIHBvaW50aW5nIHRvIGl0LiBJbiBjYXNlCnlvdXIgcGF0 Y2ggZml4ZXMgYSBidWcsIGZvciBleGFtcGxlLCBhZGQgYSB0YWcgd2l0aCBhIFVSTCByZWZlcmVu Y2luZwp0aGUgcmVwb3J0IGluIHRoZSBtYWlsaW5nIGxpc3QgYXJjaGl2ZXMgb3IgYSBidWcgdHJh Y2tlcjsKYGBgCgpUaGlzIGNvbmNlcHQgaXMgb2xkLCBidXQgdGhlIHRleHQgd2FzIHJld29ya2Vk IHJlY2VudGx5IHRvIG1ha2UgdGhpcyB1c2UKY2FzZSBmb3IgdGhlIExpbms6IHRhZyBjbGVhcmVy LiBGb3IgZGV0YWlscyBzZWU6Cmh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvbGludXMvMWY1N2JkNDJi NzdjCgpZZXMsIHRoYXQgIkxpbms6IiBpcyBub3QgcmVhbGx5IGNydWNpYWw7IGJ1dCBpdCdzIGdv b2QgdG8gaGF2ZSBpZgpzb21lb25lIG5lZWRzIHRvIGxvb2sgaW50byB0aGUgYmFja3N0b3J5IG9m IHRoaXMgY2hhbmdlIHNvbWV0aW1lIGluIHRoZQpmdXR1cmUuIEJ1dCBJIGNhcmUgZm9yIGEgZGlm ZmVyZW50IHJlYXNvbi4gSSdtIHRyYWNraW5nIHRoaXMgcmVncmVzc2lvbgooYW5kIG90aGVycykg d2l0aCByZWd6Ym90LCBteSBMaW51eCBrZXJuZWwgcmVncmVzc2lvbiB0cmFja2luZyBib3QuIFRo aXMKYm90IHdpbGwgbm90aWNlIGlmIGEgcGF0Y2ggd2l0aCBhIExpbms6IHRhZyB0byBhIHRyYWNr ZWQgcmVncmVzc2lvbiBnZXRzCnBvc3RlZCBhbmQgcmVjb3JkIHRoYXQsIHdoaWNoIGFsbG93ZWQg YW55b25lIGxvb2tpbmcgaW50byB0aGUgcmVncmVzc2lvbgp0byBxdWlja2x5IGdhc3AgdGhlIGN1 cnJlbnQgc3RhdHVzIGZyb20gcmVnemJvdCdzIHdlYnVpCihodHRwczovL2xpbnV4LXJlZ3RyYWNr aW5nLmxlZW1odWlzLmluZm8vcmVnemJvdCApIG9yIGl0cyByZXBvcnRzLiBUaGUKYm90IHdpbGwg YWxzbyBub3RpY2UgaWYgYSBjb21taXQgd2l0aCBhIExpbms6IHRhZyB0byBhIHJlZ3Jlc3Npb24g cmVwb3J0CmlzIGFwcGxpZWQgYnkgTGludXMgYW5kIHRoZW4gYXV0b21hdGljYWxseSBtYXJrIHRo ZSByZWdyZXNzaW9uIGFzCnJlc29sdmVkIHRoZW4uCgpJT1c6IHRoaXMgdGFnIG1ha2VzIG15IGxp ZmUgYSByZWdyZXNzaW9uIHRyYWNrZXIgYSBsb3QgZWFzaWVyLCBhcyBJCm90aGVyd2lzZSBoYXZl IHRvIHRlbGwgcmVnemJvdCBtYW51YWxseSB3aGVuIHRoZSBmaXggbGFuZHMuIDotLwoKUC5TLjog QXMgYSBMaW51eCBrZXJuZWwgcmVncmVzc2lvbiB0cmFja2VyIEknbSBnZXR0aW5nIGEgbG90IG9m IHJlcG9ydHMKb24gbXkgdGFibGUuIEkgY2FuIG9ubHkgbG9vayBicmllZmx5IGludG8gbW9zdCBv ZiB0aGVtLiBVbmZvcnR1bmF0ZWx5CnRoZXJlZm9yZSBJIHNvbWV0aW1lcyB3aWxsIGdldCB0aGlu Z3Mgd3Jvbmcgb3IgbWlzcyBzb21ldGhpbmcgaW1wb3J0YW50LgpJIGhvcGUgdGhhdCdzIG5vdCB0 aGUgY2FzZSBoZXJlOyBpZiB5b3UgdGhpbmsgaXQgaXMsIGRvbid0IGhlc2l0YXRlIHRvCnRlbGwg bWUgYWJvdXQgaXQgaW4gYSBwdWJsaWMgcmVwbHkuIFRoYXQncyBpbiBldmVyeW9uZSdzIGludGVy ZXN0LCBhcwp3aGF0IEkgd3JvdGUgYWJvdmUgbWlnaHQgYmUgbWlzbGVhZGluZyB0byBldmVyeW9u ZSByZWFkaW5nIHRoaXM7IGFueQpzdWdnZXN0aW9uIEkgZ2F2ZSB0aGV5IHRodXMgbWlnaHQgc2Vu dCBzb21lb25lIHJlYWRpbmcgdGhpcyBkb3duIHRoZQp3cm9uZyByYWJiaXQgaG9sZSwgd2hpY2gg bm9uZSBvZiB1cyB3YW50cy4KCkJUVywgSSBoYXZlIG5vIHBlcnNvbmFsIGludGVyZXN0IGluIHRo aXMgaXNzdWUsIHdoaWNoIGlzIHRyYWNrZWQgdXNpbmcKcmVnemJvdCwgbXkgTGludXgga2VybmVs IHJlZ3Jlc3Npb24gdHJhY2tpbmcgYm90CihodHRwczovL2xpbnV4LXJlZ3RyYWNraW5nLmxlZW1o dWlzLmluZm8vcmVnemJvdC8pLiBJJ20gb25seSBwb3N0aW5nCnRoaXMgbWFpbCB0byBnZXQgdGhp bmdzIHJvbGxpbmcgYWdhaW4gYW5kIGhlbmNlIGRvbid0IG5lZWQgdG8gYmUgQ0Mgb24KYWxsIGZ1 cnRoZXIgYWN0aXZpdGllcyB3cnQgdG8gdGhpcyByZWdyZXNzaW9uLgoKI3JlZ3pib3QgXmJhY2tt b25pdG9yOgpodHRwczovL2xvcmUua2VybmVsLm9yZy9yZWdyZXNzaW9ucy84NzFyNXAweDJ1LmZz ZkBjb2RlYXVyb3JhLm9yZy8KCi0tIAphdGgxMWsgbWFpbGluZyBsaXN0CmF0aDExa0BsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v YXRoMTFrCg==