From: David Ahern <dsahern@gmail.com>
To: zhang kai <zhangkaiheb@126.com>,
davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
kuba@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6:delete duplicate code for reserved iid check
Date: Tue, 2 Mar 2021 20:16:45 -0700 [thread overview]
Message-ID: <2a24a05b-be2e-afb0-1389-3cd612ed7b52@gmail.com> (raw)
In-Reply-To: <20210303005321.29821-1-zhangkaiheb@126.com>
On 3/2/21 5:53 PM, zhang kai wrote:
> Using the ipv6_reserved_interfaceid for interface id checking.
>
> Signed-off-by: zhang kai <zhangkaiheb@126.com>
> ---
> net/ipv6/addrconf.c | 45 +++++++++++++++++++--------------------------
> 1 file changed, 19 insertions(+), 26 deletions(-)
>
Looks equivalent to me. Code wise:
Reviewed-by: David Ahern <dsahern@kernel.org>
The commit message needs more words about the change.
prev parent reply other threads:[~2021-03-03 4:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 0:53 [PATCH] ipv6:delete duplicate code for reserved iid check zhang kai
2021-03-03 3:16 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a24a05b-be2e-afb0-1389-3cd612ed7b52@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
--cc=zhangkaiheb@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.