From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Július Milan" <jmilan.dev@gmail.com>, dev@dpdk.org, jgrajcia@cisco.com
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/memif: enable loopback
Date: Mon, 9 Mar 2020 11:23:39 +0000 [thread overview]
Message-ID: <2a40743e-350e-493f-ca92-332eab1d9bcc@intel.com> (raw)
In-Reply-To: <20200309104659.GA17684@vbox>
On 3/9/2020 10:46 AM, Július Milan wrote:
> With this patch it is possible to connect 2 DPDK memifs into loopback,
> i.e. when they have the same id and different roles, as for example:
> "--vdev=net_memif0,role=master,id=0"
> "--vdev=net_memif1,role=slave,id=0"
>
> Signed-off-by: Július Milan <jmilan.dev@gmail.com>
<...>
> @@ -642,8 +645,12 @@ memif_msg_receive(struct memif_control_channel *cc)
>
> size = recvmsg(cc->intr_handle.fd, &mh, 0);
> if (size != sizeof(memif_msg_t)) {
> - MIF_LOG(DEBUG, "Invalid message size.");
> - memif_msg_enq_disconnect(cc, "Invalid message size", 0);
> + MIF_LOG(DEBUG, "Invalid message size = %zu", size);
I can see format specifier is the only diff in v2 [1], but since 'size' can be
negative (ssize_t size), shouldn't it be '%zd'?
[1]
It is good to put a changelog into the commit log, after '---' below the
sign-off, to document what has been changed in versions.
prev parent reply other threads:[~2020-03-09 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 10:46 [dpdk-dev] [PATCH v2 1/2] net/memif: enable loopback Július Milan
2020-03-09 11:23 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a40743e-350e-493f-ca92-332eab1d9bcc@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
--cc=jmilan.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.