From: Jie Deng <Jie.Deng1@synopsys.com>
To: David Miller <davem@davemloft.net>, <Jie.Deng1@synopsys.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: dwc-xlgmac: add the initial ethtool support
Date: Wed, 12 Apr 2017 13:08:08 +0800 [thread overview]
Message-ID: <2a437683-a422-4db0-8583-7b002e74e71d@synopsys.com> (raw)
In-Reply-To: <20170411.104749.1916353709565387637.davem@davemloft.net>
On 2017/4/11 22:47, David Miller wrote:
> From: Jie Deng <Jie.Deng1@synopsys.com>
> Date: Tue, 11 Apr 2017 16:14:04 +0800
>
>> It is necessary to provide ethtool support for displaying and
>> modifying parameters of dwc-xlgmac.
>>
>> Signed-off-by: Jie Deng <jiedeng@synopsys.com>
> I don't see why you cannot allow the statistics to be obtained when
> the device is not running. Similarly for other ethtool calls that
> just fetch information stored in the software state of the driver.
>
> I think your ->begin() method is way too restrictive.
Yeah, begin() seems unreasonable here. I will remove it.
prev parent reply other threads:[~2017-04-12 5:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 8:14 [PATCH net-next] net: dwc-xlgmac: add the initial ethtool support Jie Deng
2017-04-11 14:47 ` David Miller
2017-04-12 5:08 ` Jie Deng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a437683-a422-4db0-8583-7b002e74e71d@synopsys.com \
--to=jie.deng1@synopsys.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.