From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7684C433EF for ; Mon, 20 Jun 2022 06:48:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C1101843AD; Mon, 20 Jun 2022 08:48:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.b="LcvCPLNl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1CB2C843E2; Mon, 20 Jun 2022 08:48:13 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0609.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0c::609]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0742883879 for ; Mon, 20 Jun 2022 08:48:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=stefan.herbrechtsmeier-oss@weidmueller.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hyYDa+KQxNiNwHjVZMkn8+5F5vemEIIvYHKsgFeZBqDMk8VJwLwo0PWr+Co1f4S1W5h2pCAEkKAtCTwK8oLvBjgdZ2+bobATVCadF3De4YIWsUxfkONwa1ZxfuIqNATPiOdAe2OwEpPgfwlFOwecxQzdRBcFdxry8U3F2CPtISbQ0HQNQilg1QVbAlm7++m5r4pzcExrgESN/aZcKp8wRqaBdQJ2ExTOoWJkkHv3payWa7etW2pNJIgDqBp8cGET7PimfcQ0L3pCIwry1mYzDTKx1tRPHxIZNIMrtnilr0sjh764BpiUvwlrmEHfHKn2fJKXJtz6qRrDf6LbiMLEqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CyTy+21tAgUzMwS0NObIXrHLHLGCXQRRmY2TkVQav2U=; b=fqc4B58wVsP6Br6aSQqp8blpkAK0sLAUgqcvO7JNQ2C4xbi5B7zzzrWHdb6i2/ZTxQTX/1YFPLaQhaTHDK6Y+xKDQniWctRj9Bd9HGXx7rlQRVaKsyy4xDAdUg3WCesXTuMDvxucdTFwtm4hoVNvW+Dhih4bafReXRJb9J1j63GklAb5TjF+pkHKisbOqOBnHcBnbcsRiGKTDwHaxv8pP0xXCsOunb0iT/05wacjP4TXV+u+aPM06ePcQRo8Nb6TaDR2npOG61OlvWsP2k19qeacTMc5XKQOMof1UoDV0s2l9l7sh8hj0i+gWMRWK23UDgzERBmNVUr8VbDvhXztDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.onmicrosoft.com; s=selector1-weidmueller-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CyTy+21tAgUzMwS0NObIXrHLHLGCXQRRmY2TkVQav2U=; b=LcvCPLNlO0UPyogh2VBXUZRUDgI+iH06OQqzfp4U/LQOLNIqVRsN3ksTMlnwrx2T08bZ6Sv7JWEaCyWk88REOaSlhGK/grMPIOonRPQ7SBATcFw5fN92WRkNs1B9/IYdiBBI7h7Pr1TwSRdjzvq78UzGu/W/L4FKLkF+kueJB+0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) by AM9PR08MB6228.eurprd08.prod.outlook.com (2603:10a6:20b:281::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Mon, 20 Jun 2022 06:48:09 +0000 Received: from PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::49a6:e5ff:7f94:8787]) by PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::49a6:e5ff:7f94:8787%7]) with mapi id 15.20.5353.022; Mon, 20 Jun 2022 06:48:09 +0000 Message-ID: <2a4a01ae-4828-2187-91fb-aa165000567d@weidmueller.com> Date: Mon, 20 Jun 2022 08:48:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 10/10] xilinx: zynqmp: Support vendor specific board_init Content-Language: en-US To: Michal Simek , u-boot@lists.denx.de Cc: Stefan Herbrechtsmeier References: <20220608162054.25641-1-stefan.herbrechtsmeier-oss@weidmueller.com> <20220608162054.25641-11-stefan.herbrechtsmeier-oss@weidmueller.com> From: Stefan Herbrechtsmeier In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0044.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::7) To PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8716c7a8-7ff2-4e60-1d4f-08da5288d661 X-MS-TrafficTypeDiagnostic: AM9PR08MB6228:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DXVRkcNZGN/luCmMU0h9x34+jE1oJAX5R6i8HMq7zYsK6ps84FySGrW3HsK5JM29EXylWTDufQ9OxvAlat51OJo1UeaSiZ/B60pJm94JCUE/WfBHKtJeNAYFCg4Yo3CkyVA/me5gPoLjF+la75tAFgLrpxxL4jZOLRVLI3U3gKYXSx+T39xddBVI0NFkBSV3qoilQI9fXcHYSgdpUTdJMRDniDOmUg0OGX2dH7TJeDa6/ld9I1e4XKE8HN+ffrnWHu0yo5vKdOzGFVFz6L5t9DGE20f1r8rG5gm0IeRFRzU0w0cHn4zh6OtuggvXFqrNS5iED8Wu8qnc7PJpRzdqH9DWuycLCOOgGRg47h7/TSmr5UUrVY8FJuPLTOnAU2S7q3P60XNuslgAjmDsjiuQJDVhc/rp7e35axqBNN8AGH1eTz7XL8uGIBHz022SGeFPvGJFQRKRH5tFerZP/2tSwFSDotPtisV6TD1qGO63G3MfI+yNIa/DcdOkhZPNoP8KJpUcRwmHadopovdUPFaJ6hWiButdIvpMHmAmRxSy/N/7SAMyxXhBOfOYiploB2+M4t9cX+l2JCi8/YL1zx013rNkmKO9dWKsTRgICFMyCFhIag2QSNKAtLt8SKQ3HusrTPnus1OFAq4dopNOJr8j3OtZv87EMWOyavN6BAVp1aYbvcHCmzRv8KTVVL9Peqo4BxtYH7It03L3WQpCSvQYiMhA+1oSr51rDEcXLdGFpEgOpLFbm1NC3BssO2A4cQfqS6IK+/bZ2svVj0zjEtIA9A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB6969.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(396003)(376002)(346002)(366004)(39860400002)(186003)(83380400001)(38350700002)(6666004)(38100700002)(6506007)(66946007)(26005)(6512007)(52116002)(53546011)(316002)(6486002)(478600001)(2906002)(2616005)(41300700001)(107886003)(66556008)(66476007)(8676002)(8936002)(5660300002)(4326008)(36756003)(31686004)(86362001)(31696002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWsrK090amFTdTJJd0w1dGtCQ1RuVkRnVmEyMzlnWnpLK2RYanhRemtHRThl?= =?utf-8?B?T2pkVjNCcGtCdGlYSGsvQjBLL1BHNWl0Z2xXdUd1Y29OOU84R1NrMzh0WW9F?= =?utf-8?B?dS8xeXlMWmdNN1hFVzNNRiszYmVjTjRLZkFkUmI2b3dmK3J6bUZ6TTdDR2po?= =?utf-8?B?eVdycC9iNlg2OXRjSHNsb1d2cDhGTllDV0k5V3JHMzJHaU9wUEtqQm5VVEEz?= =?utf-8?B?UW1TT2xvMDkvZXRzZWRVckxmV05CR3J5d2JWVWtDbHFNL1Zyb0V1cWlQSFBZ?= =?utf-8?B?dEJKWEZDbzFqQjhXR0tTQklZYVJjK2ZtYXk5Yng5cGhaNkREUm0ySjg2TkR3?= =?utf-8?B?RXQ5WEZOYWcxZzQ3RUxHRmlkRzFLR3dZYkRieFBXbmp3R0tLNFdlQTg5Y2Ni?= =?utf-8?B?ZWQydkc1ZkZnTE41SEttaG9yQU1Kd3B1V3RrQlAzS1hScG15QXBFMlVac0E5?= =?utf-8?B?YU9VY0xtaVMydUtCY05JY0xteXVUMGY1eGtHa3pBMzdjRzJ3d0RyaG9wY2pM?= =?utf-8?B?KzdWdzVTYXpqNFM1dHptMlBhbEZ6b0c5TzhMdnFHOVhUZkpocFUvd1RaZTd2?= =?utf-8?B?NVA3cytzUGJONGZZck8vVDNLeEJ4YTJpbG5MZFREY2ViMVZ3YXFDQi84Kzl1?= =?utf-8?B?YlZjNkU0ZTM4R1dRaEYvTytnYjNGQXZBa2J3dFJQTHB1RmZJVU1HbjRMMHli?= =?utf-8?B?U1EzRExMQ0RRWmxIRW9EM2d6aW8rNnhFTzZJV214cjVkZzI5TkZwbTZtOTZP?= =?utf-8?B?aVNHUjhWS0Zza3RDeWZjRVM1YmpScm1GWkQzemJwb3hvZm5rTWphdkt3N1Fl?= =?utf-8?B?aUJYK2NMZEp0OUo4R1hneTZsbkFObkNaN3lvZHhoUE1WeUlxV0ZWempOTE9k?= =?utf-8?B?cEJzSmZmaDJBcXRQYU5PS3ZwV09mS2xURm5mL0ZuT0lsU2RkRHdYNzJGWlVu?= =?utf-8?B?c2VibTl6RGZDWjkza25lV2xaUFVPdmMvYWEyRTM5ZGNza0JmUCtzQkllUUsx?= =?utf-8?B?VDVFRU9SMEgvWGU5Y3pJMXlPd2h4TkdrTXEvajFndHQ2UEc1cGc2Y1hZbFJZ?= =?utf-8?B?c2dKRlZSRVBBeXFUOW14YzYvaWRpUDFjd1c3aytwMmNnYldTY1ExYmx4ZTc2?= =?utf-8?B?L3l6d1NhLzJVVHZUd2l3Q1k0ZHhpcURVQk8ydFcwOXdycWtYZXM1RmlzdFpy?= =?utf-8?B?L2tXZXlMdDlWWG1VOEdmTkkvNDh0bmtEcWVUWWJuQlk0Wjc4S0psODY4M0FB?= =?utf-8?B?VVdqUmthZHpKZkNQNVpyaDZiOUdPMW1Ed3NqY2h1VFlzWGs2bXk4WnU4U1NG?= =?utf-8?B?QUhvSnlXRElQTjhvWnVWdlJyMDZTdzkwN0h1SDJBNWJtSEVmbGpLNHROdmpw?= =?utf-8?B?QkhhVi9DVFNsV1hmWHlGT1Evb3Q2MkVGWVRWSTVQOUg5YW16bEhQbmdJaXht?= =?utf-8?B?V2g0VG5TaWx3Ujh4bWNMMnRHVHh0M0FZUWhFUWFnNXBBbE5BVE8zdUNncXNw?= =?utf-8?B?V3JrQUJabDZVTU1SZEFKQlE4LzNRZUhBWWVkVStUZ1p6MUNWR25yM3ExUUps?= =?utf-8?B?U1Z0VG1laVNiOWl4bGRFWGN4U04zWEt1RlRpa1d5VnBad09SK3g3bnY1enZ2?= =?utf-8?B?L0RlT3RQUjJVRkxSQ0t2bkhsYmlMT0tsSDdPWWNza0tzN3F0aG9kSEdxQTdz?= =?utf-8?B?Mis1dFQ4aUZFNTNOUHFaWTFrTXk0aU9TY3VCZ2RRZXcrVGViOURXTkh3U0dr?= =?utf-8?B?VDhuV0Jid1hLb1Y5bys2QzdKZVV1UjZTNGV2ZmpzQlRnaWo0MDVPUDMwYVF6?= =?utf-8?B?SzEzR29xaGhiQXl2YlBaSUk3TVlUdjd1MnZwRTBuc1JBRUcxanJFeG5SU3Iz?= =?utf-8?B?ZmFXMWMzYTVGMjNLVGxLMDB3R0U1V1VHMGF0Z29tUU1qVUE3R0pKZUlxYWZ5?= =?utf-8?B?QWZYeUVpRGZwOGMvanRUYXUwVzJYWGErTE5PcGVRRmhrczhWWk8rMEY5ZlQv?= =?utf-8?B?cTg1emRoODl3eUZuSGZzMGx4ZWJKV09ZaHVMS0Z4K2xIYVhockRvdFVhSmQx?= =?utf-8?B?VldIVlNPbEEzdXRXZkhZTHBaUzU4TldyUW4xRHQrRFZlOURSdlZJWlMzeFdy?= =?utf-8?B?cUZIWnA3ZVRLcldUSGtiMEpTWGpJZlFaSEJxSkdjMWJwZDArS1U0MkNQZXFa?= =?utf-8?B?NUtHdDMwNXFqYmRKb2dPZXNUTFcraHZ4VkpoYkZnaTJmUlo5dTBuazlBWkJi?= =?utf-8?B?Rm5uTkxBams0UjBtS2syd1QzUXVoMWtjekhoT0x1QkpuZlhFTHE1Ty9MK05Z?= =?utf-8?B?V2F5WktiNEplTVNNUlcyakNOaDlOTmplOFNOOVJFYjVxaDFEek84aVhnckNH?= =?utf-8?Q?ffBmXUDvkqotUP70=3D?= X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8716c7a8-7ff2-4e60-1d4f-08da5288d661 X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6969.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 06:48:09.2846 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 72uLIMR2wnAHrgO92yKll5QZke8fKtglXctyTqPFbcAatc3jPaw6cBbq0JZIzBSNtXISWVua9BXAAw54bjmE4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6228 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Am 16.06.2022 um 17:12 schrieb Michal Simek: > > > On 6/8/22 18:20, Stefan Herbrechtsmeier wrote: >> [CAUTION: External Email] >> >> From: Stefan Herbrechtsmeier >> >> Add a board_init_xilinx function to allow foreign vendors to reuse the >> xilinx zynqmp board code and add addition code to the board_init >> function. > > Do you plan to add support for that board who will be using it? Yes. You could drop the patch for now but it will be good to know if this is the right direction to reuse common code from the xilinx board files. >> Signed-off-by: Stefan Herbrechtsmeier >> >> >> --- >> >>   board/xilinx/common/board.c  | 5 +++++ >>   board/xilinx/common/board.h  | 2 ++ >>   board/xilinx/zynqmp/zynqmp.c | 2 +- >>   3 files changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/board/xilinx/common/board.c b/board/xilinx/common/board.c >> index 5f2afb9def..643959bee7 100644 >> --- a/board/xilinx/common/board.c >> +++ b/board/xilinx/common/board.c >> @@ -401,6 +401,11 @@ void *board_fdt_blob_setup(int *err) >>   } >>   #endif >> >> +int board_init_xilinx(void) >> +{ >> +       return 0; >> +} > > This file is used by zynq/zynqmp/versal platforms. I expect there is > going to be any message that this function is unused on zynq and versal. You are right. Should we add it to all platforms? Is this the correct direction or should we split board/xilinx/zynqmp/zynqmp.c into common soc and specific board code? Regards Stefan