On 2/13/2017 6:03 PM, Chris Wilson wrote: > On Mon, Feb 13, 2017 at 02:25:29PM +0200, Joonas Lahtinen wrote: >> On ma, 2017-02-13 at 11:02 +0000, Chris Wilson wrote: >>> On Mon, Feb 13, 2017 at 12:58:57PM +0200, Joonas Lahtinen wrote: >>>> On ma, 2017-02-13 at 12:14 +0530, Sagar Arun Kamble wrote: >>>>> From: "sagar.a.kamble@intel.com" >>>>> >>>>> With prefaulting extended to support >=2GB, i915 can handle >>>>> relocation objects >=2GB. type conversion of length from int to >>>>> unsigned long in access_ok was making the validation bail out with >>>>> -EFAULT. >>>>> >>>>> Testcase: igt/gem_exec_reloc/wc-31 >>>>> Cc: Daniel Vetter >>>>> Cc: Chris Wilson >>>>> Signed-off-by: Sagar Arun Kamble >>>> With the correct "From:" and with "size_t" as type, this is; >>>> >>>> Reviewed-by: Joonas Lahtinen >>> My earlier comments still apply in that this is not how I fixed this >>> years ago, and I still much prefer my fix. >> Where are the earlier comments? I must have missed them. > I replied to the first time this patch landed in my inbox, which might > have been trybotted. > -Chris Chris, I thought those comments were about relocs_total and relocs_max values. Pasting below inputs from trybot. ------------ The abi is limited to 32b max relocs. Please see https://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=prescheduler&id=bcf3bca07f21a4c0c754ccecca81228c28437906 (a patch that is years overdue) in which this just evaporates. -Chris ---------