From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH libnvme] fabrics: restore hostname traddr support
Date: Mon, 27 Sep 2021 19:39:53 +0000 [thread overview]
Message-ID: <2a5ebd60-0367-6f76-67a4-d5af0a33e464@nvidia.com> (raw)
In-Reply-To: <20210926182932.55896-1-sagi@grimberg.me>
> +static int hostname2traddr(nvme_ctrl_t c)
> +{
> + struct addrinfo *host_info, hints = {.ai_family = AF_UNSPEC};
> + char addrstr[NVMF_TRADDR_SIZE];
do we need to setup the addrstr to 0 with = { 0 }; ?
> + const char *p;
> + int ret;
With that comment looks good to me.
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-09-27 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 18:29 [PATCH libnvme] fabrics: restore hostname traddr support Sagi Grimberg
2021-09-27 19:39 ` Chaitanya Kulkarni [this message]
2021-09-27 20:22 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a5ebd60-0367-6f76-67a4-d5af0a33e464@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.