All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Fuzzey <mfuzzey@parkeon.com>
To: Szymon Janc <szymon.janc@codecoup.pl>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [BlueZ PATCH 3/3] android: Enable multiadvertising
Date: Fri, 13 Oct 2017 15:32:36 +0200	[thread overview]
Message-ID: <2a7044d5-2697-8a23-dae0-965fcf6978a6@parkeon.com> (raw)
In-Reply-To: <2331907.AZjV3pQv3C@ix>

On 11/10/17 09:33, Szymon Janc wrote:

Hi Szymon,

thanks for the review.

>
>> +	switch(adv->type) {
>> +	case ANDROID_ADVERTISING_EVENT_TYPE_CONNECTABLE:
>> +		cp->flags |= MGMT_ADV_FLAG_CONNECTABLE;
>> +		break;
>> +
>> +	defualt:
>> +		break;
> This will not compile :)

Actually it *does* compile, in spite of  the typo in "defualt" (the 
compiler interprets it as a label)

Good catch though!

I then saw the rule in coding-style.txt about using all values of enums 
in switch statements (though it isn't enforced for Android builds)

So I'll do that for V2

All of your other remarks applied

Thanks,

Martin



  reply	other threads:[~2017-10-13 13:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10  9:27 [PATCH BlueZ 0/3] android: Add LE Peripheral role support Martin Fuzzey
2017-10-10  9:27 ` [BlueZ PATCH 1/3] android: Do not fail if empty keyset cannot be loaded Martin Fuzzey
2017-10-11  7:32   ` Szymon Janc
2017-10-10  9:27 ` [BlueZ PATCH 2/3] android: Get max advertising instances from kernel Martin Fuzzey
2017-10-10  9:27 ` [BlueZ PATCH 3/3] android: Enable multiadvertising Martin Fuzzey
2017-10-11  7:33   ` Szymon Janc
2017-10-13 13:32     ` Martin Fuzzey [this message]
2017-10-11 10:15   ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a7044d5-2697-8a23-dae0-965fcf6978a6@parkeon.com \
    --to=mfuzzey@parkeon.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=szymon.janc@codecoup.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.