All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fenglin Wu <quic_fenglinw@quicinc.com>
To: Rob Herring <robh@kernel.org>
Cc: <sboyd@kernel.org>,
	Subbaraman Narayanamurthy <quic_subbaram@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	Andy Gross <agross@kernel.org>, <collinsd@codeaurora.org>,
	Rob Herring <robh+dt@kernel.org>, <subbaram@codeaurora.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 10/10] dt-bindings: convert qcom,spmi-pmic-arb binding to YAML format
Date: Tue, 30 Nov 2021 08:06:37 +0800	[thread overview]
Message-ID: <2a735bf2-8f7a-b09f-1c9b-85d850b3a8c4@quicinc.com> (raw)
In-Reply-To: <1638199831.114024.123611.nullmailer@robh.at.kernel.org>


On 2021/11/29 23:30, Rob Herring wrote:
> On Mon, 29 Nov 2021 16:22:17 +0800, Fenglin Wu wrote:
>> Convert the SPMI PMIC arbiter documentation to JSON/yaml. While at it,
>> update SPMI bus "reg" items constraint for SPMI PMIC arbiter to carry
>> it and update it with a smaller range.
>>
>> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
>> ---
>>   .../bindings/spmi/qcom,spmi-pmic-arb.txt           |  67 -----------
>>   .../bindings/spmi/qcom,spmi-pmic-arb.yaml          | 128 +++++++++++++++++++++
>>   Documentation/devicetree/bindings/spmi/spmi.yaml   |   3 +-
>>   3 files changed, 130 insertions(+), 68 deletions(-)
>>   delete mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt
>>   create mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
>>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml:37:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> ./Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml:41:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
I will fix the indentation warning in next patch. I double checked this
at my side but it's curious that it didn't show up at my side even I have
installed yamllint and also upgraded dtschema to the latest.
> dtschema/dtc warnings/errors:
>
> doc reference errors (make refcheckdocs):
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt: Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt
>
> See https://patchwork.ozlabs.org/patch/1561055
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>

  reply	other threads:[~2021-11-30  0:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29  8:22 [PATCH v3 00/10] A bunch of fix and optimization patches in spmi-pmic-arb.c Fenglin Wu
2021-11-29  8:22 ` [PATCH v3 01/10] spmi: pmic-arb: handle spurious interrupt Fenglin Wu
2021-11-29  8:22 ` [PATCH v3 02/10] spmi: pmic-arb: do not ack and clear peripheral interrupts in cleanup_irq Fenglin Wu
2021-11-29  8:22 ` [PATCH v3 03/10] spmi: pmic-arb: check apid against limits before calling irq handler Fenglin Wu
2021-11-29  8:22 ` [PATCH v3 04/10] spmi: pmic-arb: add support to dispatch interrupt based on IRQ status Fenglin Wu
2021-11-29  8:22 ` [PATCH v3 05/10] spmi: pmic-arb: correct duplicate APID to PPID mapping logic Fenglin Wu
2021-11-29  8:22 ` [PATCH v3 06/10] spmi: pmic-arb: block access for invalid PMIC arbiter v5 SPMI writes Fenglin Wu
2021-11-29  8:22 ` [PATCH v3 07/10] bindings: spmi: spmi-pmic-arb: mark interrupt properties as optional Fenglin Wu
2021-11-29  8:22 ` [PATCH v3 08/10] spmi: pmic-arb: make interrupt support optional Fenglin Wu
2021-11-29  8:22 ` [PATCH v3 09/10] spmi: pmic-arb: increase SPMI transaction timeout delay Fenglin Wu
2021-11-29  8:22 ` [PATCH v3 10/10] dt-bindings: convert qcom,spmi-pmic-arb binding to YAML format Fenglin Wu
2021-11-29 15:30   ` Rob Herring
2021-11-30  0:06     ` Fenglin Wu [this message]
2021-12-01 20:53 ` [PATCH v3 00/10] A bunch of fix and optimization patches in spmi-pmic-arb.c Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a735bf2-8f7a-b09f-1c9b-85d850b3a8c4@quicinc.com \
    --to=quic_fenglinw@quicinc.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=collinsd@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_subbaram@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=subbaram@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.