From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v5 1/2] rpmsg: core: add API to get message length References: <1567005566-10986-1-git-send-email-arnaud.pouliquen@st.com> <1567005566-10986-2-git-send-email-arnaud.pouliquen@st.com> <7dc4d1cf-4f15-19ab-b8dd-424175f2a11a@ti.com> From: Suman Anna Message-ID: <2a81a04d-e4f9-b9c8-57ec-47f8e140235a@ti.com> Date: Tue, 3 Sep 2019 11:06:06 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit To: Arnaud Pouliquen , Ohad Ben-Cohen , Bjorn Andersson , Greg Kroah-Hartman , Jiri Slaby , xiang xiao , linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org Cc: Fabien DESSENNE , linux-stm32@st-md-mailman.stormreply.com, Alan Cox List-ID: Hi Arnaud, On 9/3/19 4:49 AM, Arnaud Pouliquen wrote: > hi Suman > > On 8/29/19 12:34 AM, Suman Anna wrote: >> Hi Arnaud, >> >> On 8/28/19 10:19 AM, Arnaud Pouliquen wrote: >>> Return the rpmsg buffer size for sending message, so rpmsg users >>> can split a long message in several sub rpmsg buffers. >> >> Thanks for the patch, I also have a need for the same to be able to >> compute permissible payload size. Minor comments below. > > Thanks for your review. i will update it ASAP. Then if you need it and > ack it, i suppose that we could request Bjorn to integrate it in a first > step, if the rpmsg tty driver has not a level of quality sufficient to > be accepted... Yeah, this patch can always be merged independently ahead of the rpmsg tty driver. Anyways, the tty patch will have to be picked up by a separate maintainer right. So, it would be nice to get the revised version get into 5.4 regards Suman > > Regards > Arnaud >> >>> >>> Signed-off-by: Arnaud Pouliquen >>> --- >>> V4 to V5 : >>>    - rename rpmsg_get_buf_payload_size to rpmsg_get_mtu >>> >>>   drivers/rpmsg/rpmsg_core.c       | 21 +++++++++++++++++++++ >>>   drivers/rpmsg/rpmsg_internal.h   |  2 ++ >>>   drivers/rpmsg/virtio_rpmsg_bus.c | 10 ++++++++++ >>>   include/linux/rpmsg.h            | 10 ++++++++++ >>>   4 files changed, 43 insertions(+) >>> >>> diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c >>> index 8122807db380..daca2e24fc71 100644 >>> --- a/drivers/rpmsg/rpmsg_core.c >>> +++ b/drivers/rpmsg/rpmsg_core.c >>> @@ -283,6 +283,27 @@ int rpmsg_trysend_offchannel(struct >>> rpmsg_endpoint *ept, u32 src, u32 dst, >>>   } >>>   EXPORT_SYMBOL(rpmsg_trysend_offchannel); >>>   +/** >>> + * rpmsg_get_mtu() - get maximum transmission buffer size for >>> sending message. >>> + * @ept: the rpmsg endpoint >>> + * >>> + * This function returns maximum buffer size available for a single >>> message. >>> + * >>> + * Return: the maximum transmission size on success and an >>> appropriate error >>> + * value on failure. >>> + */ >>> + >>> +ssize_t rpmsg_get_mtu(struct rpmsg_endpoint *ept) >>> +{ >>> +    if (WARN_ON(!ept)) >>> +        return -EINVAL; >>> +    if (!ept->ops->get_buf_mtu) >> >> How about calling the ops just get_mtu or rename the function to follow >> the ops name, like all the others. >> >>> +        return -ENXIO; >> >> Perhaps ENOTSUPP or EOPNOTSUPP. >> >>> + >>> +    return ept->ops->get_buf_mtu(ept); >>> +} >>> +EXPORT_SYMBOL(rpmsg_get_mtu); >>> + >>>   /* >>>    * match an rpmsg channel with a channel info struct. >>>    * this is used to make sure we're not creating rpmsg devices for >>> channels >>> diff --git a/drivers/rpmsg/rpmsg_internal.h >>> b/drivers/rpmsg/rpmsg_internal.h >>> index 0d791c30b7ea..645c402569ac 100644 >>> --- a/drivers/rpmsg/rpmsg_internal.h >>> +++ b/drivers/rpmsg/rpmsg_internal.h >>> @@ -46,6 +46,7 @@ struct rpmsg_device_ops { >>>    * @trysend:        see @rpmsg_trysend(), required >>>    * @trysendto:        see @rpmsg_trysendto(), optional >>>    * @trysend_offchannel:    see @rpmsg_trysend_offchannel(), optional >>> + * @get_buf_payload_size: see @rpmsg_get_buf_payload_size(), optional >> >> Missed updating the kerneldoc to the new name. >> >>>    * >>>    * Indirection table for the operations that a rpmsg backend should >>> implement. >>>    * In addition to @destroy_ept, the backend must at least implement >>> @send and >>> @@ -65,6 +66,7 @@ struct rpmsg_endpoint_ops { >>>                    void *data, int len); >>>       __poll_t (*poll)(struct rpmsg_endpoint *ept, struct file *filp, >>>                    poll_table *wait); >>> +    ssize_t (*get_buf_mtu)(struct rpmsg_endpoint *ept); >>>   }; >>>     int rpmsg_register_device(struct rpmsg_device *rpdev); >>> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c >>> b/drivers/rpmsg/virtio_rpmsg_bus.c >>> index e757f0038a1c..f80b1ad23e7e 100644 >>> --- a/drivers/rpmsg/virtio_rpmsg_bus.c >>> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c >>> @@ -178,6 +178,7 @@ static int virtio_rpmsg_trysendto(struct >>> rpmsg_endpoint *ept, void *data, >>>                     int len, u32 dst); >>>   static int virtio_rpmsg_trysend_offchannel(struct rpmsg_endpoint >>> *ept, u32 src, >>>                          u32 dst, void *data, int len); >>> +static ssize_t virtio_get_buf_mtu(struct rpmsg_endpoint *ept); >> >> Minor nit, virtio_rpmsg_ prefix similar to all the other ops. >> >> regards >> Suman >> >>>     static const struct rpmsg_endpoint_ops virtio_endpoint_ops = { >>>       .destroy_ept = virtio_rpmsg_destroy_ept, >>> @@ -187,6 +188,7 @@ static const struct rpmsg_endpoint_ops >>> virtio_endpoint_ops = { >>>       .trysend = virtio_rpmsg_trysend, >>>       .trysendto = virtio_rpmsg_trysendto, >>>       .trysend_offchannel = virtio_rpmsg_trysend_offchannel, >>> +    .get_buf_mtu = virtio_get_buf_mtu, >>>   }; >>>     /** >>> @@ -702,6 +704,14 @@ static int >>> virtio_rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, >>>       return rpmsg_send_offchannel_raw(rpdev, src, dst, data, len, >>> false); >>>   } >>>   +static ssize_t virtio_get_buf_mtu(struct rpmsg_endpoint *ept) >>> +{ >>> +    struct rpmsg_device *rpdev = ept->rpdev; >>> +    struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev); >>> + >>> +    return vch->vrp->buf_size - sizeof(struct rpmsg_hdr); >>> +} >>> + >>>   static int rpmsg_recv_single(struct virtproc_info *vrp, struct >>> device *dev, >>>                    struct rpmsg_hdr *msg, unsigned int len) >>>   { >>> diff --git a/include/linux/rpmsg.h b/include/linux/rpmsg.h >>> index 9fe156d1c018..9d638bf2bdce 100644 >>> --- a/include/linux/rpmsg.h >>> +++ b/include/linux/rpmsg.h >>> @@ -135,6 +135,8 @@ int rpmsg_trysend_offchannel(struct >>> rpmsg_endpoint *ept, u32 src, u32 dst, >>>   __poll_t rpmsg_poll(struct rpmsg_endpoint *ept, struct file *filp, >>>               poll_table *wait); >>>   +ssize_t rpmsg_get_mtu(struct rpmsg_endpoint *ept); >>> + >>>   #else >>>     static inline int register_rpmsg_device(struct rpmsg_device *dev) >>> @@ -242,6 +244,14 @@ static inline __poll_t rpmsg_poll(struct >>> rpmsg_endpoint *ept, >>>       return 0; >>>   } >>>   +static ssize_t rpmsg_get_mtu(struct rpmsg_endpoint *ept) >>> +{ >>> +    /* This shouldn't be possible */ >>> +    WARN_ON(1); >>> + >>> +    return -ENXIO; >>> +} >>> + >>>   #endif /* IS_ENABLED(CONFIG_RPMSG) */ >>>     /* use a macro to avoid include chaining to get THIS_MODULE */ >>> >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB29C3A5A2 for ; Tue, 3 Sep 2019 16:06:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B7F322CF8 for ; Tue, 3 Sep 2019 16:06:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="jQ4sr8CT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729983AbfICQGW (ORCPT ); Tue, 3 Sep 2019 12:06:22 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:54638 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728860AbfICQGW (ORCPT ); Tue, 3 Sep 2019 12:06:22 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x83G67jM000871; Tue, 3 Sep 2019 11:06:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1567526767; bh=dWCu0QuJUs0IyQ1/Rtl+NIOAzjgpEKr0XpQfGQC8zZM=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=jQ4sr8CTxM1RXZCVGZXpmteeIoCpype5fDVez/odaEeCxCW9YLJdPo7MuYb9B4EMM J9SoLMaiLeWcD9xTkhnaVBQ2pNBm3GuhxceRXdiA4WEN5fhhefBtQeICt89NkA1wAB uraq7RVXcPZyZuwfvL31l1G3vY+octRvo/lWfTGE= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x83G67xk019578 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 3 Sep 2019 11:06:07 -0500 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 3 Sep 2019 11:06:06 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 3 Sep 2019 11:06:06 -0500 Received: from [128.247.58.153] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x83G665J033317; Tue, 3 Sep 2019 11:06:06 -0500 Subject: Re: [PATCH v5 1/2] rpmsg: core: add API to get message length To: Arnaud Pouliquen , Ohad Ben-Cohen , Bjorn Andersson , Greg Kroah-Hartman , Jiri Slaby , xiang xiao , , CC: Fabien DESSENNE , , Alan Cox References: <1567005566-10986-1-git-send-email-arnaud.pouliquen@st.com> <1567005566-10986-2-git-send-email-arnaud.pouliquen@st.com> <7dc4d1cf-4f15-19ab-b8dd-424175f2a11a@ti.com> From: Suman Anna Message-ID: <2a81a04d-e4f9-b9c8-57ec-47f8e140235a@ti.com> Date: Tue, 3 Sep 2019 11:06:06 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaud, On 9/3/19 4:49 AM, Arnaud Pouliquen wrote: > hi Suman > > On 8/29/19 12:34 AM, Suman Anna wrote: >> Hi Arnaud, >> >> On 8/28/19 10:19 AM, Arnaud Pouliquen wrote: >>> Return the rpmsg buffer size for sending message, so rpmsg users >>> can split a long message in several sub rpmsg buffers. >> >> Thanks for the patch, I also have a need for the same to be able to >> compute permissible payload size. Minor comments below. > > Thanks for your review. i will update it ASAP. Then if you need it and > ack it, i suppose that we could request Bjorn to integrate it in a first > step, if the rpmsg tty driver has not a level of quality sufficient to > be accepted... Yeah, this patch can always be merged independently ahead of the rpmsg tty driver. Anyways, the tty patch will have to be picked up by a separate maintainer right. So, it would be nice to get the revised version get into 5.4 regards Suman > > Regards > Arnaud >> >>> >>> Signed-off-by: Arnaud Pouliquen >>> --- >>> V4 to V5 : >>>    - rename rpmsg_get_buf_payload_size to rpmsg_get_mtu >>> >>>   drivers/rpmsg/rpmsg_core.c       | 21 +++++++++++++++++++++ >>>   drivers/rpmsg/rpmsg_internal.h   |  2 ++ >>>   drivers/rpmsg/virtio_rpmsg_bus.c | 10 ++++++++++ >>>   include/linux/rpmsg.h            | 10 ++++++++++ >>>   4 files changed, 43 insertions(+) >>> >>> diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c >>> index 8122807db380..daca2e24fc71 100644 >>> --- a/drivers/rpmsg/rpmsg_core.c >>> +++ b/drivers/rpmsg/rpmsg_core.c >>> @@ -283,6 +283,27 @@ int rpmsg_trysend_offchannel(struct >>> rpmsg_endpoint *ept, u32 src, u32 dst, >>>   } >>>   EXPORT_SYMBOL(rpmsg_trysend_offchannel); >>>   +/** >>> + * rpmsg_get_mtu() - get maximum transmission buffer size for >>> sending message. >>> + * @ept: the rpmsg endpoint >>> + * >>> + * This function returns maximum buffer size available for a single >>> message. >>> + * >>> + * Return: the maximum transmission size on success and an >>> appropriate error >>> + * value on failure. >>> + */ >>> + >>> +ssize_t rpmsg_get_mtu(struct rpmsg_endpoint *ept) >>> +{ >>> +    if (WARN_ON(!ept)) >>> +        return -EINVAL; >>> +    if (!ept->ops->get_buf_mtu) >> >> How about calling the ops just get_mtu or rename the function to follow >> the ops name, like all the others. >> >>> +        return -ENXIO; >> >> Perhaps ENOTSUPP or EOPNOTSUPP. >> >>> + >>> +    return ept->ops->get_buf_mtu(ept); >>> +} >>> +EXPORT_SYMBOL(rpmsg_get_mtu); >>> + >>>   /* >>>    * match an rpmsg channel with a channel info struct. >>>    * this is used to make sure we're not creating rpmsg devices for >>> channels >>> diff --git a/drivers/rpmsg/rpmsg_internal.h >>> b/drivers/rpmsg/rpmsg_internal.h >>> index 0d791c30b7ea..645c402569ac 100644 >>> --- a/drivers/rpmsg/rpmsg_internal.h >>> +++ b/drivers/rpmsg/rpmsg_internal.h >>> @@ -46,6 +46,7 @@ struct rpmsg_device_ops { >>>    * @trysend:        see @rpmsg_trysend(), required >>>    * @trysendto:        see @rpmsg_trysendto(), optional >>>    * @trysend_offchannel:    see @rpmsg_trysend_offchannel(), optional >>> + * @get_buf_payload_size: see @rpmsg_get_buf_payload_size(), optional >> >> Missed updating the kerneldoc to the new name. >> >>>    * >>>    * Indirection table for the operations that a rpmsg backend should >>> implement. >>>    * In addition to @destroy_ept, the backend must at least implement >>> @send and >>> @@ -65,6 +66,7 @@ struct rpmsg_endpoint_ops { >>>                    void *data, int len); >>>       __poll_t (*poll)(struct rpmsg_endpoint *ept, struct file *filp, >>>                    poll_table *wait); >>> +    ssize_t (*get_buf_mtu)(struct rpmsg_endpoint *ept); >>>   }; >>>     int rpmsg_register_device(struct rpmsg_device *rpdev); >>> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c >>> b/drivers/rpmsg/virtio_rpmsg_bus.c >>> index e757f0038a1c..f80b1ad23e7e 100644 >>> --- a/drivers/rpmsg/virtio_rpmsg_bus.c >>> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c >>> @@ -178,6 +178,7 @@ static int virtio_rpmsg_trysendto(struct >>> rpmsg_endpoint *ept, void *data, >>>                     int len, u32 dst); >>>   static int virtio_rpmsg_trysend_offchannel(struct rpmsg_endpoint >>> *ept, u32 src, >>>                          u32 dst, void *data, int len); >>> +static ssize_t virtio_get_buf_mtu(struct rpmsg_endpoint *ept); >> >> Minor nit, virtio_rpmsg_ prefix similar to all the other ops. >> >> regards >> Suman >> >>>     static const struct rpmsg_endpoint_ops virtio_endpoint_ops = { >>>       .destroy_ept = virtio_rpmsg_destroy_ept, >>> @@ -187,6 +188,7 @@ static const struct rpmsg_endpoint_ops >>> virtio_endpoint_ops = { >>>       .trysend = virtio_rpmsg_trysend, >>>       .trysendto = virtio_rpmsg_trysendto, >>>       .trysend_offchannel = virtio_rpmsg_trysend_offchannel, >>> +    .get_buf_mtu = virtio_get_buf_mtu, >>>   }; >>>     /** >>> @@ -702,6 +704,14 @@ static int >>> virtio_rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, >>>       return rpmsg_send_offchannel_raw(rpdev, src, dst, data, len, >>> false); >>>   } >>>   +static ssize_t virtio_get_buf_mtu(struct rpmsg_endpoint *ept) >>> +{ >>> +    struct rpmsg_device *rpdev = ept->rpdev; >>> +    struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev); >>> + >>> +    return vch->vrp->buf_size - sizeof(struct rpmsg_hdr); >>> +} >>> + >>>   static int rpmsg_recv_single(struct virtproc_info *vrp, struct >>> device *dev, >>>                    struct rpmsg_hdr *msg, unsigned int len) >>>   { >>> diff --git a/include/linux/rpmsg.h b/include/linux/rpmsg.h >>> index 9fe156d1c018..9d638bf2bdce 100644 >>> --- a/include/linux/rpmsg.h >>> +++ b/include/linux/rpmsg.h >>> @@ -135,6 +135,8 @@ int rpmsg_trysend_offchannel(struct >>> rpmsg_endpoint *ept, u32 src, u32 dst, >>>   __poll_t rpmsg_poll(struct rpmsg_endpoint *ept, struct file *filp, >>>               poll_table *wait); >>>   +ssize_t rpmsg_get_mtu(struct rpmsg_endpoint *ept); >>> + >>>   #else >>>     static inline int register_rpmsg_device(struct rpmsg_device *dev) >>> @@ -242,6 +244,14 @@ static inline __poll_t rpmsg_poll(struct >>> rpmsg_endpoint *ept, >>>       return 0; >>>   } >>>   +static ssize_t rpmsg_get_mtu(struct rpmsg_endpoint *ept) >>> +{ >>> +    /* This shouldn't be possible */ >>> +    WARN_ON(1); >>> + >>> +    return -ENXIO; >>> +} >>> + >>>   #endif /* IS_ENABLED(CONFIG_RPMSG) */ >>>     /* use a macro to avoid include chaining to get THIS_MODULE */ >>> >>