From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 288A2C433EF for ; Fri, 8 Apr 2022 12:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235392AbiDHMQY (ORCPT ); Fri, 8 Apr 2022 08:16:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231381AbiDHMQV (ORCPT ); Fri, 8 Apr 2022 08:16:21 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3368914B000; Fri, 8 Apr 2022 05:14:15 -0700 (PDT) Received: from fraeml709-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4KZcXs0PFVz67cQ8; Fri, 8 Apr 2022 20:11:09 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml709-chm.china.huawei.com (10.206.15.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 8 Apr 2022 14:14:12 +0200 Received: from [10.47.91.39] (10.47.91.39) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 8 Apr 2022 13:14:11 +0100 Message-ID: <2a88a992-641a-b3ff-fe39-7a61fff87cb6@huawei.com> Date: Fri, 8 Apr 2022 13:14:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/4] scsi: core: constify pointer to scsi_host_template To: Krzysztof Kozlowski , "James E.J. Bottomley" , "Martin K. Petersen" , Alim Akhtar , "Avri Altman" , Doug Gilbert , , References: <20220408103027.311624-1-krzysztof.kozlowski@linaro.org> From: John Garry In-Reply-To: <20220408103027.311624-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.91.39] X-ClientProxiedBy: lhreml718-chm.china.huawei.com (10.201.108.69) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/04/2022 11:30, Krzysztof Kozlowski wrote: > Several pointers to 'struct scsi_host_template' do not modify it, so > made them const for safety. > Is this standard practice? What is so special here? Thanks, john > Signed-off-by: Krzysztof Kozlowski > --- > drivers/scsi/hosts.c | 2 +- > drivers/scsi/scsi_error.c | 17 +++++++++-------- > drivers/scsi/scsi_proc.c | 2 +- > drivers/scsi/scsi_sysfs.c | 6 +++--- > 4 files changed, 14 insertions(+), 13 deletions(-) > > diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c > index f69b77cbf538..65616a01761a 100644 > --- a/drivers/scsi/hosts.c > +++ b/drivers/scsi/hosts.c > @@ -209,7 +209,7 @@ EXPORT_SYMBOL(scsi_remove_host); > int scsi_add_host_with_dma(struct Scsi_Host *shost, struct device *dev, > struct device *dma_dev) > { > - struct scsi_host_template *sht = shost->hostt; > + const struct scsi_host_template *sht = shost->hostt; > int error = -EINVAL; > > shost_printk(KERN_INFO, shost, "%s\n", > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c