From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10A33C4332F for ; Tue, 4 Oct 2022 23:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229501AbiJDXu4 (ORCPT ); Tue, 4 Oct 2022 19:50:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbiJDXuz (ORCPT ); Tue, 4 Oct 2022 19:50:55 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8D443D599; Tue, 4 Oct 2022 16:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1664927454; x=1696463454; h=message-id:date:mime-version:from:subject:to:cc: references:in-reply-to:content-transfer-encoding; bh=8In7ktfTyv+rkvAJ1Ycb5/srhr0/wSuR4vknf0drpHs=; b=zRjTJg/GT3zipn9Cfj0PON7JdWWQZiCpCkyJi6CYTvfndN4kBBhMYZrC Ip7LSUfZqYy5+xLTDDA4OzbmxWiZZWwzLqJ5IsZBpnuhsl5D7ScnELsnG iDjBJHLKVTsp33uTT7zdSuMP89CnfmBD8Upq6OOavxMF5HUFh4JS6fE0R Y=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-02.qualcomm.com with ESMTP; 04 Oct 2022 16:50:54 -0700 X-QCInternal: smtphost Received: from nasanex01b.na.qualcomm.com ([10.46.141.250]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 16:50:52 -0700 Received: from [10.110.114.145] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 4 Oct 2022 16:50:52 -0700 Message-ID: <2a8c1752-818d-bf19-5a3a-095b969c5c5a@quicinc.com> Date: Tue, 4 Oct 2022 16:50:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 From: Elliot Berman Subject: Re: [PATCH v4 06/14] virt: gunyah: Add sysfs nodes To: Greg Kroah-Hartman CC: Bjorn Andersson , Murali Nalajala , Trilok Soni , "Srivatsa Vaddagiri" , Carl van Schaik , Andy Gross , Dmitry Baryshkov , Jassi Brar , , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , "Will Deacon" , Catalin Marinas , "Arnd Bergmann" , , , , References: <20220928195633.2348848-1-quic_eberman@quicinc.com> <20220928195633.2348848-7-quic_eberman@quicinc.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 9/30/2022 5:09 AM, Greg Kroah-Hartman wrote: > On Wed, Sep 28, 2022 at 12:56:25PM -0700, Elliot Berman wrote: >> Add /sys/hypervisor support when detecting that Linux is running in a >> Gunyah environment. Export the version of Gunyah which is reported via >> the hyp_identify hypercall. >> >> Signed-off-by: Elliot Berman >> --- >> .../ABI/testing/sysfs-hypervisor-gunyah | 15 ++++ >> MAINTAINERS | 1 + >> drivers/virt/Makefile | 1 + >> drivers/virt/gunyah/Makefile | 2 + >> drivers/virt/gunyah/sysfs.c | 71 +++++++++++++++++++ >> 5 files changed, 90 insertions(+) >> create mode 100644 Documentation/ABI/testing/sysfs-hypervisor-gunyah >> create mode 100644 drivers/virt/gunyah/Makefile >> create mode 100644 drivers/virt/gunyah/sysfs.c >> >> diff --git a/Documentation/ABI/testing/sysfs-hypervisor-gunyah b/Documentation/ABI/testing/sysfs-hypervisor-gunyah >> new file mode 100644 >> index 000000000000..7d74e74e9edd >> --- /dev/null >> +++ b/Documentation/ABI/testing/sysfs-hypervisor-gunyah >> @@ -0,0 +1,15 @@ >> +What: /sys/hypervisor/gunyah/api >> +Date: October 2022 >> +KernelVersion: 6.1 >> +Contact: linux-arm-msm@vger.kernel.org >> +Description: If running under Gunyah: >> + The Gunyah API version. > > What does this version mean? What format is it in? > The version is incremented on backwards-incompatible API changes. It's an integer: I've updated the description to mention it's an integer. FYI -- we are still currently at "1" and not aiming to increment this number. I'd like to get it reported in sysfs in case the version is incremented later. >> + >> +What: /sys/hypervisor/gunyah/variant >> +Date: October 2022 >> +KernelVersion: 6.1 >> +Contact: linux-arm-msm@vger.kernel.org >> +Description: If running under Gunyah: >> + Reports the build variant of Gunyah: >> + The open source build of Gunyah will report "81". >> + The Qualcomm build of Gunyah will report "72". > > So there are only 2 versions variants? What happens when you get a > third? And why the odd numbers? > The kernel isn't parsing the reported build variant and is passing the reported value up to the sysfs node. If a new third variant comes along, its build variant number would be reported. Would it be preferred to instead link to Gunyah's definitions for the build variant? > What will userspace do with this information and what tool will parse > it? > The usecase I'm envisioning is to help user check what build of Gunyah is present on the host. We don't have any intention to require userspace (or kernel) to behave differently whether they are on Qualcomm-built Gunyah or the open-source Gunyah. >> diff --git a/MAINTAINERS b/MAINTAINERS >> index feafac12db35..a26e67ef36b4 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -8885,6 +8885,7 @@ M: Elliot Berman >> M: Murali Nalajala >> L: linux-arm-msm@vger.kernel.org >> S: Supported >> +F: Documentation/ABI/testing/sysfs-hypervisor-gunyah >> F: Documentation/devicetree/bindings/firmware/gunyah-hypervisor.yaml >> F: Documentation/virt/gunyah/ >> F: arch/arm64/gunyah/ >> diff --git a/drivers/virt/Makefile b/drivers/virt/Makefile >> index 093674e05c40..10b87f934730 100644 >> --- a/drivers/virt/Makefile >> +++ b/drivers/virt/Makefile >> @@ -11,3 +11,4 @@ obj-$(CONFIG_NITRO_ENCLAVES) += nitro_enclaves/ >> obj-$(CONFIG_ACRN_HSM) += acrn/ >> obj-$(CONFIG_EFI_SECRET) += coco/efi_secret/ >> obj-$(CONFIG_SEV_GUEST) += coco/sev-guest/ >> +obj-$(CONFIG_GUNYAH) += gunyah/ >> diff --git a/drivers/virt/gunyah/Makefile b/drivers/virt/gunyah/Makefile >> new file mode 100644 >> index 000000000000..e15f16c17142 >> --- /dev/null >> +++ b/drivers/virt/gunyah/Makefile >> @@ -0,0 +1,2 @@ >> +gunyah-y += sysfs.o >> +obj-$(CONFIG_GUNYAH) += gunyah.o >> diff --git a/drivers/virt/gunyah/sysfs.c b/drivers/virt/gunyah/sysfs.c >> new file mode 100644 >> index 000000000000..ec11510cbece >> --- /dev/null >> +++ b/drivers/virt/gunyah/sysfs.c >> @@ -0,0 +1,71 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. >> + */ >> + >> +#define pr_fmt(fmt) "gunyah: " fmt >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +static struct gh_hypercall_hyp_identify_resp gunyah_api; >> + >> +static ssize_t api_show(struct kobject *kobj, struct kobj_attribute *attr, char *buffer) >> +{ >> + return sysfs_emit(buffer, "%d\n", (int)GH_API_INFO_API_VERSION(gunyah_api.api_info)); >> +} >> +static struct kobj_attribute api_attr = __ATTR_RO(api); >> + >> +static ssize_t variant_show(struct kobject *kobj, struct kobj_attribute *attr, char *buffer) >> +{ >> + return sysfs_emit(buffer, "%d\n", (int)GH_API_INFO_VARIANT(gunyah_api.api_info)); >> +} >> +static struct kobj_attribute variant_attr = __ATTR_RO(variant); >> + >> +static struct attribute *gunyah_attrs[] = { >> + &api_attr.attr, >> + &variant_attr.attr, >> + NULL >> +}; >> + >> +static const struct attribute_group gunyah_group = { >> + .name = "gunyah", >> + .attrs = gunyah_attrs, >> +}; >> + >> +static int __init gunyah_init(void) >> +{ >> + u32 uid[4]; >> + >> + gh_hypercall_get_uid(uid); > > No error checking? > The UID is filled by the first 4 return registers of the hypercall. If running under some other hypervisor or no hypervisor is present, then our expectation is that the relevant handler would fill some error value that isn't the UUID. KVM uses similar approach to allow guests to identify they are a KVM guest: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/smccc/kvm_guest.c?h=v6.0-rc7#n23 >> + >> + if (!(gh_uid_matches(GUNYAH, uid) || gh_uid_matches(QC_HYP, uid))) >> + return 0; >> + >> + gh_hypercall_hyp_identify(&gunyah_api); >> + >> + if (GH_API_INFO_API_VERSION(gunyah_api.api_info) != 1) { >> + pr_warn("Unrecognized gunyah version: %llu. Currently supported: 1\n", >> + GH_API_INFO_API_VERSION(gunyah_api.api_info)); > > Shouldn't the "1" be defined somewhere? > >> + return 0; >> + } >> + >> + pr_notice("Running under Gunyah hypervisor %llx/v%lld\n", >> + GH_API_INFO_VARIANT(gunyah_api.api_info), >> + GH_API_INFO_API_VERSION(gunyah_api.api_info)); > > When kernel code is working properly, it is quiet. What is this going > to be used for? > Xen and KVM guest drivers also report when they detect that they are running under a hypervisor. I'll drop this down to pr_info to match. > thanks, > > greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBAACC433FE for ; Tue, 4 Oct 2022 23:52:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:CC:To:Subject:From: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/n8nfRCTm3OlMTDM+9JNIoYr8fpz8HL/w9zko/AL1aM=; b=pqfyHzpnNMQmEj 4fA5eVPTjcQIN/ptfQMN5wTHCPrKogQhwkz1bS5lW8jZd9aVvsDLtbFg8sjuVMWYndv9dkQMk8ToX 3rHJjTyf1GyCQph05ia28ASgpCC084egGE8WuIP9wsgcmf9OFh64Sj9VzKu1yJ6G0j/+Kvh3e7NCN i7KHPwXtW1Dd5pBseh1ChcR8Yr0jF3H8/xA4iB80elx02w08PgiBY9gfHH5ANiFkv85mFItGEF3FL DDAbSUP84bkWcjCgRD2a5VUhQFHN+kgsDdz2KseF7SMPtHe+NsdJZRb99KXAQgc/ubGL83+h0IW9t 4nRhGn+LN+vujpFJML+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofrgj-00BZTX-8q; Tue, 04 Oct 2022 23:51:01 +0000 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofrgf-00BZSj-4p for linux-arm-kernel@lists.infradead.org; Tue, 04 Oct 2022 23:50:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1664927457; x=1696463457; h=message-id:date:mime-version:from:subject:to:cc: references:in-reply-to:content-transfer-encoding; bh=8In7ktfTyv+rkvAJ1Ycb5/srhr0/wSuR4vknf0drpHs=; b=hYW8B2yx92Ac+o3UiuJCg/l1V5M/OYp5/1tRozRoU7J310GuZSiE65o3 BAsRKP1WR3KjuD38mRzivWoXLv+lyeEmgliMxQQHuLmlRv5D2XMA9eegr h/ASuL+fgozxcmrxuKM3hBznXhlEhkHKXKmN5/nDcUrn9rBIfzT/TYsmq M=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-02.qualcomm.com with ESMTP; 04 Oct 2022 16:50:54 -0700 X-QCInternal: smtphost Received: from nasanex01b.na.qualcomm.com ([10.46.141.250]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 16:50:52 -0700 Received: from [10.110.114.145] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 4 Oct 2022 16:50:52 -0700 Message-ID: <2a8c1752-818d-bf19-5a3a-095b969c5c5a@quicinc.com> Date: Tue, 4 Oct 2022 16:50:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 From: Elliot Berman Subject: Re: [PATCH v4 06/14] virt: gunyah: Add sysfs nodes To: Greg Kroah-Hartman CC: Bjorn Andersson , Murali Nalajala , Trilok Soni , "Srivatsa Vaddagiri" , Carl van Schaik , Andy Gross , Dmitry Baryshkov , Jassi Brar , , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , "Will Deacon" , Catalin Marinas , "Arnd Bergmann" , , , , References: <20220928195633.2348848-1-quic_eberman@quicinc.com> <20220928195633.2348848-7-quic_eberman@quicinc.com> Content-Language: en-US In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221004_165057_248659_19D8F25D X-CRM114-Status: GOOD ( 30.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/30/2022 5:09 AM, Greg Kroah-Hartman wrote: > On Wed, Sep 28, 2022 at 12:56:25PM -0700, Elliot Berman wrote: >> Add /sys/hypervisor support when detecting that Linux is running in a >> Gunyah environment. Export the version of Gunyah which is reported via >> the hyp_identify hypercall. >> >> Signed-off-by: Elliot Berman >> --- >> .../ABI/testing/sysfs-hypervisor-gunyah | 15 ++++ >> MAINTAINERS | 1 + >> drivers/virt/Makefile | 1 + >> drivers/virt/gunyah/Makefile | 2 + >> drivers/virt/gunyah/sysfs.c | 71 +++++++++++++++++++ >> 5 files changed, 90 insertions(+) >> create mode 100644 Documentation/ABI/testing/sysfs-hypervisor-gunyah >> create mode 100644 drivers/virt/gunyah/Makefile >> create mode 100644 drivers/virt/gunyah/sysfs.c >> >> diff --git a/Documentation/ABI/testing/sysfs-hypervisor-gunyah b/Documentation/ABI/testing/sysfs-hypervisor-gunyah >> new file mode 100644 >> index 000000000000..7d74e74e9edd >> --- /dev/null >> +++ b/Documentation/ABI/testing/sysfs-hypervisor-gunyah >> @@ -0,0 +1,15 @@ >> +What: /sys/hypervisor/gunyah/api >> +Date: October 2022 >> +KernelVersion: 6.1 >> +Contact: linux-arm-msm@vger.kernel.org >> +Description: If running under Gunyah: >> + The Gunyah API version. > > What does this version mean? What format is it in? > The version is incremented on backwards-incompatible API changes. It's an integer: I've updated the description to mention it's an integer. FYI -- we are still currently at "1" and not aiming to increment this number. I'd like to get it reported in sysfs in case the version is incremented later. >> + >> +What: /sys/hypervisor/gunyah/variant >> +Date: October 2022 >> +KernelVersion: 6.1 >> +Contact: linux-arm-msm@vger.kernel.org >> +Description: If running under Gunyah: >> + Reports the build variant of Gunyah: >> + The open source build of Gunyah will report "81". >> + The Qualcomm build of Gunyah will report "72". > > So there are only 2 versions variants? What happens when you get a > third? And why the odd numbers? > The kernel isn't parsing the reported build variant and is passing the reported value up to the sysfs node. If a new third variant comes along, its build variant number would be reported. Would it be preferred to instead link to Gunyah's definitions for the build variant? > What will userspace do with this information and what tool will parse > it? > The usecase I'm envisioning is to help user check what build of Gunyah is present on the host. We don't have any intention to require userspace (or kernel) to behave differently whether they are on Qualcomm-built Gunyah or the open-source Gunyah. >> diff --git a/MAINTAINERS b/MAINTAINERS >> index feafac12db35..a26e67ef36b4 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -8885,6 +8885,7 @@ M: Elliot Berman >> M: Murali Nalajala >> L: linux-arm-msm@vger.kernel.org >> S: Supported >> +F: Documentation/ABI/testing/sysfs-hypervisor-gunyah >> F: Documentation/devicetree/bindings/firmware/gunyah-hypervisor.yaml >> F: Documentation/virt/gunyah/ >> F: arch/arm64/gunyah/ >> diff --git a/drivers/virt/Makefile b/drivers/virt/Makefile >> index 093674e05c40..10b87f934730 100644 >> --- a/drivers/virt/Makefile >> +++ b/drivers/virt/Makefile >> @@ -11,3 +11,4 @@ obj-$(CONFIG_NITRO_ENCLAVES) += nitro_enclaves/ >> obj-$(CONFIG_ACRN_HSM) += acrn/ >> obj-$(CONFIG_EFI_SECRET) += coco/efi_secret/ >> obj-$(CONFIG_SEV_GUEST) += coco/sev-guest/ >> +obj-$(CONFIG_GUNYAH) += gunyah/ >> diff --git a/drivers/virt/gunyah/Makefile b/drivers/virt/gunyah/Makefile >> new file mode 100644 >> index 000000000000..e15f16c17142 >> --- /dev/null >> +++ b/drivers/virt/gunyah/Makefile >> @@ -0,0 +1,2 @@ >> +gunyah-y += sysfs.o >> +obj-$(CONFIG_GUNYAH) += gunyah.o >> diff --git a/drivers/virt/gunyah/sysfs.c b/drivers/virt/gunyah/sysfs.c >> new file mode 100644 >> index 000000000000..ec11510cbece >> --- /dev/null >> +++ b/drivers/virt/gunyah/sysfs.c >> @@ -0,0 +1,71 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. >> + */ >> + >> +#define pr_fmt(fmt) "gunyah: " fmt >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +static struct gh_hypercall_hyp_identify_resp gunyah_api; >> + >> +static ssize_t api_show(struct kobject *kobj, struct kobj_attribute *attr, char *buffer) >> +{ >> + return sysfs_emit(buffer, "%d\n", (int)GH_API_INFO_API_VERSION(gunyah_api.api_info)); >> +} >> +static struct kobj_attribute api_attr = __ATTR_RO(api); >> + >> +static ssize_t variant_show(struct kobject *kobj, struct kobj_attribute *attr, char *buffer) >> +{ >> + return sysfs_emit(buffer, "%d\n", (int)GH_API_INFO_VARIANT(gunyah_api.api_info)); >> +} >> +static struct kobj_attribute variant_attr = __ATTR_RO(variant); >> + >> +static struct attribute *gunyah_attrs[] = { >> + &api_attr.attr, >> + &variant_attr.attr, >> + NULL >> +}; >> + >> +static const struct attribute_group gunyah_group = { >> + .name = "gunyah", >> + .attrs = gunyah_attrs, >> +}; >> + >> +static int __init gunyah_init(void) >> +{ >> + u32 uid[4]; >> + >> + gh_hypercall_get_uid(uid); > > No error checking? > The UID is filled by the first 4 return registers of the hypercall. If running under some other hypervisor or no hypervisor is present, then our expectation is that the relevant handler would fill some error value that isn't the UUID. KVM uses similar approach to allow guests to identify they are a KVM guest: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/smccc/kvm_guest.c?h=v6.0-rc7#n23 >> + >> + if (!(gh_uid_matches(GUNYAH, uid) || gh_uid_matches(QC_HYP, uid))) >> + return 0; >> + >> + gh_hypercall_hyp_identify(&gunyah_api); >> + >> + if (GH_API_INFO_API_VERSION(gunyah_api.api_info) != 1) { >> + pr_warn("Unrecognized gunyah version: %llu. Currently supported: 1\n", >> + GH_API_INFO_API_VERSION(gunyah_api.api_info)); > > Shouldn't the "1" be defined somewhere? > >> + return 0; >> + } >> + >> + pr_notice("Running under Gunyah hypervisor %llx/v%lld\n", >> + GH_API_INFO_VARIANT(gunyah_api.api_info), >> + GH_API_INFO_API_VERSION(gunyah_api.api_info)); > > When kernel code is working properly, it is quiet. What is this going > to be used for? > Xen and KVM guest drivers also report when they detect that they are running under a hypervisor. I'll drop this down to pr_info to match. > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel