From mboxrd@z Thu Jan 1 00:00:00 1970 From: Clinton Taylor Subject: Re: [PATCH v2 1/2] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Date: Tue, 2 Apr 2019 08:54:30 -0700 Message-ID: <2a8f9488-0b58-4461-0bde-67e1c0b66f81@intel.com> References: <20190402121440.20116-1-aditya.swarup@intel.com> <20190402125306.GP3888@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id BEB936E453 for ; Tue, 2 Apr 2019 16:54:02 +0000 (UTC) In-Reply-To: <20190402125306.GP3888@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Aditya Swarup Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDQvMi8xOSA1OjUzIEFNLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gT24gVHVlLCBBcHIg MDIsIDIwMTkgYXQgMDU6MTQ6MzlBTSAtMDcwMCwgQWRpdHlhIFN3YXJ1cCB3cm90ZToKPj4gRnJv bTogQ2xpbnRvbiBUYXlsb3IgPENsaW50b24uQS5UYXlsb3JAaW50ZWwuY29tPgo+Pgo+PiB2Mjog Rml4IGNvbW1pdCBtc2cgdG8gcmVmbGVjdCB3aHkgaXNzdWUgb2NjdXJzKEphbmkpCj4+IFNldCBH Q1BfQ09MT1JfSU5ESUNBVElPTiBvbmx5IHdoZW4gd2Ugc2V0IDEwLzEyIGJpdCBkZWVwIGNvbG9y Lgo+Pgo+PiBDaGFuZ2luZyBzZXR0aW5ncyBmcm9tIDEwLzEyIGJpdCBkZWVwIGNvbG9yIHRvIDgg Yml0KCYgdmljZSB2ZXJzYSkKPj4gZG9lc24ndCB3b3JrIGNvcnJlY3RseSB1c2luZyB4cmFuZHIg bWF4IGJwYyBwcm9wZXJ0eS4gV2hlbiB3ZQo+PiBjb25uZWN0IGEgbW9uaXRvciB3aGljaCBzdXBw b3J0cyBkZWVwIGNvbG9yLCB0aGUgaGlnaGVzdCBkZWVwIGNvbG9yCj4+IHNldHRpbmcgaXMgc2Vs ZWN0ZWQ7IHdoaWNoIHNldHMgR0NQX0NPTE9SX0lORElDQVRJT04uIFdoZW4gd2UgY2hhbmdlCj4+ IHRoZSBzZXR0aW5nIHRvIDggYml0IGNvbG9yLCB3ZSBzdGlsbCBzZXQgR0NQX0NPTE9SX0lORElD QVRJT04gd2hpY2gKPj4gZG9lc24ndCBhbGxvdyB0aGUgc3dpdGNoIGJhY2sgdG8gOCBiaXQgY29s b3IuCj4gV2h5IG5vdD8gVGFibGUgNi0xIGluIEhETUkgMS40YSBzcGVjIGNsZWFybHkgbGlzdHMg OGJwYyBhcyBhCj4gdmFsaWQgc2V0dGluZyBmb3IgR0NQLgoKVGhpcyBhcHBlYXJzIHRvIGJlIGEg dW5kb2N1bWVudGVkIFNJIGlzc3VlLiBBY2NvcmRpbmcgdG8gdGhlIHNwZWMgOCBiaXQgCmlzIGEg dmFsaWQgR0NQIHZhbHVlLiBIb3dldmVyLCBpZiB5b3UgZW5hYmxlIEdDUCBpbmRpY2F0aW9uIGFu ZCA4IGJpdCBpcyAKY3VycmVudCB0aGVuIDEwIGJpdCBpcyB0cmFuc21pdCB2aWEgR0NQIGNvbmZ1 c2luZyBtb25pdG9ycy4gVGhlIEdDUCBpcyAKYmVpbmcgdmFsaWRhdGVkIHVzaW5nIDIgZGlmZmVy ZW50IEhETUkgQW5hbHl6ZXIncyBjb25maXJtaW5nIHRoZSByZXN1bHRzLgoKV2Ugd2lsbCBmaWxl IGEgU0kgYnVnIGFnYWluc3QgdGhlIGN1cnJlbnQgYmVoYXZpb3IuCgotQ2xpbnQKCgo+Cj4+IFNp Z25lZC1vZmYtYnk6IENsaW50b24gVGF5bG9yIDxDbGludG9uLkEuVGF5bG9yQGludGVsLmNvbT4K Pj4gU2lnbmVkLW9mZi1ieTogQWRpdHlhIFN3YXJ1cCA8YWRpdHlhLnN3YXJ1cEBpbnRlbC5jb20+ Cj4+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ PiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPj4gQ2M6IE1hbmFzaSBO YXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2hkbWkuYyB8IDMxICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0t LS0KPj4gICAxIGZpbGUgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0p Cj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMKPj4gaW5kZXggNWNjYjMwNWE2ZTFjLi40 NzYwNDYyZjg0Y2EgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hk bWkuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMKPj4gQEAgLTk2 Myw3ICs5NjMsOSBAQCBzdGF0aWMgdm9pZCBpbnRlbF9oZG1pX2NvbXB1dGVfZ2NwX2luZm9mcmFt ZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPj4gICAJCWludGVsX2hkbWlfaW5mb2Zy YW1lX2VuYWJsZShIRE1JX1BBQ0tFVF9UWVBFX0dFTkVSQUxfQ09OVFJPTCk7Cj4+ICAgCj4+ICAg CS8qIEluZGljYXRlIGNvbG9yIGRlcHRoIHdoZW5ldmVyIHRoZSBzaW5rIHN1cHBvcnRzIGRlZXAg Y29sb3IgKi8KPj4gLQlpZiAoaGRtaV9zaW5rX2lzX2RlZXBfY29sb3IoY29ubl9zdGF0ZSkpCj4+ ICsKPj4gKwlpZiAoaGRtaV9zaW5rX2lzX2RlZXBfY29sb3IoY29ubl9zdGF0ZSkgJiYKPj4gKwkg ICAgKGNydGNfc3RhdGUtPnBpcGVfYnBwID4gMjQpKQo+PiAgIAkJY3J0Y19zdGF0ZS0+aW5mb2Zy YW1lcy5nY3AgfD0gR0NQX0NPTE9SX0lORElDQVRJT047Cj4+ICAgCj4+ICAgCS8qIEVuYWJsZSBk ZWZhdWx0X3BoYXNlIHdoZW5ldmVyIHRoZSBkaXNwbGF5IG1vZGUgaXMgc3VpdGFibHkgYWxpZ25l ZCAqLwo+PiBAQCAtMjI2MCw2ICsyMjYyLDcgQEAgaW50IGludGVsX2hkbWlfY29tcHV0ZV9jb25m aWcoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4+ICAgCWludCBjbG9ja184YnBjID0g cGlwZV9jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX2Nsb2NrOwo+PiAgIAlpbnQgY2xv Y2tfMTBicGMgPSBjbG9ja184YnBjICogNSAvIDQ7Cj4+ICAgCWludCBjbG9ja18xMmJwYyA9IGNs b2NrXzhicGMgKiAzIC8gMjsKPj4gKwlpbnQgZGNfY2xvY2sgPSBjbG9ja18xMmJwYzsKPj4gICAJ aW50IGRlc2lyZWRfYnBwOwo+PiAgIAlib29sIGZvcmNlX2R2aSA9IGludGVsX2Nvbm5fc3RhdGUt PmZvcmNlX2F1ZGlvID09IEhETUlfQVVESU9fT0ZGX0RWSTsKPj4gICAKPj4gQEAgLTIzMTQsMjIg KzIzMTcsMTggQEAgaW50IGludGVsX2hkbWlfY29tcHV0ZV9jb25maWcoc3RydWN0IGludGVsX2Vu Y29kZXIgKmVuY29kZXIsCj4+ICAgCSAqIE5vdGUgdGhhdCBnNHgvdmx2IGRvbid0IHN1cHBvcnQg MTJicGMgaGRtaSBvdXRwdXRzLiBXZSBhbHNvIG5lZWQKPj4gICAJICogdG8gY2hlY2sgdGhhdCB0 aGUgaGlnaGVyIGNsb2NrIHN0aWxsIGZpdHMgd2l0aGluIGxpbWl0cy4KPj4gICAJICovCj4+IC0J aWYgKGhkbWlfZGVlcF9jb2xvcl9wb3NzaWJsZShwaXBlX2NvbmZpZywgMTIpICYmCj4+IC0JICAg IGhkbWlfcG9ydF9jbG9ja192YWxpZChpbnRlbF9oZG1pLCBjbG9ja18xMmJwYywKPj4gKwlpZiAo cGlwZV9jb25maWctPnBpcGVfYnBwID09IDMwKQo+PiArCQlkY19jbG9jayA9IGNsb2NrXzEwYnBj Owo+PiArCj4+ICsJaWYgKGhkbWlfZGVlcF9jb2xvcl9wb3NzaWJsZShwaXBlX2NvbmZpZywgcGlw ZV9jb25maWctPnBpcGVfYnBwIC8gMykgJiYKPj4gKwkgICAgaGRtaV9wb3J0X2Nsb2NrX3ZhbGlk KGludGVsX2hkbWksIGRjX2Nsb2NrLAo+PiAgIAkJCQkgIHRydWUsIGZvcmNlX2R2aSkgPT0gTU9E RV9PSykgewo+PiAtCQlEUk1fREVCVUdfS01TKCJwaWNraW5nIGJwYyB0byAxMiBmb3IgSERNSSBv dXRwdXRcbiIpOwo+PiAtCQlkZXNpcmVkX2JwcCA9IDEyKjM7Cj4+IC0KPj4gLQkJLyogTmVlZCB0 byBhZGp1c3QgdGhlIHBvcnQgbGluayBieSAxLjV4IGZvciAxMmJwYy4gKi8KPj4gLQkJcGlwZV9j b25maWctPnBvcnRfY2xvY2sgPSBjbG9ja18xMmJwYzsKPj4gLQl9IGVsc2UgaWYgKGhkbWlfZGVl cF9jb2xvcl9wb3NzaWJsZShwaXBlX2NvbmZpZywgMTApICYmCj4+IC0JCSAgIGhkbWlfcG9ydF9j bG9ja192YWxpZChpbnRlbF9oZG1pLCBjbG9ja18xMGJwYywKPj4gLQkJCQkJIHRydWUsIGZvcmNl X2R2aSkgPT0gTU9ERV9PSykgewo+PiAtCQlEUk1fREVCVUdfS01TKCJwaWNraW5nIGJwYyB0byAx MCBmb3IgSERNSSBvdXRwdXRcbiIpOwo+PiAtCQlkZXNpcmVkX2JwcCA9IDEwICogMzsKPj4gLQo+ PiAtCQkvKiBOZWVkIHRvIGFkanVzdCB0aGUgcG9ydCBsaW5rIGJ5IDEuMjV4IGZvciAxMGJwYy4g Ki8KPj4gLQkJcGlwZV9jb25maWctPnBvcnRfY2xvY2sgPSBjbG9ja18xMGJwYzsKPj4gKwkJRFJN X0RFQlVHX0tNUygicGlja2luZyBicGMgdG8gJWQgZm9yIEhETUkgb3V0cHV0XG4iLAo+PiArCQkJ CSBwaXBlX2NvbmZpZy0+cGlwZV9icHAgLyAzKTsKPj4gKwkJZGVzaXJlZF9icHAgPSBwaXBlX2Nv bmZpZy0+cGlwZV9icHA7Cj4+ICsKPj4gKwkJLyogTmVlZCB0byBhZGp1c3QgdGhlIHBvcnQgbGlu ayBkYyBtb2Rlcy4gKi8KPj4gKwkJcGlwZV9jb25maWctPnBvcnRfY2xvY2sgPSBkY19jbG9jazsK PiBUaGlzIHBhcnQgaGFzIG5vdGhpbmcgdG8gZG8gd2l0aCB0aGUgY29tbWl0IG1lc3NhZ2UuCj4K Pgo+PiAgIAl9IGVsc2Ugewo+PiAgIAkJRFJNX0RFQlVHX0tNUygicGlja2luZyBicGMgdG8gOCBm b3IgSERNSSBvdXRwdXRcbiIpOwo+PiAgIAkJZGVzaXJlZF9icHAgPSA4KjM7Cj4+IC0tIAo+PiAy LjE3LjEKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4