From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6339FC433DF for ; Thu, 4 Jun 2020 09:25:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2BCA1206A2 for ; Thu, 4 Jun 2020 09:25:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727023AbgFDJZV (ORCPT ); Thu, 4 Jun 2020 05:25:21 -0400 Received: from smtprelay0206.hostedemail.com ([216.40.44.206]:50826 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726444AbgFDJZV (ORCPT ); Thu, 4 Jun 2020 05:25:21 -0400 X-Greylist: delayed 460 seconds by postgrey-1.27 at vger.kernel.org; Thu, 04 Jun 2020 05:25:20 EDT Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave08.hostedemail.com (Postfix) with ESMTP id E1D56182D351B for ; Thu, 4 Jun 2020 09:17:40 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 7FBE8837F27E; Thu, 4 Jun 2020 09:17:39 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: lock32_040a1d426d96 X-Filterd-Recvd-Size: 3759 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Thu, 4 Jun 2020 09:17:36 +0000 (UTC) Message-ID: <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken From: Joe Perches To: Dan Carpenter , Linus Walleij Cc: Christophe JAILLET , Robert Jarzmik , Daniel Mack , Haojian Zhuang , Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Date: Thu, 04 Jun 2020 02:17:35 -0700 In-Reply-To: <20200604083120.GF22511@kadam> References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> <20200601183102.GS30374@kadam> <20200604083120.GF22511@kadam> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, 2020-06-04 at 11:31 +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 12:08:49AM +0200, Linus Walleij wrote: [] > > Fixes means it fixes something that was wrong in that commit. > > That's all. Whether syntactic or semantic or regression or > > serious or not does not matter. It is also not compulsory to > > add it is just helpful. > > Fixes tag should be compulsory for actual bug fixes. We had a the > Bad Binder exploit last year because commit f5cb779ba163 > ("ANDROID: binder: remove waitqueue when thread exits.") had no Fixes > tag and wasn't backported to Android kernels. Fixes tags IMO should be exclusively for actual bug fixes and should be mandatory. Perhaps: --- Documentation/process/submitting-patches.rst | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst index 1699b7f8e63a..285a84ae79de 100644 --- a/Documentation/process/submitting-patches.rst +++ b/Documentation/process/submitting-patches.rst @@ -636,12 +636,14 @@ idea was not posted in a public forum. That said, if we diligently credit our idea reporters, they will, hopefully, be inspired to help us again in the future. -A Fixes: tag indicates that the patch fixes an issue in a previous commit. It -is used to make it easy to determine where a bug originated, which can help -review a bug fix. This tag also assists the stable kernel team in determining -which stable kernel versions should receive your fix. This is the preferred -method for indicating a bug fixed by the patch. See :ref:`describe_changes` -for more details. +A Fixes: tag indicates that the patch fixes a "bug". i.e.: a logic defect or +regression in a previous commit. A Fixes: tag should not be used to indicate +that a previous commit had some trivial defect in spelling in the commit log or +some whitespace defect. The Fixes: tag is used to make it easy to determine +where a bug originated, which can help review a bug fix. The Fixes: tag also +assists the stable kernel team in determining which stable kernel versions +should receive your fix. This is the preferred method for indicating a bug is +fixed by the patch. See :ref:`describe_changes` for more details. .. _the_canonical_patch_format: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Thu, 04 Jun 2020 09:17:35 +0000 Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Message-Id: <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> List-Id: References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> <20200601183102.GS30374@kadam> <20200604083120.GF22511@kadam> In-Reply-To: <20200604083120.GF22511@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Linus Walleij Cc: kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Christophe JAILLET , Daniel Mack , Robert Jarzmik , Linux ARM On Thu, 2020-06-04 at 11:31 +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 12:08:49AM +0200, Linus Walleij wrote: [] > > Fixes means it fixes something that was wrong in that commit. > > That's all. Whether syntactic or semantic or regression or > > serious or not does not matter. It is also not compulsory to > > add it is just helpful. > > Fixes tag should be compulsory for actual bug fixes. We had a the > Bad Binder exploit last year because commit f5cb779ba163 > ("ANDROID: binder: remove waitqueue when thread exits.") had no Fixes > tag and wasn't backported to Android kernels. Fixes tags IMO should be exclusively for actual bug fixes and should be mandatory. Perhaps: --- Documentation/process/submitting-patches.rst | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst index 1699b7f8e63a..285a84ae79de 100644 --- a/Documentation/process/submitting-patches.rst +++ b/Documentation/process/submitting-patches.rst @@ -636,12 +636,14 @@ idea was not posted in a public forum. That said, if we diligently credit our idea reporters, they will, hopefully, be inspired to help us again in the future. -A Fixes: tag indicates that the patch fixes an issue in a previous commit. It -is used to make it easy to determine where a bug originated, which can help -review a bug fix. This tag also assists the stable kernel team in determining -which stable kernel versions should receive your fix. This is the preferred -method for indicating a bug fixed by the patch. See :ref:`describe_changes` -for more details. +A Fixes: tag indicates that the patch fixes a "bug". i.e.: a logic defect or +regression in a previous commit. A Fixes: tag should not be used to indicate +that a previous commit had some trivial defect in spelling in the commit log or +some whitespace defect. The Fixes: tag is used to make it easy to determine +where a bug originated, which can help review a bug fix. The Fixes: tag also +assists the stable kernel team in determining which stable kernel versions +should receive your fix. This is the preferred method for indicating a bug is +fixed by the patch. See :ref:`describe_changes` for more details. .. _the_canonical_patch_format: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED6C7C433DF for ; Thu, 4 Jun 2020 09:17:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1FE52065C for ; Thu, 4 Jun 2020 09:17:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iSwcfhpZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1FE52065C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9ZRyRNP9SMiZ8bVUyfppiptWfX+R10qtuLFTLpatMr8=; b=iSwcfhpZ1UpgLr C/HNXjyu3FAkrboRbfUotVtlsMqX6CG0AIKFHRzgEBF2Li80WFI4PRu8ZWBhLuuHr7D+PtuXWrKGz Uh75mKWuQhDt3eeUhIFLRNowNxpjIEryKr6ZtIJRiVbcSSRy0HQUgILjynbZHqQx2YrsoXM8oEjIs zXgBAka2WihWPGq10JVzQ7HNeUSUvWqLLtG8PbMwRLe9Jyw4kFIYOSLxv9gqwI/RT/0vh+bNUAbJo B+UZQ1cfShiJy63pzMSFYtDMNxdoP0AAc+8JvsUToplQf0OLHferCoc25FS6lSuEpBcIBtC+jx6Jn clBSfb45z7l8X+6Wznbg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgm0O-0000wq-Fw; Thu, 04 Jun 2020 09:17:44 +0000 Received: from smtprelay0020.hostedemail.com ([216.40.44.20] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgm0L-0000vi-I6 for linux-arm-kernel@lists.infradead.org; Thu, 04 Jun 2020 09:17:42 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 7FBE8837F27E; Thu, 4 Jun 2020 09:17:39 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: lock32_040a1d426d96 X-Filterd-Recvd-Size: 3759 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Thu, 4 Jun 2020 09:17:36 +0000 (UTC) Message-ID: <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken From: Joe Perches To: Dan Carpenter , Linus Walleij Date: Thu, 04 Jun 2020 02:17:35 -0700 In-Reply-To: <20200604083120.GF22511@kadam> References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> <20200601183102.GS30374@kadam> <20200604083120.GF22511@kadam> User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200604_021741_658941_294D3547 X-CRM114-Status: GOOD ( 16.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Christophe JAILLET , Daniel Mack , Robert Jarzmik , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-06-04 at 11:31 +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 12:08:49AM +0200, Linus Walleij wrote: [] > > Fixes means it fixes something that was wrong in that commit. > > That's all. Whether syntactic or semantic or regression or > > serious or not does not matter. It is also not compulsory to > > add it is just helpful. > > Fixes tag should be compulsory for actual bug fixes. We had a the > Bad Binder exploit last year because commit f5cb779ba163 > ("ANDROID: binder: remove waitqueue when thread exits.") had no Fixes > tag and wasn't backported to Android kernels. Fixes tags IMO should be exclusively for actual bug fixes and should be mandatory. Perhaps: --- Documentation/process/submitting-patches.rst | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst index 1699b7f8e63a..285a84ae79de 100644 --- a/Documentation/process/submitting-patches.rst +++ b/Documentation/process/submitting-patches.rst @@ -636,12 +636,14 @@ idea was not posted in a public forum. That said, if we diligently credit our idea reporters, they will, hopefully, be inspired to help us again in the future. -A Fixes: tag indicates that the patch fixes an issue in a previous commit. It -is used to make it easy to determine where a bug originated, which can help -review a bug fix. This tag also assists the stable kernel team in determining -which stable kernel versions should receive your fix. This is the preferred -method for indicating a bug fixed by the patch. See :ref:`describe_changes` -for more details. +A Fixes: tag indicates that the patch fixes a "bug". i.e.: a logic defect or +regression in a previous commit. A Fixes: tag should not be used to indicate +that a previous commit had some trivial defect in spelling in the commit log or +some whitespace defect. The Fixes: tag is used to make it easy to determine +where a bug originated, which can help review a bug fix. The Fixes: tag also +assists the stable kernel team in determining which stable kernel versions +should receive your fix. This is the preferred method for indicating a bug is +fixed by the patch. See :ref:`describe_changes` for more details. .. _the_canonical_patch_format: _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel