From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ravishankar N Subject: Re: [RFC v3 2/2] fuse: Add posix acl support Date: Thu, 4 Aug 2016 18:10:54 +0530 Message-ID: <2ac828c4-8455-6b64-1aaf-84c5f273cf69@redhat.com> References: <1470086846-19844-1-git-send-email-seth.forshee@canonical.com> <1470086846-19844-3-git-send-email-seth.forshee@canonical.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7220886857432171626==" Cc: fuse-devel , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Nikolaus Rath To: Miklos Szeredi , Seth Forshee Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fuse-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org This is a multi-part message in MIME format. --===============7220886857432171626== Content-Type: multipart/alternative; boundary="------------F4D35CD95E731183D2134E15" This is a multi-part message in MIME format. --------------F4D35CD95E731183D2134E15 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 08/04/2016 05:41 PM, Miklos Szeredi wrote: > On Mon, Aug 1, 2016 at 11:27 PM, Seth Forshee > wrote: >> >Support posix acls in fuse only when CONFIG_FUSE_FS_POSIX_ACL=y >> >and default_permissions is used for the filesystem. When >> >default_permissions is not used fuse cannot meaninfully support >> >cals, as fuse_permission() only sends FUSE_PERMISSION from the >> >access, faccessat, chdir, fchdir, and chroot system calls. >> >Therefore whenever CONFIG_FUSE_FS_POSIX_ACL=n or >> >default_permissions is not used fuse will return -EOPNOTSUPP >> >whenever posix acl xattrs are read or written. > Which is breaking backward compatibilty. Please don't do this without > good reason. > > Even having "default_permissions" change behavior might cause > problems. +1. Not much of an acl expert but gluster turns off default_permissions [1] to support posix acls [2]. [1] https://github.com/gluster/glusterfs/blob/master/xlators/mount/fuse/src/fuse-bridge.c#L5696 [2] https://sourceforge.net/p/fuse/mailman/message/33015624/ -Ravi --------------F4D35CD95E731183D2134E15 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 7bit
On 08/04/2016 05:41 PM, Miklos Szeredi wrote:
On Mon, Aug 1, 2016 at 11:27 PM, Seth Forshee
<seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> wrote:

> Support posix acls in fuse only when CONFIG_FUSE_FS_POSIX_ACL=y
> and default_permissions is used for the filesystem. When
> default_permissions is not used fuse cannot meaninfully support
> cals, as fuse_permission() only sends FUSE_PERMISSION from the
> access, faccessat, chdir, fchdir, and chroot system calls.
> Therefore whenever CONFIG_FUSE_FS_POSIX_ACL=n or
> default_permissions is not used fuse will return -EOPNOTSUPP
> whenever posix acl xattrs are read or written.

Which is breaking backward compatibilty.  Please don't do this without
good reason.

Even having "default_permissions" change behavior might cause
problems.
+1. Not much of an acl expert but gluster turns off default_permissions [1] to support posix acls [2].

[1] https://github.com/gluster/glusterfs/blob/master/xlators/mount/fuse/src/fuse-bridge.c#L5696
[2] https://sourceforge.net/p/fuse/mailman/message/33015624/

-Ravi
 --------------F4D35CD95E731183D2134E15-- --===============7220886857432171626== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ --===============7220886857432171626== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- fuse-devel mailing list To unsubscribe or subscribe, visit https://lists.sourceforge.net/lists/listinfo/fuse-devel --===============7220886857432171626==--