From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761484AbdAIHHr (ORCPT ); Mon, 9 Jan 2017 02:07:47 -0500 Received: from mx2.suse.de ([195.135.220.15]:59294 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823AbdAIHHp (ORCPT ); Mon, 9 Jan 2017 02:07:45 -0500 Subject: Re: [PATCH 1/3] xen: clean up xenbus internal headers To: Boris Ostrovsky , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20170106150544.10836-1-jgross@suse.com> <20170106150544.10836-2-jgross@suse.com> <8c36bfb8-066f-1373-9558-54c2a1fb28d0@oracle.com> From: Juergen Gross Message-ID: <2acad511-b288-a7eb-8468-dca02c36be0a@suse.com> Date: Mon, 9 Jan 2017 08:07:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <8c36bfb8-066f-1373-9558-54c2a1fb28d0@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/01/17 21:52, Boris Ostrovsky wrote: > On 01/06/2017 10:05 AM, Juergen Gross wrote: >> The xenbus driver has an awful mixture of internal and global visible >> headers: some of the internal used only stuff is defined in the >> global header include/xen/xenbus.h while some stuff defined in internal >> headers is used by other drivers, too. >> >> Clean this up by moving the external used symbols to >> include/xen/xenbus.h and the symbols used internal only to a new > > I think > > s/external/externally/ > s/internal/internally/ Hmm, yes. >> header drivers/xen/xenbus/xenbus.h > > ... and remove xenbus_comms.h and xenbus_probe.h. > >> >> Signed-off-by: Juergen Gross >> --- >> drivers/xen/xenbus/{xenbus_probe.h => xenbus.h} | 64 ++++++++++++++----------- >> drivers/xen/xenbus/xenbus_client.c | 2 +- >> drivers/xen/xenbus/xenbus_comms.c | 2 +- >> drivers/xen/xenbus/xenbus_comms.h | 51 -------------------- >> drivers/xen/xenbus/xenbus_dev_backend.c | 2 +- >> drivers/xen/xenbus/xenbus_dev_frontend.c | 4 +- >> drivers/xen/xenbus/xenbus_probe.c | 3 +- >> drivers/xen/xenbus/xenbus_probe_backend.c | 3 +- >> drivers/xen/xenbus/xenbus_probe_frontend.c | 3 +- >> drivers/xen/xenbus/xenbus_xs.c | 3 +- >> drivers/xen/xenfs/super.c | 2 +- >> drivers/xen/xenfs/xenstored.c | 2 +- >> include/xen/xenbus.h | 12 ++--- >> 13 files changed, 52 insertions(+), 101 deletions(-) >> rename drivers/xen/xenbus/{xenbus_probe.h => xenbus.h} (58%) >> delete mode 100644 drivers/xen/xenbus/xenbus_comms.h >> >> diff --git a/drivers/xen/xenbus/xenbus_probe.h b/drivers/xen/xenbus/xenbus.h >> similarity index 58% >> rename from drivers/xen/xenbus/xenbus_probe.h >> rename to drivers/xen/xenbus/xenbus.h >> index c9ec7ca..6a80c1e 100644 >> --- a/drivers/xen/xenbus/xenbus_probe.h >> +++ b/drivers/xen/xenbus/xenbus.h >> @@ -1,10 +1,7 @@ >> -/****************************************************************************** >> - * xenbus_probe.h >> - * >> - * Talks to Xen Store to figure out what devices we have. >> +/* >> + * Private include for xenbus communications. >> * >> * Copyright (C) 2005 Rusty Russell, IBM Corporation >> - * Copyright (C) 2005 XenSource Ltd. > > Why is this? Result of merging two header files. Will re-add. Juergen