All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Matus Ujhelyi <ujhelyi.m@gmail.com>,
	acmattheis@gmx.net,
	Christoph Mattheis <christoph.mattheis@arcor.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Broken ethernet on SolidRun cubox-i
Date: Sat, 26 Dec 2020 13:18:01 +0100	[thread overview]
Message-ID: <2ae000163aa34b963dd387c824bdc3c9@walle.cc> (raw)

Hi Russell,

Ethernet is broken on 5.8+ kernel for "some" cubox-i boards. Some users
reached out to me because they suspected my commit 0465d8f830dc ("net: 
phy:
at803x: fix PHY ID masks") for the breakage. But it turned out not to be
the case. Instead on faulty boards the PHY was always on PHY address 4:

[    4.008024] libphy: fec_enet_mii_bus: probed
[    4.008151] mdio_bus 2188000.ethernet-1: MDIO device at address 0 is 
missing.
[    4.010155] fec 2188000.ethernet eth0: registered PHC device 0
[..]
[   19.172510] fec 2188000.ethernet eth0: Unable to connect to phy

# cat 
/sys/devices/soc0/soc/2100000.bus/2188000.ethernet/mdio_bus/2188000.ethernet-1/2188000.ethernet-1:04/phy_id
0x004dd072

Thus I suspect your commit 86b08bd5b994 ("ARM: dts: imx6-sr-som: add
ethernet PHY configuration") to be the culprit ;) This will pin the
PHY to address 0. I don't know how it was done before; like was there
autoprobing if there is no "phy-handle" or did the bootloader fix that
inplace. I don't have any cubox-i.

Anyway, I'm not sure what boards have the PHY at address 4. If it is
just per model and affects only the quad-core iMX.6 one or if it is
worse and the exact same model has it on 0 or 4. [1] might imply the
latter. If that is the case, SolidRun has added/removed a pull-down
on LED_ACT sometime during the board revisions.

I've looked at the vendor bootloader and it seems they scan the bus
for the PHY [2].

[1] 
https://forum.armbian.com/topic/15418-upgrading-cubox-i-buster-from-kernel-57y-to-58y-breaks-ethernet/?do=findComment&comment=116114
[2] 
https://github.com/SolidRun/u-boot/blob/v2018.01-solidrun-a38x/board/solidrun/mx6cuboxi/mx6cuboxi.c#L160

-michael

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2020-12-26 12:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-26 12:18 Michael Walle [this message]
2020-12-26 12:34 ` Broken ethernet on SolidRun cubox-i Russell King - ARM Linux admin
2020-12-27 15:33   ` Michael Walle
2020-12-27 15:59     ` Michael Walle
2020-12-27 16:11       ` Russell King - ARM Linux admin
2020-12-27 18:07         ` Andrew Lunn
2021-01-08 11:53         ` Russell King - ARM Linux admin
2021-01-08 11:58           ` Michael Walle
2021-01-08 12:01             ` Russell King - ARM Linux admin
2021-01-08 12:14               ` Michael Walle
2021-01-08 12:25                 ` Christoph Mattheis
2021-01-08 12:27                   ` Russell King - ARM Linux admin
2021-01-08 12:33                     ` Christoph Mattheis
2021-01-08 12:37                 ` Russell King - ARM Linux admin
2021-01-08 12:51                   ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ae000163aa34b963dd387c824bdc3c9@walle.cc \
    --to=michael@walle.cc \
    --cc=acmattheis@gmx.net \
    --cc=christoph.mattheis@arcor.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=ujhelyi.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.