All of lore.kernel.org
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-pci@vger.kernel.org, tglx@linutronix.de,
	Kurt Schwemmer <kurt.schwemmer@microsemi.com>
Subject: Re: [PATCH v2] pci/switchtec: Don't use completion's wait queue
Date: Thu, 2 Nov 2017 14:02:23 -0600	[thread overview]
Message-ID: <2b025b79-b625-dab0-5b68-c77ca0c2bd74@deltatee.com> (raw)
In-Reply-To: <20171102180548.f6sc2edxbvw7qeu7@linutronix.de>



On 02/11/17 12:05 PM, Sebastian Andrzej Siewior wrote:
> On 2017-11-02 11:23:16 [-0600], Logan Gunthorpe wrote:
>>
>> Well, you clearly didn't read the article I sent or even what I said. But
> 
> I did, I just didn't manage to make the link.
> The futex example looks like compiler optimisation which should not have
> happen and would be ideal for READ_ONCE, yes. But this is not the case
> here and this is what I pointed out.

And you still missed what I said and the entire point of the article.

> See 7c34e3180a01 ("sched/completion: Add lock-free checking of the
> blocking case")

Sounds questionable. I don't see how that function could be inlined, 
even then.

Logan

  reply	other threads:[~2017-11-02 20:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04  9:50 [PATCH] pci/switchtec: Don't use completion's wait queue Sebastian Andrzej Siewior
2017-10-04 16:13 ` Logan Gunthorpe
2017-10-05 10:51   ` [PATCH v2] " Sebastian Andrzej Siewior
2017-10-05 18:46     ` Logan Gunthorpe
2017-11-02 15:07       ` Sebastian Andrzej Siewior
2017-11-02 16:03         ` Logan Gunthorpe
2017-11-02 17:17           ` Sebastian Andrzej Siewior
2017-11-02 17:23             ` Logan Gunthorpe
2017-11-02 18:05               ` Sebastian Andrzej Siewior
2017-11-02 20:02                 ` Logan Gunthorpe [this message]
2017-11-02 20:53                   ` Sebastian Andrzej Siewior
2017-11-02 20:55                     ` Logan Gunthorpe
2017-11-02 17:19           ` [PATCH v3] " Sebastian Andrzej Siewior
2017-11-02 20:53             ` Logan Gunthorpe
2017-11-03  8:22               ` Sebastian Andrzej Siewior
2017-11-03 16:06                 ` Logan Gunthorpe
2017-11-03 16:19                   ` Sebastian Andrzej Siewior
2017-11-03 16:33                     ` Logan Gunthorpe
2017-11-03 16:39                       ` Sebastian Andrzej Siewior
2017-11-03 16:42                         ` Logan Gunthorpe
2017-11-02 15:12       ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b025b79-b625-dab0-5b68-c77ca0c2bd74@deltatee.com \
    --to=logang@deltatee.com \
    --cc=bigeasy@linutronix.de \
    --cc=kurt.schwemmer@microsemi.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.