From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Date: Mon, 26 Apr 2021 08:06:06 +0900 Subject: [PATCH v2 07/13] mmc: synquacer: Add SynQuacer F_SDH30 SDHCI driver In-Reply-To: References: <161861622792.298230.15803163505976731363.stgit@localhost> <161861630583.298230.7570622190142671460.stgit@localhost> <2474bd67-4861-1d4c-268b-fa10c5cdd99b@samsung.com> Message-ID: <2b058e56-bb3b-31cf-262b-b9d523e5dd94@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 4/26/21 7:05 AM, Jassi Brar wrote: > On Mon, 19 Apr 2021 at 17:05, Jaehoon Chung wrote: > >>> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c >>> index d9ab6a0a83..f038debc6c 100644 >>> --- a/drivers/mmc/sdhci.c >>> +++ b/drivers/mmc/sdhci.c >>> @@ -708,6 +708,15 @@ static int sdhci_init(struct mmc *mmc) >>> >>> sdhci_set_power(host, fls(mmc->cfg->voltages) - 1); >>> >>> + if (IS_ENABLED(CONFIG_F_SDH30_SDHCI)) { >> >> I don't want to add specific sdhci driver configuration in sdhci.c. >> >> According to below comment and Specification, >> it has to delay 1ms. Can it be removed the above condition checking? >> >>> + /* >>> + * Reference to Part1 Physical Layer Simplified Specification >>> + * Ver 3.01, 6.4.1 Power Up >>> + * This delay must be at least 74 clock sizes, or 1 ms. >>> + */ >>> + udelay(1000); >> >> I don't have any objection about this, If possible, it needs to calculate clock-cycle with real clock value in future. >> > This change is carried over from some ancient patchset. > While it might be helpful to some platform, I tried removing the > delay, and it still works. So for f_sdh30 we don't seem to need it. Thanks for checking it. Best Regards, Jaehoon Chung > > thanks. >