Re: [PATCH v5 1/5] extcon: sm5502: Clarify SM5703's i2c device ID

From: Chanwoo Choi <cwchoi00@gmail.com>
To: Markuss Broks <markuss.broks@gmail.com>, linux-kernel@vger.kernel.org
Cc: phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Matti Vaittinen <mazziesaccount@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/5] extcon: sm5502: Clarify SM5703's i2c device ID
Date: Wed, 27 Apr 2022 00:44:16 +0900	[thread overview]
Message-ID: <2b13d915-263f-4d3f-ea35-4cb0e937bb33@gmail.com> (raw)
In-Reply-To: <20220423085319.483524-2-markuss.broks@gmail.com>

On 22. 4. 23. 17:53, Markuss Broks wrote:
> While SM5502 and SM5504 are purely micro USB switching
> circuits, SM5703 is a multi-function device which has multiple
> modules in it. Change the i2c_device_id of it to avoid conflict
> with MFD driver.
> 
> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
> ---
>   drivers/extcon/extcon-sm5502.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c
> index 17a40c3782ee..f706f5288257 100644
> --- a/drivers/extcon/extcon-sm5502.c
> +++ b/drivers/extcon/extcon-sm5502.c
> @@ -831,7 +831,7 @@ static SIMPLE_DEV_PM_OPS(sm5502_muic_pm_ops,
>   static const struct i2c_device_id sm5502_i2c_id[] = {
>   	{ "sm5502", (kernel_ulong_t)&sm5502_data },
>   	{ "sm5504", (kernel_ulong_t)&sm5504_data },
> -	{ "sm5703", (kernel_ulong_t)&sm5502_data },
> +	{ "sm5703-muic", (kernel_ulong_t)&sm5502_data },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(i2c, sm5502_i2c_id);

Applied it because this patch depends on already merged patch
on extcon-next branch.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi