From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EC0E1EA8F; Fri, 29 Mar 2024 19:22:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711740140; cv=none; b=abFgKWmv/TUvsnoWRao1ylhU5A7D272HRTdCcvNEUYhU5TA4dqUZ5Xl6vtQ/gLeHU9gR5fsbN+6cWdu13ixOOKt6YPKTjY1t0EgmTaUFnYG6WR1eCjeTJ48qZS49zYgfYGgvkICF5Q9R1AE5hOD5O6KoqQ7/f9yojkhOSyM7Bd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711740140; c=relaxed/simple; bh=x9oCqEmE47fH+lCruYBavHci7f/vBeTmfvVEWU5dFJk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jZ/Cbt7ZvoP2I/Y73xHyE/F7R8EVFIWevWq0IqnFQozVjbWpOz3NzzUm2Yywjwny+LkE/FTeLbK8wpPgsUKk7fGAC92UuUFId6U40vWlYZK7u2Z9eLk19THFNTrJKM3epmROVUEoNVCZ7horEvMgA+xVzJxWJlf6KPUJGG6K5NY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=biJZ2hn2; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="biJZ2hn2" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-41545616455so12367935e9.0; Fri, 29 Mar 2024 12:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711740137; x=1712344937; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I0COmV02Xjs6bigwSR72AO2S5c2HwRuO1pRKJTQ072A=; b=biJZ2hn2ey47XHYC4qKgsivyRew3DzvMdP/Ey2iNb1nInoqhb+Vg5dsh87FwAhlBQm GQSiuv7YlpzM51lOMLpZBWzPxH8hluTIyFaTYkGEXfPE+JdfPFNoN1iIk7OVzusNEtgT O0V07mCynqVlJLHe6ypSJcJf838thvoGDWF3yViow3bS7T26mCMMFXGvzwujc4m5/jwi pfd/zoRBYC1ggPvLLXtCCIuJEnsZHpiZ334KBiAGBowa8PqSfzIQzBTkLuKGdoXeBPv7 Fm+o0buDo5JTwpsc1asrTMKguqB/wPapcf6o4t/c6RlkVIWdsjoBAWc99L9BitvGN92X TVeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711740137; x=1712344937; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I0COmV02Xjs6bigwSR72AO2S5c2HwRuO1pRKJTQ072A=; b=oOV0qk+Jcqi/WzAEGQVVL9Sgu94zu0fI1cvXADf2pn7L3QO9Jx/huv1w9YmofRYtlR 2xwMT4gWjJ6woeiF3CgYPB26HaD+l4Fk88x+/KzAfxa+6ENyV6cyalecJiABSzkf55Q5 +5zgZSBrygl/R2684B+x3kHf8qRg46yX1QWrFP7FycS4IhXUSTHwitjEQsRgJnRuIUob LWcMBmMBo1ISkPnUONqk96+V+yUioZVosDWInmbn11RWv4irxPmUHuwWp8MI4jnDTkGc morj4U081idFfiSz2oXyv0SzuX3tx+XfyQu6dllRLD6cd5IBf4EK8V2rfZqMF9LW+7Q6 k9xw== X-Forwarded-Encrypted: i=1; AJvYcCUf033yVM2qgw4NfOLyI1gX4K1X+CYaftkK8h+ua9aFGZu7BMHbkgQPt0FGKwo4/6yZZX9U6IOc3IR9P23mJgen1EiXwqM0yuMuWEkxdOkioAGyv2HIzybHBsyDBPQWiYckuil6JzbQbKCa+A== X-Gm-Message-State: AOJu0YyqDVf66LBDhg0QjjI6yxmwVFoIcXCA9uGU9wZZdo0jhi2jJ7II iVB/dwXtvqMzSxGZ1OuNnQdyhahmnqZinrQq7T+4glW82EUFe9p4 X-Google-Smtp-Source: AGHT+IEwn3YaZULTZvrB4ScCr89wKFSCotW9AHiPfe5RvM3cp7fGOw8HQqEkvOEPo41qmgrr2bQg5A== X-Received: by 2002:a7b:cd0c:0:b0:414:610b:13c3 with SMTP id f12-20020a7bcd0c000000b00414610b13c3mr2387709wmj.27.1711740137161; Fri, 29 Mar 2024 12:22:17 -0700 (PDT) Received: from ?IPV6:2a02:8071:b783:140:927c:82ba:d32d:99c1? ([2a02:8071:b783:140:927c:82ba:d32d:99c1]) by smtp.gmail.com with ESMTPSA id fc11-20020a05600c524b00b0041408e16e6bsm6272344wmb.25.2024.03.29.12.22.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Mar 2024 12:22:16 -0700 (PDT) Message-ID: <2b1dc031-d645-494c-9103-a2bb422ea60b@gmail.com> Date: Fri, 29 Mar 2024 20:22:14 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 00/13] firmware: qcom: qseecom: convert to using the TZ allocator To: Bartosz Golaszewski Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Elliot Berman , Krzysztof Kozlowski , Guru Das Srinagesh , Andrew Halaney , Alex Elder , Srini Kandagatla , Arnd Bergmann , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@quicinc.com, Bartosz Golaszewski References: <20240325100359.17001-1-brgl@bgdev.pl> <56e1c63a-4c09-4d92-9ef2-aad5390879cc@gmail.com> <82f94b54-82d1-49b9-badf-63d948b347fc@gmail.com> <97e1f121-9e84-4e63-9c9c-57e2de0b29d7@gmail.com> Content-Language: en-US From: Maximilian Luz In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/29/24 8:07 PM, Bartosz Golaszewski wrote: > On Fri, Mar 29, 2024 at 7:56 PM Maximilian Luz wrote: >> >> >> >> On 3/29/24 7:53 PM, Maximilian Luz wrote: >>> On 3/29/24 11:22 AM, Bartosz Golaszewski wrote: >>>> On Thu, Mar 28, 2024 at 7:55 PM Bartosz Golaszewski wrote: >>>>> >>>>> On Thu, Mar 28, 2024 at 5:50 PM Maximilian Luz wrote: >>>>>> >>>>>> If I understand correctly, it enters an atomic section in >>>>>> qcom_tzmem_alloc() and then tries to schedule somewhere down the line. >>>>>> So this shouldn't be qseecom specific. >>>>>> >>>>>> I should probably also say that I'm currently testing this on a patched >>>>>> v6.8 kernel, so there's a chance that it's my fault. However, as far as >>>>>> I understand, it enters an atomic section in qcom_tzmem_alloc() and then >>>>>> later tries to expand the pool memory with dma_alloc_coherent(). Which >>>>>> AFAIK is allowed to sleep with GFP_KERNEL (and I guess that that's the >>>>>> issue here). >>>>>> >>>>>> I've also tried the shmem allocator option, but that seems to get stuck >>>>>> quite early at boot, before I even have usb-serial access to get any >>>>>> logs. If I can find some more time, I'll try to see if I can get some >>>>>> useful output for that. >>>>>> >>>>> >>>>> Ah, I think it happens here: >>>>> >>>>> + guard(spinlock_irqsave)(&pool->lock); >>>>> + >>>>> +again: >>>>> + vaddr = gen_pool_alloc(pool->genpool, size); >>>>> + if (!vaddr) { >>>>> + if (qcom_tzmem_try_grow_pool(pool, size, gfp)) >>>>> + goto again; >>>>> >>>>> We were called with GFP_KERNEL so this is what we pass on to >>>>> qcom_tzmem_try_grow_pool() but we're now holding the spinlock. I need >>>>> to revisit it. Thanks for the catch! >>>>> >>>>> Bart >>>> >>>> Can you try the following tree? >>>> >>>> https://git.codelinaro.org/bartosz_golaszewski/linux.git >>>> topic/shm-bridge-v10 >>>> >>>> gen_pool_alloc() and gen_pool_add_virt() can be used without external >>>> serialization. We only really need to protect the list of areas in the >>>> pool when adding a new element. We could possibly even use >>>> list_add_tail_rcu() as it updates the pointers atomically and go >>>> lockless. >>> >>> Thanks! That fixes the allocations for CONFIG_QCOM_TZMEM_MODE_GENERIC=y. >>> Unfortunately, with the shmbridge mode it still gets stuck at boot (and >>> I haven't had the time to look into it yet). >>> >>> And for more bad news: It looks like the new allocator now fully exposes >>> a bug that I've been tracking down the last couple of days. In short, >>> uefisecapp doesn't seem to be happy when we split the allocations for >>> request and response into two, causing commands to fail. Instead it >>> wants a single buffer for both. Before, it seemed to be fairly sporadic >>> (likely because kzalloc in sequence just returned consecutive memory >>> almost all of the time) but now it's basically every call that fails. >>> >>> I have a fix for that almost ready and I'll likely post it in the next >>> hour. But that means that you'll probably have to rebase this series >>> on top of it... >> >> Forgot to mention: I tested it with the fix and this series, and that >> works. >> > > Both with and without SHM bridge? With CONFIG_QCOM_TZMEM_MODE_GENERIC=y (and the upcoming fix) everything works. With CONFIG_QCOM_TZMEM_MODE_SHMBRIDGE=y things unfortunately still get stuck at boot (regardless of the fix). I think that's happening even before anything efivar related should come up. > If so, please Cc me on the fix. Sure, will do. Best regards, Max From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 659CFC6FD1F for ; Fri, 29 Mar 2024 19:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iSn3DgFpOFGFvffJy9Bzb5GVqXUoL/PNNjMidlvtTZg=; b=EBUuVgvKOhOyLK CMRtf6mGs87zHKuSh7VccOpvQDydGWNhx6C2Gpu6DJdjJD8ksDcffMr0HcHH8gG+cPhDz58bg35ei 7BsuERZRg1i2WyJu1cP8fFrTh/daJVwtQenQzdt4I94rL6u9efqUOz+BvLk1n5yJpU36X3rFRWUqK tGZN+eewdMzkA7mqQFhJusUggICzjvHtIp2CaXdAHR2fV+jLHhzOayhhzZ7fvu8PFgpquYPe0wnm7 dmJR/aGjRPzUmuvqVyxt4zCZJJ9inBY+hIbzToPWI830bUZiAGFdG/VWYohbO31DGAUBTADE4D334 wZuaYd5YSvvSWlFHiKjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqHnz-00000001kqF-32hf; Fri, 29 Mar 2024 19:22:23 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqHnw-00000001kpX-1esa for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2024 19:22:21 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-41544650225so13242785e9.2 for ; Fri, 29 Mar 2024 12:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711740137; x=1712344937; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I0COmV02Xjs6bigwSR72AO2S5c2HwRuO1pRKJTQ072A=; b=V8UmfFpVTpYCzug5lzFpss9vGHiquqE2n1QLhgZzcy2Vh9l1WzfYt9XPWQsVFZylso deBsJmfSiqxZycx7FpqyQx+7lABVgSafk7JCYGxS9CXxT9HtH4TUqByVDJGGgaylCN0y KK5mW/UyHTjJfEJ/lvckVvE6I8p+z77WmVjYE4IjWVVCLx9RXY8XUtgsZQrd2o4rZ4Jd fJlUU7I8Yytx6c806kdKhHeOi7shJ+epEYB3WvW+4QVXyKVUy7He9fZCT29e6gtSe28K J5rAfJAfbwVtju3+WfbTn5LJyiysB2zw+ldiw9z/hGfKlkn8cLg0JaTbKO2blS0Hj9St bwJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711740137; x=1712344937; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I0COmV02Xjs6bigwSR72AO2S5c2HwRuO1pRKJTQ072A=; b=k0acSLVWljbA7L8bOXmmAMaaZsLYS9wwAJTPZBH2FseScungee4NS/0qgYjeQeRuwk mCXUwgKVRJa1lxBcFVRnJo8qzLUy3ghtID6xfFhbgi4r16ytWCYJQDVoHTp06uTrG1oe Sp9R2WvHRlH43ACxfNytT21x/YI/1AvgW9HSgp6mVoTtavr6PNrcRazsWviQjkTkohtj xjHNMtWyk61apu6VWWixg7Do/iP0eJraHjVXqTqY9LJ8PYkH+H8VlsiCHhrWWcJwjTrM a9nIg7UW+4h9pqovtqaw3qM5vy6nLjicEIPNfXq7WSTTZ9ZywJg6Ra9V0BSKSgI6E7vg wHfQ== X-Forwarded-Encrypted: i=1; AJvYcCU/vGuHiUKThdQJot2fmGZwALZjnOG1FJwI4Q+wg3jgCbv7g9Zzf7phETgpPZDyRAihJ7h2lZzDo7m1wa9i839xqRaVHgB4urGZk+14d7nfxTLotuY= X-Gm-Message-State: AOJu0YwraYft5o2oLoZGkbKNo7zzr0VtR9eoinIuaOj0M2gwTt2KYxej 0ZsjLD8GEMD0FGfkn6RsTzQww8XJNLrR7eVG5Oo6+iSQUI6Ljfsi X-Google-Smtp-Source: AGHT+IEwn3YaZULTZvrB4ScCr89wKFSCotW9AHiPfe5RvM3cp7fGOw8HQqEkvOEPo41qmgrr2bQg5A== X-Received: by 2002:a7b:cd0c:0:b0:414:610b:13c3 with SMTP id f12-20020a7bcd0c000000b00414610b13c3mr2387709wmj.27.1711740137161; Fri, 29 Mar 2024 12:22:17 -0700 (PDT) Received: from ?IPV6:2a02:8071:b783:140:927c:82ba:d32d:99c1? ([2a02:8071:b783:140:927c:82ba:d32d:99c1]) by smtp.gmail.com with ESMTPSA id fc11-20020a05600c524b00b0041408e16e6bsm6272344wmb.25.2024.03.29.12.22.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Mar 2024 12:22:16 -0700 (PDT) Message-ID: <2b1dc031-d645-494c-9103-a2bb422ea60b@gmail.com> Date: Fri, 29 Mar 2024 20:22:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 00/13] firmware: qcom: qseecom: convert to using the TZ allocator To: Bartosz Golaszewski Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Elliot Berman , Krzysztof Kozlowski , Guru Das Srinagesh , Andrew Halaney , Alex Elder , Srini Kandagatla , Arnd Bergmann , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@quicinc.com, Bartosz Golaszewski References: <20240325100359.17001-1-brgl@bgdev.pl> <56e1c63a-4c09-4d92-9ef2-aad5390879cc@gmail.com> <82f94b54-82d1-49b9-badf-63d948b347fc@gmail.com> <97e1f121-9e84-4e63-9c9c-57e2de0b29d7@gmail.com> Content-Language: en-US From: Maximilian Luz In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240329_122220_504780_E218D34D X-CRM114-Status: GOOD ( 27.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMy8yOS8yNCA4OjA3IFBNLCBCYXJ0b3N6IEdvbGFzemV3c2tpIHdyb3RlOgo+IE9uIEZyaSwg TWFyIDI5LCAyMDI0IGF0IDc6NTbigK9QTSBNYXhpbWlsaWFuIEx1eiA8bHV6bWF4aW1pbGlhbkBn bWFpbC5jb20+IHdyb3RlOgo+Pgo+Pgo+Pgo+PiBPbiAzLzI5LzI0IDc6NTMgUE0sIE1heGltaWxp YW4gTHV6IHdyb3RlOgo+Pj4gT24gMy8yOS8yNCAxMToyMiBBTSwgQmFydG9zeiBHb2xhc3pld3Nr aSB3cm90ZToKPj4+PiBPbiBUaHUsIE1hciAyOCwgMjAyNCBhdCA3OjU14oCvUE0gQmFydG9zeiBH b2xhc3pld3NraSA8YnJnbEBiZ2Rldi5wbD4gd3JvdGU6Cj4+Pj4+Cj4+Pj4+IE9uIFRodSwgTWFy IDI4LCAyMDI0IGF0IDU6NTDigK9QTSBNYXhpbWlsaWFuIEx1eiA8bHV6bWF4aW1pbGlhbkBnbWFp bC5jb20+IHdyb3RlOgo+Pj4+Pj4KPj4+Pj4+IElmIEkgdW5kZXJzdGFuZCBjb3JyZWN0bHksIGl0 IGVudGVycyBhbiBhdG9taWMgc2VjdGlvbiBpbgo+Pj4+Pj4gcWNvbV90em1lbV9hbGxvYygpIGFu ZCB0aGVuIHRyaWVzIHRvIHNjaGVkdWxlIHNvbWV3aGVyZSBkb3duIHRoZSBsaW5lLgo+Pj4+Pj4g U28gdGhpcyBzaG91bGRuJ3QgYmUgcXNlZWNvbSBzcGVjaWZpYy4KPj4+Pj4+Cj4+Pj4+PiBJIHNo b3VsZCBwcm9iYWJseSBhbHNvIHNheSB0aGF0IEknbSBjdXJyZW50bHkgdGVzdGluZyB0aGlzIG9u IGEgcGF0Y2hlZAo+Pj4+Pj4gdjYuOCBrZXJuZWwsIHNvIHRoZXJlJ3MgYSBjaGFuY2UgdGhhdCBp dCdzIG15IGZhdWx0LiBIb3dldmVyLCBhcyBmYXIgYXMKPj4+Pj4+IEkgdW5kZXJzdGFuZCwgaXQg ZW50ZXJzIGFuIGF0b21pYyBzZWN0aW9uIGluIHFjb21fdHptZW1fYWxsb2MoKSBhbmQgdGhlbgo+ Pj4+Pj4gbGF0ZXIgdHJpZXMgdG8gZXhwYW5kIHRoZSBwb29sIG1lbW9yeSB3aXRoIGRtYV9hbGxv Y19jb2hlcmVudCgpLiBXaGljaAo+Pj4+Pj4gQUZBSUsgaXMgYWxsb3dlZCB0byBzbGVlcCB3aXRo IEdGUF9LRVJORUwgKGFuZCBJIGd1ZXNzIHRoYXQgdGhhdCdzIHRoZQo+Pj4+Pj4gaXNzdWUgaGVy ZSkuCj4+Pj4+Pgo+Pj4+Pj4gSSd2ZSBhbHNvIHRyaWVkIHRoZSBzaG1lbSBhbGxvY2F0b3Igb3B0 aW9uLCBidXQgdGhhdCBzZWVtcyB0byBnZXQgc3R1Y2sKPj4+Pj4+IHF1aXRlIGVhcmx5IGF0IGJv b3QsIGJlZm9yZSBJIGV2ZW4gaGF2ZSB1c2Itc2VyaWFsIGFjY2VzcyB0byBnZXQgYW55Cj4+Pj4+ PiBsb2dzLiBJZiBJIGNhbiBmaW5kIHNvbWUgbW9yZSB0aW1lLCBJJ2xsIHRyeSB0byBzZWUgaWYg SSBjYW4gZ2V0IHNvbWUKPj4+Pj4+IHVzZWZ1bCBvdXRwdXQgZm9yIHRoYXQuCj4+Pj4+Pgo+Pj4+ Pgo+Pj4+PiBBaCwgSSB0aGluayBpdCBoYXBwZW5zIGhlcmU6Cj4+Pj4+Cj4+Pj4+ICsgICAgICAg Z3VhcmQoc3BpbmxvY2tfaXJxc2F2ZSkoJnBvb2wtPmxvY2spOwo+Pj4+PiArCj4+Pj4+ICthZ2Fp bjoKPj4+Pj4gKyAgICAgICB2YWRkciA9IGdlbl9wb29sX2FsbG9jKHBvb2wtPmdlbnBvb2wsIHNp emUpOwo+Pj4+PiArICAgICAgIGlmICghdmFkZHIpIHsKPj4+Pj4gKyAgICAgICAgICAgICAgIGlm IChxY29tX3R6bWVtX3RyeV9ncm93X3Bvb2wocG9vbCwgc2l6ZSwgZ2ZwKSkKPj4+Pj4gKyAgICAg ICAgICAgICAgICAgICAgICAgZ290byBhZ2FpbjsKPj4+Pj4KPj4+Pj4gV2Ugd2VyZSBjYWxsZWQg d2l0aCBHRlBfS0VSTkVMIHNvIHRoaXMgaXMgd2hhdCB3ZSBwYXNzIG9uIHRvCj4+Pj4+IHFjb21f dHptZW1fdHJ5X2dyb3dfcG9vbCgpIGJ1dCB3ZSdyZSBub3cgaG9sZGluZyB0aGUgc3BpbmxvY2su IEkgbmVlZAo+Pj4+PiB0byByZXZpc2l0IGl0LiBUaGFua3MgZm9yIHRoZSBjYXRjaCEKPj4+Pj4K Pj4+Pj4gQmFydAo+Pj4+Cj4+Pj4gQ2FuIHlvdSB0cnkgdGhlIGZvbGxvd2luZyB0cmVlPwo+Pj4+ Cj4+Pj4gICAgICAgaHR0cHM6Ly9naXQuY29kZWxpbmFyby5vcmcvYmFydG9zel9nb2xhc3pld3Nr aS9saW51eC5naXQKPj4+PiB0b3BpYy9zaG0tYnJpZGdlLXYxMAo+Pj4+Cj4+Pj4gZ2VuX3Bvb2xf YWxsb2MoKSBhbmQgZ2VuX3Bvb2xfYWRkX3ZpcnQoKSBjYW4gYmUgdXNlZCB3aXRob3V0IGV4dGVy bmFsCj4+Pj4gc2VyaWFsaXphdGlvbi4gV2Ugb25seSByZWFsbHkgbmVlZCB0byBwcm90ZWN0IHRo ZSBsaXN0IG9mIGFyZWFzIGluIHRoZQo+Pj4+IHBvb2wgd2hlbiBhZGRpbmcgYSBuZXcgZWxlbWVu dC4gV2UgY291bGQgcG9zc2libHkgZXZlbiB1c2UKPj4+PiBsaXN0X2FkZF90YWlsX3JjdSgpIGFz IGl0IHVwZGF0ZXMgdGhlIHBvaW50ZXJzIGF0b21pY2FsbHkgYW5kIGdvCj4+Pj4gbG9ja2xlc3Mu Cj4+Pgo+Pj4gVGhhbmtzISBUaGF0IGZpeGVzIHRoZSBhbGxvY2F0aW9ucyBmb3IgQ09ORklHX1FD T01fVFpNRU1fTU9ERV9HRU5FUklDPXkuCj4+PiBVbmZvcnR1bmF0ZWx5LCB3aXRoIHRoZSBzaG1i cmlkZ2UgbW9kZSBpdCBzdGlsbCBnZXRzIHN0dWNrIGF0IGJvb3QgKGFuZAo+Pj4gSSBoYXZlbid0 IGhhZCB0aGUgdGltZSB0byBsb29rIGludG8gaXQgeWV0KS4KPj4+Cj4+PiBBbmQgZm9yIG1vcmUg YmFkIG5ld3M6IEl0IGxvb2tzIGxpa2UgdGhlIG5ldyBhbGxvY2F0b3Igbm93IGZ1bGx5IGV4cG9z ZXMKPj4+IGEgYnVnIHRoYXQgSSd2ZSBiZWVuIHRyYWNraW5nIGRvd24gdGhlIGxhc3QgY291cGxl IG9mIGRheXMuIEluIHNob3J0LAo+Pj4gdWVmaXNlY2FwcCBkb2Vzbid0IHNlZW0gdG8gYmUgaGFw cHkgd2hlbiB3ZSBzcGxpdCB0aGUgYWxsb2NhdGlvbnMgZm9yCj4+PiByZXF1ZXN0IGFuZCByZXNw b25zZSBpbnRvIHR3bywgY2F1c2luZyBjb21tYW5kcyB0byBmYWlsLiBJbnN0ZWFkIGl0Cj4+PiB3 YW50cyBhIHNpbmdsZSBidWZmZXIgZm9yIGJvdGguIEJlZm9yZSwgaXQgc2VlbWVkIHRvIGJlIGZh aXJseSBzcG9yYWRpYwo+Pj4gKGxpa2VseSBiZWNhdXNlIGt6YWxsb2MgaW4gc2VxdWVuY2UganVz dCByZXR1cm5lZCBjb25zZWN1dGl2ZSBtZW1vcnkKPj4+IGFsbW9zdCBhbGwgb2YgdGhlIHRpbWUp IGJ1dCBub3cgaXQncyBiYXNpY2FsbHkgZXZlcnkgY2FsbCB0aGF0IGZhaWxzLgo+Pj4KPj4+IEkg aGF2ZSBhIGZpeCBmb3IgdGhhdCBhbG1vc3QgcmVhZHkgYW5kIEknbGwgbGlrZWx5IHBvc3QgaXQg aW4gdGhlIG5leHQKPj4+IGhvdXIuIEJ1dCB0aGF0IG1lYW5zIHRoYXQgeW91J2xsIHByb2JhYmx5 IGhhdmUgdG8gcmViYXNlIHRoaXMgc2VyaWVzCj4+PiBvbiB0b3Agb2YgaXQuLi4KPj4KPj4gRm9y Z290IHRvIG1lbnRpb246IEkgdGVzdGVkIGl0IHdpdGggdGhlIGZpeCBhbmQgdGhpcyBzZXJpZXMs IGFuZCB0aGF0Cj4+IHdvcmtzLgo+Pgo+IAo+IEJvdGggd2l0aCBhbmQgd2l0aG91dCBTSE0gYnJp ZGdlPwoKV2l0aCBDT05GSUdfUUNPTV9UWk1FTV9NT0RFX0dFTkVSSUM9eSAoYW5kIHRoZSB1cGNv bWluZyBmaXgpIGV2ZXJ5dGhpbmcKd29ya3MuIFdpdGggQ09ORklHX1FDT01fVFpNRU1fTU9ERV9T SE1CUklER0U9eSB0aGluZ3MgdW5mb3J0dW5hdGVseQpzdGlsbCBnZXQgc3R1Y2sgYXQgYm9vdCAo cmVnYXJkbGVzcyBvZiB0aGUgZml4KS4gSSB0aGluayB0aGF0J3MKaGFwcGVuaW5nIGV2ZW4gYmVm b3JlIGFueXRoaW5nIGVmaXZhciByZWxhdGVkIHNob3VsZCBjb21lIHVwLgoKPiBJZiBzbywgcGxl YXNlIENjIG1lIG9uIHRoZSBmaXguCgpTdXJlLCB3aWxsIGRvLgoKQmVzdCByZWdhcmRzLApNYXgK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK