From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBFEAC433ED for ; Fri, 9 Apr 2021 16:20:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82FFC6103E for ; Fri, 9 Apr 2021 16:20:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82FFC6103E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUts6-0004f2-LM for qemu-devel@archiver.kernel.org; Fri, 09 Apr 2021 12:20:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUtlV-0004ZO-MU for qemu-devel@nongnu.org; Fri, 09 Apr 2021 12:13:49 -0400 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]:50948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lUtlS-0002Bj-IQ for qemu-devel@nongnu.org; Fri, 09 Apr 2021 12:13:49 -0400 Received: by mail-pj1-x1036.google.com with SMTP id bg21so3151187pjb.0 for ; Fri, 09 Apr 2021 09:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fIlJXCGSGZsMNvjQCoen+H+UQLQVBVsoEv/7gizkyZw=; b=igPogZ/XoEqmnEbItqD+/L4o0RoMaSx1u49fB73wPe/VR61Y0A0vRYdwHEnKT8XkqS OtF6XxVGSx7j7AeRyjFQ7oNv9m2gzVbVS7VO3lAKBTWo4XczJPHgyVTUNgmqM+aP6lNE vP/73pqn2OkQ+xxxUKosJMLmuA7V3M06FKRxLfVhQx3h9hG4YgqxHMuz9UNvQsOTI8hD lKpu9zGbvdF8meORnYvFLFtY16JwwJu7/gcWtK54IkLdxnN57FPwu9gbkMYxW+dwYErn ukMokOJhQj+4WFtAWpp7i4wM6+Keu8UGGqiSpsA3Ix7F5uPSkmL8190FSXkM0Lz25MMO +qtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fIlJXCGSGZsMNvjQCoen+H+UQLQVBVsoEv/7gizkyZw=; b=LPkG8iFUy3sDL64anSLTZbq0kTE+6D3I48y4FKVmv8IcHDM7xics/cKUKp94eU8odX Eq4kc3/cZGMsDQRIfsmwVCDNVeDjn9enKHQqcL81INUXaM0war7h+sBl8r/ROGTK0B9J d9PrxZT/GTod67LkPnU69UNR+1Lper3eaoMK/y7qkLMuNQWHDcKQt1hLi7E5LNXYkUo7 rZ8s7qUgD+siSatEoJrJCxbu0bnjoBU4X2ob9JvoOEPfoLIFdw00IarPho8K8dthFGEd oZ0+5YFqZaKi/pmvnXQwRDhf4r6I2Qw9Osq+omUwb3appT/+PAm4BN2fervqD1N6ranq +Sqg== X-Gm-Message-State: AOAM5339SlYjvW56Q5SFi/aWYZCcd8aHbhK+v6/57bIWgjboYlcrtWei Dur/p1jmUmh916DIJoD2t1ISgQ== X-Google-Smtp-Source: ABdhPJxaQu4HYGu7tF5lTk6aYN/bktEU8480pzupuu03WnuWasq6nv2g4ui6TSq1eaiEtBsPTCWs2A== X-Received: by 2002:a17:90a:9404:: with SMTP id r4mr14314658pjo.64.1617984824930; Fri, 09 Apr 2021 09:13:44 -0700 (PDT) Received: from [192.168.1.11] ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id h29sm3106581pgb.3.2021.04.09.09.13.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Apr 2021 09:13:44 -0700 (PDT) Subject: Re: [RFC PATCH-for-6.1 v2 1/6] target/mips/cpu: Use clock_has_source() instead of clock_get() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210409093623.2402750-1-f4bug@amsat.org> <20210409093623.2402750-2-f4bug@amsat.org> From: Richard Henderson Message-ID: <2b1dce27-bfc6-b8bf-07a5-a4596a00d97b@linaro.org> Date: Fri, 9 Apr 2021 09:13:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210409093623.2402750-2-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1036.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Rikalo , Luc Michel , Huacai Chen , Hao Wu , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/9/21 2:36 AM, Philippe Mathieu-Daudé wrote: > clock_get() returns the clock period. With an unconnected clock > we get 0. This is not what we want here. Use the API properly > by using the clock_has_source() function instead. > > Fixes: a0713e85bfa ("target/mips/cpu: Allow the CPU to use dynamic frequencies") > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~