From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ruehl Subject: Re: [Regression] net/phy/micrel.c v4.9.94 Date: Thu, 19 Apr 2018 10:34:43 +0800 Message-ID: <2b270eb0-3193-943f-300c-8959fad7802b@gtsys.com.hk> References: <3bd29bdd-b5ab-03d5-ea53-292f9150ee4c@gtsys.com.hk> <20180418125601.GF31643@lunn.ch> <20180418130203.GG31643@lunn.ch> <28e69b2b-e948-ab0e-d0c4-5f78994cfd98@gtsys.com.hk> <24c8e4cd-f2c1-6d50-9557-28a9958e74a5@gtsys.com.hk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: f.fainelli@gmail.com, netdev@vger.kernel.org To: Andrew Lunn Return-path: Received: from sh1.xit.com.hk ([111.91.236.50]:53150 "EHLO sh1.xit.com.hk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbeDSCev (ORCPT ); Wed, 18 Apr 2018 22:34:51 -0400 In-Reply-To: <24c8e4cd-f2c1-6d50-9557-28a9958e74a5@gtsys.com.hk> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On Thursday, April 19, 2018 09:34 AM, Chris Ruehl wrote: > > > On Thursday, April 19, 2018 09:21 AM, Chris Ruehl wrote: >> On Wednesday, April 18, 2018 09:02 PM, Andrew Lunn wrote: >>> On Wed, Apr 18, 2018 at 02:56:01PM +0200, Andrew Lunn wrote: >>>> On Wed, Apr 18, 2018 at 09:34:16AM +0800, Chris Ruehl wrote: >>>>> Hello, >>>>> >>>>> I like to get your heads up at a regression introduced in 4.9.94 >>>>> commitment lead to a kernel ops and make the network unusable on my MX6DL >>>>> customized board. >>>>> >>>>> Race condition resume is called on startup and the phy not yet initialized. >>>> >>>> Hi Chris >>>> >>>> Please could you try >>>> >>>> bfe72442578b ("net: phy: micrel: fix crash when statistic requested for >>>> KSZ9031 phy") >>> >>> I don't think it is a complete fix. I suspect "Micrel KSZ8795", >>> "Micrel KSZ886X Switch", "Micrel KSZ8061", and "Micrel KS8737" will >>> still have problems. >>> >>> Those four probably need a: >>> >>>          .probe          = kszphy_probe, >>> >>>     Andrew >>> >> >> Indeed I have the >> [    7.385851] Micrel KSZ9031 Gigabit PHY 2188000.ethernet-1:05: attached PHY >> driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=2188000.ethernet-1:05, >> irq=-1) >> >> first I rollback to a non crashing stable kernel. >> >> As "bfe72442578b" gonna fix it I check with the next update and verify its >> works for me. >> >> Thanks >> Chris > > Andrew, > > Change my mind. Find the patch you mentioned and will apply and test. > > Chris Andrew, make a micro patch only and can confirm to add the .probe fix the ops. But the imx serial is broken :-( ! have to have a look into it. --- linux-4.9/drivers/net/phy/micrel.c.orig 2018-04-19 09:37:45.648000000 +0800 +++ linux-4.9/drivers/net/phy/micrel.c 2018-04-19 09:44:54.356000000 +0800 @@ -974,6 +974,7 @@ .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause), .flags = PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT, .driver_data = &ksz9021_type, + .probe = kszphy_probe, .config_init = ksz9021_config_init, .config_aneg = genphy_config_aneg, .read_status = genphy_read_status, @@ -993,6 +994,7 @@ .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause), .flags = PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT, .driver_data = &ksz9021_type, + .probe = kszphy_probe, .config_init = ksz9031_config_init, .config_aneg = genphy_config_aneg, .read_status = ksz9031_read_status, [ 7.219735] Micrel KSZ9031 Gigabit PHY 2188000.ethernet-1:04: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=2188000.ethernet-1:04, irq=-1) Regards Chris -- GTSYS Limited RFID Technology 9/F, Unit E, R07, Kwai Shing Industrial Building Phase 2, 42-46 Tai Lin Pai Road, Kwai Chung, N.T., Hong Kong Tel (852) 9079 9521 Disclaimer: https://www.gtsys.com.hk/email/classified.html