From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=S1r7=RL=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A05F0C43381
	for <netdev@archiver.kernel.org>; Fri,  8 Mar 2019 13:20:41 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 761142133F
	for <netdev@archiver.kernel.org>; Fri,  8 Mar 2019 13:20:41 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726444AbfCHNUk (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 8 Mar 2019 08:20:40 -0500
Received: from www62.your-server.de ([213.133.104.62]:55516 "EHLO
        www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726287AbfCHNUk (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 8 Mar 2019 08:20:40 -0500
Received: from [88.198.220.130] (helo=sslproxy01.your-server.de)
        by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256)
        (Exim 4.89_1)
        (envelope-from <daniel@iogearbox.net>)
        id 1h2FQR-0002Pi-AJ; Fri, 08 Mar 2019 14:20:35 +0100
Received: from [2a02:120b:c3fc:feb0:dda7:bd28:a848:50e2] (helo=linux.home)
        by sslproxy01.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
        (Exim 4.89)
        (envelope-from <daniel@iogearbox.net>)
        id 1h2FQQ-0002yn-TM; Fri, 08 Mar 2019 14:20:35 +0100
Subject: Re: [PATCH v3 bpf]: libbpf: fixing leak when kernel does not support
 btf
To:     "Nikita V. Shirokov" <tehnerd@tehnerd.com>,
        Alexei Starovoitov <ast@kernel.org>, Yonghong Song <yhs@fb.com>
Cc:     netdev@vger.kernel.org
References: <20190308051814.19218-1-tehnerd@tehnerd.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <2b2c4b18-097c-e02d-c492-dfed7c4e0135@iogearbox.net>
Date:   Fri, 8 Mar 2019 14:20:33 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20190308051814.19218-1-tehnerd@tehnerd.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Authenticated-Sender: daniel@iogearbox.net
X-Virus-Scanned: Clear (ClamAV 0.100.2/25382/Fri Mar  8 09:55:42 2019)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On 03/08/2019 06:18 AM, Nikita V. Shirokov wrote:
> we could end up in situation when we have object file w/ all btf
> info but kernel does not support btf yet. in this situation currently
> libbpf just set obj->btf to NULL w/o freeing it first.
> this patch if fixing it by making sure to run btf__free first
> 
> v2->v3:
>  - adding "Fixes" tag
> 
> v1->v2:
>  - adding netdev to cc
> 
> Fixes: 8a138aed4a80 ("bpf: btf: Add BTF support to libbpf")
> Signed-off-by: Nikita V. Shirokov <tehnerd@tehnerd.com>

Applied, thanks!