From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED022C433EF for ; Wed, 11 May 2022 23:39:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349409AbiEKXjP (ORCPT ); Wed, 11 May 2022 19:39:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349382AbiEKXjO (ORCPT ); Wed, 11 May 2022 19:39:14 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AB6B6D951; Wed, 11 May 2022 16:39:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652312353; x=1683848353; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=DHCdBsPB20Xiig5HcLQMEK/s5Y3wvRIIRVn7Np5YH4g=; b=LVakchHQihewWbJ97HCfwY3jW40qfEQTBq7CYLBoAyalYixV9KRHf34F T8hKQIW0vSu6Ctdf6A1LlNcvE7th0U3JW+KfH7NI5/drVd3Ok00VNRikk DJj22NcFxdVDw2xH+73jDWxuueEkheue8C8XEC9JExHwYF+T/KiWu+pso PIPwA3umZpN/9/Axk5T2Kha6FOzXTEVePMCdOkcawEUL3vKla4gJ86R7h cYr+29mZKIMw+N0hdhgz485NDZbo8XP02hOoT/gBOVJ71xbLBuCnJ84wA 2jbwNqoQ4hhbPKgs+gwIZuyOnySdF5ma6GcJiMIbFWySy12dQkafkjSEn A==; X-IronPort-AV: E=McAfee;i="6400,9594,10344"; a="269778528" X-IronPort-AV: E=Sophos;i="5.91,218,1647327600"; d="scan'208";a="269778528" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 16:39:12 -0700 X-IronPort-AV: E=Sophos;i="5.91,218,1647327600"; d="scan'208";a="572290902" Received: from wancheny-mobl.amr.corp.intel.com (HELO [10.209.114.21]) ([10.209.114.21]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 16:39:11 -0700 Message-ID: <2b3ab214-0bcd-070a-f80a-5e0cf10cb339@linux.intel.com> Date: Wed, 11 May 2022 16:39:10 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.7.0 Subject: Re: [PATCH v3] PCI/AER: Handle Multi UnCorrectable/Correctable errors properly Content-Language: en-US To: Bjorn Helgaas Cc: Bjorn Helgaas , Russell Currey , Oliver OHalloran , linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20220511232757.GA829078@bhelgaas> From: Sathyanarayanan Kuppuswamy In-Reply-To: <20220511232757.GA829078@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/11/22 4:27 PM, Bjorn Helgaas wrote: >> [Eric: proposed reproducing steps] >> Fixes: 4696b828ca37 ("PCI/AER: Hoist aerdrv.c, aer_inject.c up to drivers/pci/pcie/") > 4696b828ca37 only*moves* drivers/pci/pcie/aer/aerdrv.c to > drivers/pci/pcie/aer.c, so I don't think it's related. > > I think the actual change of interest is e167bfcaa4cd ("PCI: aerdrv: > remove magical ROOT_ERR_STATUS_MASKS") [1]. It looks like we did > exactly what you propose before that commit. > > I can update this unless you disagree. > > [1]https://git.kernel.org/linus/e167bfcaa4cd > Agree. Please update it. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 484CDC433F5 for ; Wed, 11 May 2022 23:41:00 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KzBHZ3Wj6z3brl for ; Thu, 12 May 2022 09:40:58 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=jczvS/Um; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=sathyanarayanan.kuppuswamy@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=jczvS/Um; dkim-atps=neutral Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KzBGs08Wtz3bZt for ; Thu, 12 May 2022 09:40:19 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652312421; x=1683848421; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=DHCdBsPB20Xiig5HcLQMEK/s5Y3wvRIIRVn7Np5YH4g=; b=jczvS/UmAEd8OYD/M0CU7qRBQN9KZMn61P0481HKORmS9Kt5aGPmERlL rDTJHpdzLgoVuv/jXaMCSreCX1FGtWX9OpD5wkEc0IFw/xYURffQiNtNs fdruEHvPSKMP/U5tc/I0xOJ8MRixaKK2gAthBfItjBj3ebp+dZf3/2/XC uiZVGtEpoGhuAoehkHrViIJKrsJfwqIZqROSBNui2ix1QbsuCLgARi7mU JndD2HAmN0d/xXgrH3H5W6KQcgXDiho4dlGrR/uSGiKZy/mD6P8SzxvAC SleKiZNRj7zxl9Emo03R1tO8X1FCh396dl3CgkhZdtetUl3Cz6s0eYtUP g==; X-IronPort-AV: E=McAfee;i="6400,9594,10344"; a="332878751" X-IronPort-AV: E=Sophos;i="5.91,218,1647327600"; d="scan'208";a="332878751" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 16:39:12 -0700 X-IronPort-AV: E=Sophos;i="5.91,218,1647327600"; d="scan'208";a="572290902" Received: from wancheny-mobl.amr.corp.intel.com (HELO [10.209.114.21]) ([10.209.114.21]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 16:39:11 -0700 Message-ID: <2b3ab214-0bcd-070a-f80a-5e0cf10cb339@linux.intel.com> Date: Wed, 11 May 2022 16:39:10 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.7.0 Subject: Re: [PATCH v3] PCI/AER: Handle Multi UnCorrectable/Correctable errors properly Content-Language: en-US To: Bjorn Helgaas References: <20220511232757.GA829078@bhelgaas> From: Sathyanarayanan Kuppuswamy In-Reply-To: <20220511232757.GA829078@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver OHalloran , Bjorn Helgaas , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 5/11/22 4:27 PM, Bjorn Helgaas wrote: >> [Eric: proposed reproducing steps] >> Fixes: 4696b828ca37 ("PCI/AER: Hoist aerdrv.c, aer_inject.c up to drivers/pci/pcie/") > 4696b828ca37 only*moves* drivers/pci/pcie/aer/aerdrv.c to > drivers/pci/pcie/aer.c, so I don't think it's related. > > I think the actual change of interest is e167bfcaa4cd ("PCI: aerdrv: > remove magical ROOT_ERR_STATUS_MASKS") [1]. It looks like we did > exactly what you propose before that commit. > > I can update this unless you disagree. > > [1]https://git.kernel.org/linus/e167bfcaa4cd > Agree. Please update it. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer