From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F0232577D for ; Wed, 27 Mar 2024 08:09:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711526990; cv=none; b=IzkUocKnEkvP+FGAMkB5yflppdKrG0vZ8UY9uvUkWj6A4hhVtA7/HolHtH5Xr7Pomrqj+qa/PEyOkro4qtZI/PJRqpeO7ISgAPRtMjRhvMmz5OI5UpuScvlqZIIZ+VnogO7TV5UTJCc1qFdG0I3Pk9UZZCoWbCkr/UZ1IVeidq4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711526990; c=relaxed/simple; bh=GPu0olZFo/3Df8UKJk+W9AS/4Etn7baYS1zdkvAVtIc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KwOrjG5p03692AhO2+rOcu+1DqWska/ossVukrAnEEEOq8Jpqm3zP265mgq/eI0Y8MdIk4PlVuvREXLPuBBRmUIqdJMpaerUabxfhAmpusulsSUEvh+vcCaIl316Ac5qLBNo6xWcdgPXLDjnLRr7KaCPC0TwISm3VqcB3Bxi2DQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Q3Pv/gQs; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q3Pv/gQs" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-41494aaa1c5so2050085e9.2 for ; Wed, 27 Mar 2024 01:09:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711526987; x=1712131787; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=laN7yfiUrlW9A39+FpFCocbYRuO1xnHUno2fLpcSh5I=; b=Q3Pv/gQsam2BY1ZZCrfrZ6Hlc9c1ZugUlFx8C2V5B26fyhQxDdIn48rWTzIhBsxkn/ 6dlUizWBny8f/AE7DfduNSyquz8n2WUH2y59u9ULjekIZqux4+J1/ilV27JsjyxUyPQN K8aEdiEciNBSFe88a5gE+bpwnwp2ev8d4bYtUPvEStwXedCBt8DqHFGdY/l96kWcc/4r 8iydzL9PQX+wqmvwr+E6d8ty2GoMUCYzenYzCIfONLBga7QlZvl5BWvyzDK70QR/4Zx8 4R4B2t6fJMDASk5Qk3QUFWOZY1ycksmlwfD2HSfVJ0IGoLiMDUMts7cw42+7M6xIBSJ7 uyfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711526987; x=1712131787; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=laN7yfiUrlW9A39+FpFCocbYRuO1xnHUno2fLpcSh5I=; b=lnwOH05lLhtHDwuKdD+zKGcWpnN7JmsCoOlx03xMUGcUvDEzx/YCOuvxpggZTBWRbI zFb/vDD83oIUxQQFyAuJRa2ndQKQW6y1bMMYdRhNCXJJgHAkRX8X4c2QeCZlapdINjmh o9wMpY07sRiQqgjPOmjaVr+Au7eH+vxWZiePHC9UZQsWVxYn6sPNhB2MBGNA0YS+Sz9M 4RO3HW2PfBVtEsLgH3eYUR3gpI7y5hHJlVT8ICddOtea0qbl2YiSu1uJVh7InCk4FJ1/ wsZsL6mZr25LA2lskZi8SzWDIRhD6GRzSCGsvyYcGNdOIvKZqLhlo0ZqLVdlCjZlXs6j Ediw== X-Forwarded-Encrypted: i=1; AJvYcCWeQUTRyonUaIDJtgruPGex89i0Cx7jsOkO3NSiE8q22H4ZNgMhenKUCw/XhS5gkpvV93dqXrgVRuUk28lUuaFg5466ywXD/T4R9ROV X-Gm-Message-State: AOJu0YzXwPMwbb44ZxE3aRFC6XTG2cMODYbiGpBkpmTqtRpYFpuoSP3R L9FJqI5MGQV/4Z1s5ZXFbjJQ6L2sHYRoKeeyzfq3gHSQ09QF8jz6oZ+wUuMe/Vc= X-Google-Smtp-Source: AGHT+IGEz+1d1jkgyoddachI7gTTbD9dQEkwNHSRq3xwokZx4P8MvimuzJLiHrnBk29XtEAHxjXt3Q== X-Received: by 2002:a05:600c:1c15:b0:414:21e:86e8 with SMTP id j21-20020a05600c1c1500b00414021e86e8mr410489wms.27.1711526986918; Wed, 27 Mar 2024 01:09:46 -0700 (PDT) Received: from [192.168.2.107] ([79.115.63.252]) by smtp.gmail.com with ESMTPSA id q18-20020a05600c46d200b0041409db0349sm1334313wmo.48.2024.03.27.01.09.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 01:09:46 -0700 (PDT) Message-ID: <2b441832-9b3b-452f-8c63-444f29cbdd12@linaro.org> Date: Wed, 27 Mar 2024 08:09:44 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] clk: samsung: introduce nMUX for MUX clks that can reparented Content-Language: en-US To: =?UTF-8?Q?Andr=C3=A9_Draszik?= , peter.griffin@linaro.org, krzysztof.kozlowski@linaro.org Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com, s.nawrocki@samsung.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, semen.protsenko@linaro.org, linux-clk@vger.kernel.org, jaewon02.kim@samsung.com References: <20240326172813.801470-1-tudor.ambarus@linaro.org> <20240326172813.801470-2-tudor.ambarus@linaro.org> From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/26/24 17:43, André Draszik wrote: > Hi Tudor, > Hi, Andre'! > On Tue, 2024-03-26 at 17:28 +0000, Tudor Ambarus wrote: >> All samsung MUX clocks that are defined with MUX() set the >> CLK_SET_RATE_NO_REPARENT flag in __MUX(), which prevents MUXes to be >> reparented during clk_set_rate(). >> >> Introduce nMUX() for MUX clocks that can be reparented. > > What does n in nMUX stand for? I thought about using the common terminology, "n-to-1 multiplexer", where n is the number of select lines. I'm open to other suggestions if there are any. I should have specified the naming scheme in the commit message, will do in the next version. > >> [...] >>   >> +/* Used by MUX clocks where reparenting is allowed. */ >> +#define __nMUX(_id, cname, pnames, o, s, w, f, mf) \ >> + { \ >> + .id = _id, \ >> + .name = cname, \ >> + .parent_names = pnames, \ >> + .num_parents = ARRAY_SIZE(pnames), \ >> + .flags = f, \ >> + .offset = o, \ >> + .shift = s, \ >> + .width = w, \ >> + .mux_flags = mf, \ >> + } > > You've duplicated __MUX() and removed the CLK_SET_RATE_NO_REPARENT > from flags - I think it would make sense to instead drop the flag > from the existing __MUX(), and adjust the only two existing users > of the macro, i.e. to add it in MUX() and MUX_F(). > Yes, I find the suggestion good. Will do in v3. Thanks, ta From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4755C54E67 for ; Wed, 27 Mar 2024 08:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0tFx+zW7CkJMU1Dg6g3cZovM0cNF8okaFzQy50mJmC0=; b=DDlN5os1X8geV7 nVlgCPMA4NqUCbOGtEh96CdDo/12Le4xvgnm50ttekFwlTRkBppwsbfzQ38ylPnp00E8bVPaiPJbn okSjZaVGALJqj0jSprykv2Pclne404W5RU/BaKu5n+ep9JT86kkXtZCnKuNJWzb+4Dl6XekuqqWDp ATMQXohGdfmj3xr3D9//PpTqVb8r4A6LK4luvs7lOjAr0uoijGdod7DgeUcsN8eqVyWHLydYuC4IY yg922qCfC6JZpeuiQBF+MwntsSvmlJhB7u4nsPfpt1jlvQ3q4F0O7Fgoue4ved2eWt99DBDMqBp0D cguXowjg3BYinFaPl67w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpOM4-00000007ySZ-2qFo; Wed, 27 Mar 2024 08:09:52 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpOM1-00000007yQP-3LGg for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2024 08:09:51 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-41493e21931so2793795e9.3 for ; Wed, 27 Mar 2024 01:09:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711526987; x=1712131787; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=laN7yfiUrlW9A39+FpFCocbYRuO1xnHUno2fLpcSh5I=; b=pt318wFfZzUXMMMAyHetbMCgO5CONU3zYH4MD1AcfOUeXO8trRROBm8utn8Em4SOa0 a01MDaBmzKOT+cbKLrecZSX6kv6a5gu7nFbf7fzSipAPoYe0rAwhVT2CWIdsNFDvH7ez 9HoyMFqgRK0OTVM/cGB48eB+HIofCx3oOAJeYnp9qUI9D+TLmQn3GesyF282UBP4UXnH Ae2vu7LfeJr6sPPhxkqq0vOuYxyr2AizQHpN3uIHLfR7LImAkG5GSfR56A8MqC251Lq6 4j3FAFHFJta1EW+cDeWIRHBaeO3kYRYRliGlzWysWXU0w/oNxIe8pSJkPo3pvg6L6wwa 1/oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711526987; x=1712131787; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=laN7yfiUrlW9A39+FpFCocbYRuO1xnHUno2fLpcSh5I=; b=M/CsTK6cBUZe8HyHBVH/jO8G67QaQDPzHIJa8ac6xLzkUUyYCGpcSxlAH39LFxnlKA MBwwxsdLyKZJqCZGnl4p3qY1TJdx/1ihyUknMDP+bGXpr0F1aytWuTguutm+qQZtCIUc l6/fcf5VieKwdjvvzT0GmDeENqY5FV1rIEFhr747lfryCc/kVQJNltx30xC5axLvhyHr VV23vZfrW//g/MZbNNy3JG6MASOyBm6rfsT2+I1APaJ9HLbFivIAYnmHlz/sIHL8dMJV UYdIf6QNuZLESam6jKbshsc8CAiY9LAwuwE48Ymi5QinQqGsWmjfLYCklhF6K0U31oxL +n6A== X-Forwarded-Encrypted: i=1; AJvYcCXkMR7FWmpEh5l63n5Ox41TVXYxnq3ZhbBHACcSzWfrIXw4Mbln7esQ6FGoaSAi1n32dFUyxmis6vYVmL01gMiANfSvlxlg2gU7dN/fVARMzKas1pc= X-Gm-Message-State: AOJu0YyPzs+kC7oSIB/g3+VvUN1HwoLbz+MsU/s8gysQefgr+qEhMtQy UdeHxrwJ+joJpkVDJ+w7JG6qmSpnpfAOER6DTLl6u5YGuRe1Fz/kFfLlcZmivT8= X-Google-Smtp-Source: AGHT+IGEz+1d1jkgyoddachI7gTTbD9dQEkwNHSRq3xwokZx4P8MvimuzJLiHrnBk29XtEAHxjXt3Q== X-Received: by 2002:a05:600c:1c15:b0:414:21e:86e8 with SMTP id j21-20020a05600c1c1500b00414021e86e8mr410489wms.27.1711526986918; Wed, 27 Mar 2024 01:09:46 -0700 (PDT) Received: from [192.168.2.107] ([79.115.63.252]) by smtp.gmail.com with ESMTPSA id q18-20020a05600c46d200b0041409db0349sm1334313wmo.48.2024.03.27.01.09.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 01:09:46 -0700 (PDT) Message-ID: <2b441832-9b3b-452f-8c63-444f29cbdd12@linaro.org> Date: Wed, 27 Mar 2024 08:09:44 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] clk: samsung: introduce nMUX for MUX clks that can reparented Content-Language: en-US To: =?UTF-8?Q?Andr=C3=A9_Draszik?= , peter.griffin@linaro.org, krzysztof.kozlowski@linaro.org Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com, s.nawrocki@samsung.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, semen.protsenko@linaro.org, linux-clk@vger.kernel.org, jaewon02.kim@samsung.com References: <20240326172813.801470-1-tudor.ambarus@linaro.org> <20240326172813.801470-2-tudor.ambarus@linaro.org> From: Tudor Ambarus In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_010949_984353_2A7F54B7 X-CRM114-Status: GOOD ( 17.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAzLzI2LzI0IDE3OjQzLCBBbmRyw6kgRHJhc3ppayB3cm90ZToKPiBIaSBUdWRvciwKPiAK CkhpLCBBbmRyZSchCgo+IE9uIFR1ZSwgMjAyNC0wMy0yNiBhdCAxNzoyOCArMDAwMCwgVHVkb3Ig QW1iYXJ1cyB3cm90ZToKPj4gQWxsIHNhbXN1bmcgTVVYIGNsb2NrcyB0aGF0IGFyZSBkZWZpbmVk IHdpdGggTVVYKCkgc2V0IHRoZQo+PiBDTEtfU0VUX1JBVEVfTk9fUkVQQVJFTlQgZmxhZyBpbiBf X01VWCgpLCB3aGljaCBwcmV2ZW50cyBNVVhlcyB0byBiZQo+PiByZXBhcmVudGVkIGR1cmluZyBj bGtfc2V0X3JhdGUoKS4KPj4KPj4gSW50cm9kdWNlIG5NVVgoKSBmb3IgTVVYIGNsb2NrcyB0aGF0 IGNhbiBiZSByZXBhcmVudGVkLgo+IAo+IFdoYXQgZG9lcyBuIGluIG5NVVggc3RhbmQgZm9yPwoK SSB0aG91Z2h0IGFib3V0IHVzaW5nIHRoZSBjb21tb24gdGVybWlub2xvZ3ksICJuLXRvLTEgbXVs dGlwbGV4ZXIiLAp3aGVyZSBuIGlzIHRoZSBudW1iZXIgb2Ygc2VsZWN0IGxpbmVzLiBJJ20gb3Bl biB0byBvdGhlciBzdWdnZXN0aW9ucyBpZgp0aGVyZSBhcmUgYW55LiBJIHNob3VsZCBoYXZlIHNw ZWNpZmllZCB0aGUgbmFtaW5nIHNjaGVtZSBpbiB0aGUgY29tbWl0Cm1lc3NhZ2UsIHdpbGwgZG8g aW4gdGhlIG5leHQgdmVyc2lvbi4KPiAKPj4gWy4uLl0KPj4gwqAKPj4gKy8qIFVzZWQgYnkgTVVY IGNsb2NrcyB3aGVyZSByZXBhcmVudGluZyBpcyBhbGxvd2VkLiAqLwo+PiArI2RlZmluZSBfX25N VVgoX2lkLCBjbmFtZSwgcG5hbWVzLCBvLCBzLCB3LCBmLCBtZikJCVwKPj4gKwl7CQkJCQkJCVwK Pj4gKwkJLmlkCQk9IF9pZCwJCQkJXAo+PiArCQkubmFtZQkJPSBjbmFtZSwJCQlcCj4+ICsJCS5w YXJlbnRfbmFtZXMJPSBwbmFtZXMsCQkJXAo+PiArCQkubnVtX3BhcmVudHMJPSBBUlJBWV9TSVpF KHBuYW1lcyksCQlcCj4+ICsJCS5mbGFncwkJPSBmLAkJCQlcCj4+ICsJCS5vZmZzZXQJCT0gbywJ CQkJXAo+PiArCQkuc2hpZnQJCT0gcywJCQkJXAo+PiArCQkud2lkdGgJCT0gdywJCQkJXAo+PiAr CQkubXV4X2ZsYWdzCT0gbWYsCQkJCVwKPj4gKwl9Cj4gCj4gWW91J3ZlIGR1cGxpY2F0ZWQgX19N VVgoKSBhbmQgcmVtb3ZlZCB0aGUgQ0xLX1NFVF9SQVRFX05PX1JFUEFSRU5UCj4gZnJvbSBmbGFn cyAtIEkgdGhpbmsgaXQgd291bGQgbWFrZSBzZW5zZSB0byBpbnN0ZWFkIGRyb3AgdGhlIGZsYWcK PiBmcm9tIHRoZSBleGlzdGluZyBfX01VWCgpLCBhbmQgYWRqdXN0IHRoZSBvbmx5IHR3byBleGlz dGluZyB1c2Vycwo+IG9mIHRoZSBtYWNybywgaS5lLiB0byBhZGQgaXQgaW4gTVVYKCkgYW5kIE1V WF9GKCkuCj4gCgpZZXMsIEkgZmluZCB0aGUgc3VnZ2VzdGlvbiBnb29kLiBXaWxsIGRvIGluIHYz LgoKVGhhbmtzLAp0YQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=