All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liu Shixin <liushixin2@huawei.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Seth Jennings <sjenning@redhat.com>,
	Dan Streetman <ddstreet@ieee.org>,
	Vitaly Wool <vitaly.wool@konsulko.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nathan Chancellor <nathan@kernel.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>,
	Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH v5 2/5] Revert "frontswap: simplify frontswap_register_ops"
Date: Wed, 21 Sep 2022 09:42:41 +0800	[thread overview]
Message-ID: <2b469a5c-7960-ca6a-9360-c7d3aa26e8ae@huawei.com> (raw)
In-Reply-To: <20220920121305.GA4237@lst.de>

On 2022/9/20 20:13, Christoph Hellwig wrote:

> On Thu, Sep 15, 2022 at 11:50:00AM +0800, Liu Shixin wrote:
>> This reverts commit f328c1d16e4c764992895ac9c9425cea861b2ca0.
>>
>> Since we are supported to delay zswap initializaton, we need to invoke
>> ops->init for the swap device which is already online when register
>> backend.
> Why do we "have" to do it.  Retroactively supporting functionality on
> previously enabled swap devices seems rather odd, and the amount of
> cruft added for it here absolutely does not seem to be worth it.
Hi Christoph,

This revert makes code complicated, but I think it's necessary. When enable zswap,
I expect it to work for all swap devices as much as possible. In this way, user can enable
zswap and swap device in any order. Since we can enable zswap on previously swap
devices, why not support it to get such benifit?

Thanks,
> .
>


  reply	other threads:[~2022-09-21  1:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15  3:49 [PATCH v5 0/5] Delay the initializaton of zswap Liu Shixin
2022-09-15  3:49 ` [PATCH v5 1/5] Revert "mm: mark swap_lock and swap_active_head static" Liu Shixin
2022-09-15  3:50 ` [PATCH v5 2/5] Revert "frontswap: simplify frontswap_register_ops" Liu Shixin
2022-09-20 12:13   ` Christoph Hellwig
2022-09-21  1:42     ` Liu Shixin [this message]
2022-09-27  7:27       ` Christoph Hellwig
2022-09-27 11:12         ` Liu Shixin
2022-09-27 12:31           ` Christoph Hellwig
2022-09-15  3:50 ` [PATCH v5 3/5] mm/zswap: replace zswap_init_{started/failed} with zswap_init_state Liu Shixin
2022-09-15  3:50 ` [PATCH v5 4/5] mm/zswap: delay the initializaton of zswap until the first enablement Liu Shixin
2022-09-15  3:50 ` [PATCH v5 5/5] mm/zswap: skip confusing print info Liu Shixin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b469a5c-7960-ca6a-9360-c7d3aa26e8ae@huawei.com \
    --to=liushixin2@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=ddstreet@ieee.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nathan@kernel.org \
    --cc=sjenning@redhat.com \
    --cc=vitaly.wool@konsulko.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.