From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAC3EC433EF for ; Tue, 21 Sep 2021 07:24:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D29061100 for ; Tue, 21 Sep 2021 07:24:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230227AbhIUHZ3 (ORCPT ); Tue, 21 Sep 2021 03:25:29 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:36912 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230136AbhIUHZZ (ORCPT ); Tue, 21 Sep 2021 03:25:25 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 165CA3F32A for ; Tue, 21 Sep 2021 07:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632209037; bh=FaHcDpk+u1VpWt5lbH8rjwnBsNSsw93jdeErzZSXmg0=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=BZl8mZnyi5Yq4N8T7f43iRmSjP3STi84eNkGzG7qsmYItgCP18CQLa5jBH4TOEIkJ m+eqOWBq3/SXJN7yvPQoEVbzjB3mHahlGtm7JOOBinCGbkx1/PdeL28ndiZiSoNt5Q 6L9pa2LED8FpIiYQNgwZgd8K0ojyZ5NG4zeB6XUcZSa0oeLIumyi03Rc5AiJ1rVF/X mp3U9q25yU1GWDU3bCqejh06Cse8mx+vpff9pe5Ap6f8uLZI22NHTZFkWj+Ru8isBQ cO+++DBUKeKJva7gLa2+Pv4iqPhAQgCp9y8OZRVmSLaBJYnQnyNt/cJCgm1Ego+ahn xxnAlY6gowtVw== Received: by mail-wr1-f69.google.com with SMTP id f7-20020a5d50c7000000b0015e288741a4so8051023wrt.9 for ; Tue, 21 Sep 2021 00:23:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FaHcDpk+u1VpWt5lbH8rjwnBsNSsw93jdeErzZSXmg0=; b=B55MzYiZ+vmArmjJlyGePXIlduS604jt4bjG9BNlQclJ+3FcSPrDJqS14eOTkKCEHR U30RLSwRqf/9TecLWtLfhobQPODZiDfH1qIOH0ghr8NEFtbNHQ2RiTn+cW93J47wdbM5 LTGbZSQmenSDnkqsb6ugzqo1TwW4JNTzoPwjjTP138NWRtcbB8kREvrtvpYsBJd5pN21 4T8aMO/qVRRMl/KaOPBitXsInMC1Dbcl7g93Yl78uKPcBkDmHfDmviGkuksToCRPWypN qhtRTvNhm1CNDOvZCLnza5zwHiFW/UlIeNMM1CJ3tIfcOEvwhEt+sp3kPt7rLsZoehd6 BOrA== X-Gm-Message-State: AOAM532KidneYL925HL0w60QwyrcrwBB71Y2ETA2aSFe3IB4loMUxh+m dIWWbQG/ngd7wiJ8vpdMJpSBc1cdoe7WdfPJF5yF/BRErebj5d6ol19q1a7wxVhDoQXz5feIClv 6cmBtOzYsJ5USelq+kURGDT77eXZ6vMTAP/iWqzVgyA== X-Received: by 2002:a5d:6503:: with SMTP id x3mr33696774wru.76.1632209036701; Tue, 21 Sep 2021 00:23:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIt6Xvm6FM45NoflFQPUnxuEX7g4Z3WCiYjoS2cooa5lMLDgpEqp+kpteu59gYfReRS0VpXQ== X-Received: by 2002:a5d:6503:: with SMTP id x3mr33696759wru.76.1632209036525; Tue, 21 Sep 2021 00:23:56 -0700 (PDT) Received: from [192.168.0.134] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id x5sm2367351wmk.32.2021.09.21.00.23.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 00:23:56 -0700 (PDT) Subject: Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic To: Will McVicker , Catalin Marinas , Will Deacon Cc: Lee Jones , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-3-willmcvicker@google.com> From: Krzysztof Kozlowski Message-ID: <2b48a41a-9130-b4cc-40d3-0bc7930ac76a@canonical.com> Date: Tue, 21 Sep 2021 09:23:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210920190350.3860821-3-willmcvicker@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/09/2021 21:03, Will McVicker wrote: > Switch the default logic to enable SOC_SAMSUNG and it's sub-configs to > be enabled by default via "default y if ARCH_EXYNOS" versus being > selected by the ARCH_EXYNOS config directly. This allows vendors to > disable these configs if they wish and provides additional flexibility > to modularize them in the presence of a generic kernel. This is not true. Vendors cannot disable these options as they are not visible. Although I understand that Arnd prefers this way and I do not object it, but your explanation is incorrect. > > There are no .config differences with this change. The configs > SOC_SAMSUNG, EXYNOS_CHIPID, EXYNOS_PM_DOMAINS, and EXYNOS_PMU still > remain enabled by default. > > Signed-off-by: Will McVicker > --- > arch/arm64/Kconfig.platforms | 4 ---- > drivers/soc/samsung/Kconfig | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 3a66ed43088d..6a006490c9b9 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -91,14 +91,10 @@ config ARCH_BRCMSTB > > config ARCH_EXYNOS > bool "ARMv8 based Samsung Exynos SoC family" > - select EXYNOS_CHIPID This will conflict with: https://lore.kernel.org/linux-samsung-soc/CAGOxZ50i6URzUQ7o7V4m7MR=2TqSeD6qx5fQaQDs+5nEq4fa2A@mail.gmail.com/T/#t Build on top of it, please. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B03E1C433F5 for ; Tue, 21 Sep 2021 07:25:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 752C8611BD for ; Tue, 21 Sep 2021 07:25:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 752C8611BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=tYft1ygMtvlMzvC29FzNHFc+K2tBQx05QJZD7bkmhiM=; b=nw/SMd+u3gcHu+j7dSuM1HqM/4 W9kj5GvZlBj3U3Ig9z0UVRsrGXqUdbiRQV0FZvp9DNrOS36ns/wQjRqqmlMbM1qg0smPPs3LbGGU5 2W2T9MMogakaCPcdXgf9+KtaOttUCaLRTpMuwYFchxASNDe6T0WCOGXS4hwGQMNir8rd/d+w62OLm XWxTGOoZL4U5J6lBy680HWmvqLBISDAWqaIl3H92C0mKJv9Y5yJol/6zEJ3T3weoFTAOfzY/2zNHo jWPiCEDFGOQPw7pFCTPGyqxgXypAG1bttU5IfQc68AwqW0BdaBuKocVcc70V8g2eoIPjhPcLejNix pwzCPGyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSa8I-003n4x-Pw; Tue, 21 Sep 2021 07:24:03 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSa8E-003n3J-AY for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 07:23:59 +0000 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 185EA3F048 for ; Tue, 21 Sep 2021 07:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632209037; bh=FaHcDpk+u1VpWt5lbH8rjwnBsNSsw93jdeErzZSXmg0=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=BZl8mZnyi5Yq4N8T7f43iRmSjP3STi84eNkGzG7qsmYItgCP18CQLa5jBH4TOEIkJ m+eqOWBq3/SXJN7yvPQoEVbzjB3mHahlGtm7JOOBinCGbkx1/PdeL28ndiZiSoNt5Q 6L9pa2LED8FpIiYQNgwZgd8K0ojyZ5NG4zeB6XUcZSa0oeLIumyi03Rc5AiJ1rVF/X mp3U9q25yU1GWDU3bCqejh06Cse8mx+vpff9pe5Ap6f8uLZI22NHTZFkWj+Ru8isBQ cO+++DBUKeKJva7gLa2+Pv4iqPhAQgCp9y8OZRVmSLaBJYnQnyNt/cJCgm1Ego+ahn xxnAlY6gowtVw== Received: by mail-wr1-f72.google.com with SMTP id r5-20020adfb1c5000000b0015cddb7216fso8054691wra.3 for ; Tue, 21 Sep 2021 00:23:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FaHcDpk+u1VpWt5lbH8rjwnBsNSsw93jdeErzZSXmg0=; b=BL7hNSDMwVQ3zC3Vw5RECS03QW+9V6HLF+ZlBvTwHa7XdtgoVpvz0lQVuIQy6zrE0a OKL+IFCdnAI1k9Fu9CMTKuj4hUZDPN/8dV77rvdbs06wNSOCYEuYpWoNX5sVfY7RRg8E +xCKrcXZZOEcjMg24AVMzsO6lNP23NKLa8VW4E8nsZGbmiGXtw7FRdiPTQLsnIz6MmhF hWYXphU1wA1BXxcWZGGBbnkKKZCKX/vg9sIK7qTyLVW915eJap5Sz5qF8Ehm70SaFZMo wQya7HvhJrR4X4YBRsC4ZakxRvHgq3cYp0ZVjCWoOhuKOH41eAc+HXP4bXwJ/s1tDGRY x3uQ== X-Gm-Message-State: AOAM530oE6dS7myuTmgclzgtLYQqpG10JwNLmwavvCFWy17YcMILWMay 5DQAT4N8LXKTin3eDkeLTAS1d07RRpqfBAQYcENV6G4HuGEQ1FI/G0aMqrwAGhKtaAV8CkIl5Fx Qas1QcgnzoRdZYX5cZlqkQF099samIRAD/ATBlslKy4Hw0jrO2et/ X-Received: by 2002:a5d:6503:: with SMTP id x3mr33696769wru.76.1632209036701; Tue, 21 Sep 2021 00:23:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIt6Xvm6FM45NoflFQPUnxuEX7g4Z3WCiYjoS2cooa5lMLDgpEqp+kpteu59gYfReRS0VpXQ== X-Received: by 2002:a5d:6503:: with SMTP id x3mr33696759wru.76.1632209036525; Tue, 21 Sep 2021 00:23:56 -0700 (PDT) Received: from [192.168.0.134] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id x5sm2367351wmk.32.2021.09.21.00.23.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 00:23:56 -0700 (PDT) Subject: Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic To: Will McVicker , Catalin Marinas , Will Deacon Cc: Lee Jones , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-3-willmcvicker@google.com> From: Krzysztof Kozlowski Message-ID: <2b48a41a-9130-b4cc-40d3-0bc7930ac76a@canonical.com> Date: Tue, 21 Sep 2021 09:23:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210920190350.3860821-3-willmcvicker@google.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_002358_579749_88A69D6F X-CRM114-Status: GOOD ( 19.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/09/2021 21:03, Will McVicker wrote: > Switch the default logic to enable SOC_SAMSUNG and it's sub-configs to > be enabled by default via "default y if ARCH_EXYNOS" versus being > selected by the ARCH_EXYNOS config directly. This allows vendors to > disable these configs if they wish and provides additional flexibility > to modularize them in the presence of a generic kernel. This is not true. Vendors cannot disable these options as they are not visible. Although I understand that Arnd prefers this way and I do not object it, but your explanation is incorrect. > > There are no .config differences with this change. The configs > SOC_SAMSUNG, EXYNOS_CHIPID, EXYNOS_PM_DOMAINS, and EXYNOS_PMU still > remain enabled by default. > > Signed-off-by: Will McVicker > --- > arch/arm64/Kconfig.platforms | 4 ---- > drivers/soc/samsung/Kconfig | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 3a66ed43088d..6a006490c9b9 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -91,14 +91,10 @@ config ARCH_BRCMSTB > > config ARCH_EXYNOS > bool "ARMv8 based Samsung Exynos SoC family" > - select EXYNOS_CHIPID This will conflict with: https://lore.kernel.org/linux-samsung-soc/CAGOxZ50i6URzUQ7o7V4m7MR=2TqSeD6qx5fQaQDs+5nEq4fa2A@mail.gmail.com/T/#t Build on top of it, please. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel