All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Cédric Le Goater" <clg@kaod.org>, openbmc@lists.ozlabs.org
Subject: Re: [PATCH linux dev-5.3 12/13] mtd: spi-nor: aspeed: check upper freq limit when doing training
Date: Thu, 26 Sep 2019 11:42:17 +0930	[thread overview]
Message-ID: <2b4f6932-084b-4279-8631-f03af054496a@www.fastmail.com> (raw)
In-Reply-To: <20190925124239.27897-13-clg@kaod.org>



On Wed, 25 Sep 2019, at 22:12, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>  drivers/mtd/spi-nor/aspeed-smc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c 
> b/drivers/mtd/spi-nor/aspeed-smc.c
> index c6a80fdf51ef..48164d819a37 100644
> --- a/drivers/mtd/spi-nor/aspeed-smc.c
> +++ b/drivers/mtd/spi-nor/aspeed-smc.c
> @@ -1075,7 +1075,7 @@ static int aspeed_smc_optimize_read(struct 
> aspeed_smc_chip *chip,
>  
>  		/* Compare timing to max */
>  		freq = ahb_freq / i;
> -		if (freq >= max_freq)
> +		if (freq > max_freq)
>  			continue;

Heh.

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>

>  
>  		/* Set the timing */
> -- 
> 2.21.0
> 
>

  reply	other threads:[~2019-09-26  2:11 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 12:42 [PATCH linux dev-5.3 00/13] mtd: spi-nor: aspeed: add support for ast2600 Cédric Le Goater
2019-09-25 12:42 ` [PATCH linux dev-5.3 01/13] ARM: dts: aspeed-g6: Add FMC and SPI devices Cédric Le Goater
2019-09-26  1:27   ` Andrew Jeffery
2019-09-25 12:42 ` [PATCH linux dev-5.3 02/13] ARM: dts: aspeed: rainier: Enable " Cédric Le Goater
2019-09-26  1:34   ` Andrew Jeffery
2019-09-25 12:42 ` [PATCH linux dev-5.3 03/13] ARM: dts: aspeed: rainier: Enable MAC0 Cédric Le Goater
2019-09-26  1:19   ` Andrew Jeffery
2019-09-26  5:55     ` Cédric Le Goater
2019-09-25 12:42 ` [PATCH linux dev-5.3 04/13] ARM: dts: ast2600-evb: Enable FMC and SPI devices Cédric Le Goater
2019-09-26  1:38   ` Andrew Jeffery
2019-09-25 12:42 ` [PATCH linux dev-5.3 05/13] mtd: spi-nor: Add support for w25q512jv Cédric Le Goater
2019-09-26  1:42   ` Andrew Jeffery
2019-09-26  3:53     ` Joel Stanley
2019-09-25 12:42 ` [PATCH linux dev-5.3 06/13] mtd: spi-nor: aspeed: Introduce a field for the AHB physical address Cédric Le Goater
2019-09-26  1:59   ` Andrew Jeffery
2019-09-25 12:42 ` [PATCH linux dev-5.3 07/13] mtd: spi-nor: aspeed: Introduce segment operations Cédric Le Goater
2019-09-26  2:00   ` Andrew Jeffery
2019-09-25 12:42 ` [PATCH linux dev-5.3 08/13] mtd: spi-nor: aspeed: add initial support for ast2600 Cédric Le Goater
2019-09-26  2:00   ` Andrew Jeffery
2019-09-25 12:42 ` [PATCH linux dev-5.3 09/13] mtd: spi-nor: aspeed: Check for disabled segments on the AST2600 Cédric Le Goater
2019-09-26  2:01   ` Andrew Jeffery
2019-09-25 12:42 ` [PATCH linux dev-5.3 10/13] mtd: spi-nor: aspeed: Introduce training operations per platform Cédric Le Goater
2019-09-26  2:03   ` Andrew Jeffery
2019-09-25 12:42 ` [PATCH linux dev-5.3 11/13] mtd: spi-nor: aspeed: Introduce a HCLK mask for training Cédric Le Goater
2019-09-26  2:10   ` Andrew Jeffery
2019-09-25 12:42 ` [PATCH linux dev-5.3 12/13] mtd: spi-nor: aspeed: check upper freq limit when doing training Cédric Le Goater
2019-09-26  2:12   ` Andrew Jeffery [this message]
2019-09-25 12:42 ` [PATCH linux dev-5.3 13/13] mtd: spi-nor: aspeed: add support for AST2600 training Cédric Le Goater
2019-09-26  2:14   ` Andrew Jeffery
2019-09-26  6:59     ` Cédric Le Goater
2019-09-26  7:04       ` Joel Stanley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b4f6932-084b-4279-8631-f03af054496a@www.fastmail.com \
    --to=andrew@aj.id.au \
    --cc=clg@kaod.org \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.