All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: [PATCH 10/14] dm-mpath: Change return type of pg_init_all_paths() from int into void
Date: Fri, 18 Nov 2016 14:29:06 -0800	[thread overview]
Message-ID: <2b52336a-b711-df4b-8cf6-d919ac16d59c@sandisk.com> (raw)
In-Reply-To: <32edbd52-5b1a-b093-0195-2ec6fa73cd6f@sandisk.com>

None of the callers of pg_init_all_paths() check its return value.
Hence change the return type of pg_init_all_paths() from int into
void.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
---
 drivers/md/dm-mpath.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index f1e226d..1c97f0e 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -374,16 +374,13 @@ static int __pg_init_all_paths(struct multipath *m)
 	return atomic_read(&m->pg_init_in_progress);
 }
 
-static int pg_init_all_paths(struct multipath *m)
+static void pg_init_all_paths(struct multipath *m)
 {
-	int r;
 	unsigned long flags;
 
 	spin_lock_irqsave(&m->lock, flags);
-	r = __pg_init_all_paths(m);
+	__pg_init_all_paths(m);
 	spin_unlock_irqrestore(&m->lock, flags);
-
-	return r;
 }
 
 static void __switch_pg(struct multipath *m, struct priority_group *pg)
-- 
2.10.1

  parent reply	other threads:[~2016-11-18 22:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18 22:26 [PATCH v2 0/14] Device mapper patches for Linux kernel v4.10 Bart Van Assche
2016-11-18 22:26 ` [PATCH 01/14] dm: Verify suspend_locking assumptions at runtime Bart Van Assche
2016-11-18 22:26 ` [PATCH 02/14] dm: Use blk_set_queue_dying() in __dm_destroy() Bart Van Assche
2016-11-18 22:27 ` [PATCH 03/14] dm: Fix a race condition in rq_completed() Bart Van Assche
2016-11-18 22:27 ` [PATCH 04/14] dm: Simplify dm_table_determine_type() Bart Van Assche
2016-11-18 22:27 ` [PATCH 05/14] dm: Simplify use_blk_mq initialization Bart Van Assche
2016-11-18 22:28 ` [PATCH 06/14] dm-ioctl: Use offsetof() instead of open-coding it Bart Van Assche
2016-11-18 22:28 ` [PATCH 07/14] dm, persistence: Remove an unused argument from dm_block_manager_create() Bart Van Assche
2016-11-18 22:28 ` [PATCH 08/14] dm, persistence: Remove a dead assignment Bart Van Assche
2016-11-18 22:28 ` [PATCH 09/14] dm-mpath: Verify 'm->lock' locking assumptions at runtime Bart Van Assche
2016-11-18 22:29 ` Bart Van Assche [this message]
2016-11-18 22:29 ` [PATCH 11/14] dm-mpath: Do not touch *__clone if request allocation fails Bart Van Assche
2016-11-18 22:29 ` [PATCH 12/14] dm-mpath: Micro-optimize the hot path Bart Van Assche
2016-11-18 22:29 ` [PATCH 13/14] dm-mpath: Introduce assign_bit() Bart Van Assche
2016-11-18 22:30 ` [PATCH 14/14] dm, dm-mpath: Make it easier to detect unintended I/O request flushes Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b52336a-b711-df4b-8cf6-d919ac16d59c@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=dm-devel@redhat.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.