From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30350C433EF for ; Tue, 26 Oct 2021 14:41:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7D3F60E8F for ; Tue, 26 Oct 2021 14:41:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B7D3F60E8F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=eldorado.org.br Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:51276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfNdS-0008Nf-Ln for qemu-devel@archiver.kernel.org; Tue, 26 Oct 2021 10:41:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfNWy-0000je-5X; Tue, 26 Oct 2021 10:34:25 -0400 Received: from [201.28.113.2] (port=6421 helo=outlook.eldorado.org.br) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfNWw-00038m-A9; Tue, 26 Oct 2021 10:34:23 -0400 Received: from power9a ([10.10.71.235]) by outlook.eldorado.org.br with Microsoft SMTPSVC(8.5.9600.16384); Tue, 26 Oct 2021 11:33:12 -0300 Received: from [127.0.0.1] (unknown [10.10.70.45]) by power9a (Postfix) with ESMTP id BC4DE80012A; Tue, 26 Oct 2021 11:33:11 -0300 (-03) Subject: Re: [PATCH 15/33] target/ppc: Implement Vector Insert from GPR using GPR index insns To: Richard Henderson , qemu-devel@nongnu.org, qemu-ppc@nongnu.org References: <20211021194547.672988-1-matheus.ferst@eldorado.org.br> <20211021194547.672988-16-matheus.ferst@eldorado.org.br> <0581a10f-1411-a174-5869-4fe0999132f3@linaro.org> From: "Matheus K. Ferst" Message-ID: <2b55eed2-a5a4-232d-1a51-4d25d7c3a6c7@eldorado.org.br> Date: Tue, 26 Oct 2021 11:33:11 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <0581a10f-1411-a174-5869-4fe0999132f3@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-OriginalArrivalTime: 26 Oct 2021 14:33:12.0201 (UTC) FILETIME=[677E6F90:01D7CA76] X-Host-Lookup-Failed: Reverse DNS lookup failed for 201.28.113.2 (failed) Received-SPF: pass client-ip=201.28.113.2; envelope-from=matheus.ferst@eldorado.org.br; helo=outlook.eldorado.org.br X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) BAYES_40=-0.001, NICE_REPLY_A=-0.215, PDS_HP_HELO_NORDNS=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lucas.castro@eldorado.org.br, luis.pires@eldorado.org.br, groug@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 23/10/2021 01:40, Richard Henderson wrote: > [E-MAIL EXTERNO] Não clique em links ou abra anexos, a menos que você > possa confirmar o remetente e saber que o conteúdo é seguro. Em caso de > e-mail suspeito entre imediatamente em contato com o DTI. > > On 10/21/21 12:45 PM, matheus.ferst@eldorado.org.br wrote: >> +#if defined(TARGET_PPC64) >> +    return do_vinsx(ctx, a->vrt, size, right, cpu_gpr[a->vra], >> cpu_gpr[a->vrb], >> +                    gen_helper); >> +#else >> +    bool ok; >> +    TCGv_i64 val; >> + >> +    val = tcg_temp_new_i64(); >> +    tcg_gen_extu_tl_i64(val, cpu_gpr[a->vrb]); >> + >> +    ok = do_vinsx(ctx, a->vrt, size, right, cpu_gpr[a->vra], val, >> gen_helper); >> + >> +    tcg_temp_free_i64(val); >> +    return ok; >> +#endif > > Oh, and what's all this? > > Either this isn't defined for !PPC64 at all, or you should just use > target_ulong and not > do any ifdeffing at all. > > r~ The helper receives i64 because it's also used by Vector Insert From VSR in patch 17. We can drop the ifdef and always tcg_gen_extu_tl_i64 though. -- Matheus K. Ferst Instituto de Pesquisas ELDORADO Analista de Software Aviso Legal - Disclaimer