From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>, netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next] net: dsa: sja1105: don't keep a persistent reference to the reset GPIO
Date: Wed, 22 Sep 2021 09:09:34 -0700 [thread overview]
Message-ID: <2b6795ec-fb42-9dba-4e3e-7b140341aa95@gmail.com> (raw)
In-Reply-To: <20210922151029.2457157-1-vladimir.oltean@nxp.com>
On 9/22/21 8:10 AM, Vladimir Oltean wrote:
> The driver only needs the reset GPIO for a very brief period, so instead
> of using devres and keeping the descriptor pointer inside priv, just use
> that descriptor inside the sja1105_hw_reset function and then let go of
> it.
>
> Also use gpiod_get_optional while at it, and error out on real errors
> (bad flags etc).
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2021-09-22 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 15:10 [PATCH net-next] net: dsa: sja1105: don't keep a persistent reference to the reset GPIO Vladimir Oltean
2021-09-22 16:09 ` Florian Fainelli [this message]
2021-09-23 11:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b6795ec-fb42-9dba-4e3e-7b140341aa95@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.