All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrej Shadura <andrew.shadura@collabora.co.uk>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org
Cc: Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH] hwrng: u2fzero - account for high quality RNG
Date: Tue, 22 Nov 2022 11:55:47 +0100	[thread overview]
Message-ID: <2b70efb3-08ef-8de0-d222-4bc29288dde8@collabora.co.uk> (raw)
In-Reply-To: <20221119134259.2969204-1-Jason@zx2c4.com>

On 19/11/2022 14:42, Jason A. Donenfeld wrote:
> The U2F zero apparently has a real TRNG in it with maximum quality, not
> one with quality of "1", which was likely a misinterpretation of the
> field as a boolean. So remove the assignment entirely, so that we get
> the default quality setting.
> 
> In the u2f-zero firmware, the 0x21 RNG command used by this driver is
> handled as such [1]:

> So it seems rather plain that the ATECC RNG is considered to provide
> good random numbers.

Thanks — at the time when it was written, there was a general concern 
about whether we should trust the hardware RNG of this device or not, so 
the safer option was not to :)

> Cc: Andrej Shadura <andrew.shadura@collabora.co.uk>
> Cc: Jiri Kosina <jkosina@suse.cz>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Probably too late, but still:

Acked-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

-- 
Cheers,
   Andrej


  parent reply	other threads:[~2022-11-22 10:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19 13:42 [PATCH] hwrng: u2fzero - account for high quality RNG Jason A. Donenfeld
2022-11-22 10:22 ` Jiri Kosina
2022-11-22 10:58   ` Jason A. Donenfeld
2022-11-22 10:59     ` Jiri Kosina
2022-11-22 10:55 ` Andrej Shadura [this message]
2022-11-25  9:46 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b70efb3-08ef-8de0-d222-4bc29288dde8@collabora.co.uk \
    --to=andrew.shadura@collabora.co.uk \
    --cc=Jason@zx2c4.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jkosina@suse.cz \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.