From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julian Exner Subject: Re: Input: mouse: Trackpoint middle button not recognized on Thinkpad E470 Date: Tue, 6 Jun 2017 20:09:50 +0200 Message-ID: <2b78eeba-3f8b-3caf-ee76-cf32147b026e@techfak.uni-bielefeld.de> References: <13710506-2225-9f81-40e3-7463ac829860@techfak.uni-bielefeld.de> <20170425211633.bl72ajw5duwdpq4j@beacon.debie> <20170425221014.GD30843@dtor-ws> <20170428210531.3mfkua2lxj36yx2p@beacon.debie> <20170531191305.u4hkksajll4q7o5l@beacon.debie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smarthost.TechFak.Uni-Bielefeld.DE ([129.70.137.17]:36316 "EHLO smarthost.TechFak.Uni-Bielefeld.DE" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751440AbdFFSUm (ORCPT ); Tue, 6 Jun 2017 14:20:42 -0400 In-Reply-To: <20170531191305.u4hkksajll4q7o5l@beacon.debie> Content-Language: en-US Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: ulrik.debie-os@e2big.org, Oscar Campos Cc: Dmitry Torokhov , "linux-input@vger.kernel.org" , aduggan@synaptics.com, Peter Hutterer Hi all, sorry for neglecting this thread for so long. And thanks Ulrik for pointing me to the formalities. > I was kind of surprised at first that the value was 0x33 instead of 0x3 > until I read the documentation pointers Julian provided. It seems like some kind of softswitch or masking for the individual buttons. One of the 4-bit nibbles indicates the number of available buttons in hardware, the other one the number of activated buttons. > I really would like this patch to become part of the linux kernel and > I hope that Julian will go through the formalities for patch submission. I'm willing to do so, but I'm very short on time currently. Additionally, I checked on a Thinkpad forum and was told that there are Thinkpads from the 90s with two buttons (e.g. ThinkPad 760 and those before ThinkPad 390/600/770). So I'm a bit afraid that simply setting the default to three buttons may break something for these models and a more elaborate patch may be necessary. Kind regards, Julian