From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Stefan Weil" <sw@weilnetz.de>, "Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter
Date: Mon, 25 Jan 2021 17:36:42 +0100 [thread overview]
Message-ID: <2b8b6291-b54c-b285-ae38-21f067a8497d@redhat.com> (raw)
In-Reply-To: <20210125144530.2837481-2-philmd@redhat.com>
On 25/01/21 15:45, Philippe Mathieu-Daudé wrote:
> From: Richard Henderson <richard.henderson@linaro.org>
>
> The configure option was backward, and we failed to
> pass the value on to meson.
>
> Fixes: 23a77b2d18b ("build-system: clean up TCG/TCI configury")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Message-Id: <20210124211119.35563-1-richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> configure | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index dcc5ea7d630..526c4cc1306 100755
> --- a/configure
> +++ b/configure
> @@ -1119,9 +1119,9 @@ for opt do
> ;;
> --enable-whpx) whpx="enabled"
> ;;
> - --disable-tcg-interpreter) tcg_interpreter="true"
> + --disable-tcg-interpreter) tcg_interpreter="false"
> ;;
> - --enable-tcg-interpreter) tcg_interpreter="false"
> + --enable-tcg-interpreter) tcg_interpreter="true"
> ;;
> --disable-cap-ng) cap_ng="disabled"
> ;;
> @@ -6361,6 +6361,7 @@ NINJA=$ninja $meson setup \
> -Dmalloc=$malloc -Dmalloc_trim=$malloc_trim -Dsparse=$sparse \
> -Dkvm=$kvm -Dhax=$hax -Dwhpx=$whpx -Dhvf=$hvf \
> -Dxen=$xen -Dxen_pci_passthrough=$xen_pci_passthrough -Dtcg=$tcg \
> + -Dtcg_interpreter=$tcg_interpreter \
> -Dcocoa=$cocoa -Dgtk=$gtk -Dmpath=$mpath -Dsdl=$sdl -Dsdl_image=$sdl_image \
> -Dvnc=$vnc -Dvnc_sasl=$vnc_sasl -Dvnc_jpeg=$vnc_jpeg -Dvnc_png=$vnc_png \
> -Dgettext=$gettext -Dxkbcommon=$xkbcommon -Du2f=$u2f -Dvirtiofsd=$virtiofsd \
>
Too bad, sorry.
There were two things to do when rebasing before the "automatic command
line parsing" patch, and I messed up both of them.
Paolo
next prev parent reply other threads:[~2021-01-25 16:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 14:45 [PATCH v4 0/4] meson: Try to clarify TCG / TCI options for new users Philippe Mathieu-Daudé
2021-01-25 14:45 ` [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter Philippe Mathieu-Daudé
2021-01-25 16:36 ` Paolo Bonzini [this message]
2021-01-25 17:10 ` Daniel P. Berrangé
2021-01-26 19:46 ` Stefan Weil
2021-01-25 14:45 ` [PATCH v4 2/4] configure: Improve TCI feature description Philippe Mathieu-Daudé
2021-01-25 16:44 ` Daniel P. Berrangé
2021-01-25 14:45 ` [PATCH v4 3/4] meson: Explicit TCG backend used Philippe Mathieu-Daudé
2021-01-25 16:45 ` Daniel P. Berrangé
2021-01-25 14:45 ` [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available Philippe Mathieu-Daudé
2021-01-25 16:46 ` Daniel P. Berrangé
2021-01-25 16:47 ` Daniel P. Berrangé
2021-01-25 17:05 ` Philippe Mathieu-Daudé
2021-01-25 18:58 ` Stefan Weil
2021-01-25 19:02 ` Richard Henderson
2021-01-25 21:02 ` Stefan Weil
2021-01-25 22:35 ` Richard Henderson
2021-01-26 11:40 ` Stefan Weil
2021-01-26 17:24 ` Alex Bennée
2021-01-26 19:44 ` Stefan Weil
2021-01-26 20:07 ` Paolo Bonzini
2021-01-26 20:10 ` Stefan Weil
2021-01-26 22:39 ` Richard Henderson
2021-01-27 6:53 ` Stefan Weil
2021-01-27 17:19 ` Richard Henderson
2021-01-27 19:52 ` Alex Bennée
2021-01-27 20:49 ` Stefan Weil
2021-01-27 21:47 ` Alex Bennée
2021-01-28 2:49 ` Stefan Weil
2021-01-28 6:51 ` qemu user mode fails to run programs with large VM / built with address sanitizer (was: Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available) Stefan Weil
2021-01-28 8:29 ` Richard Henderson
2021-01-27 10:02 ` [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available Daniel P. Berrangé
2021-01-27 12:34 ` Alex Bennée
2021-01-26 10:34 ` Daniel P. Berrangé
2021-01-29 8:06 ` [PATCH v4 0/4] meson: Try to clarify TCG / TCI options for new users Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b8b6291-b54c-b285-ae38-21f067a8497d@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.