All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Huacai Chen <chenhc@lemote.com>,
	Bjorn Helgaas <bhelgaas@google.com>, Jens Axboe <axboe@kernel.dk>,
	linux-mips <linux-mips@vger.kernel.org>,
	linux-pci <linux-pci@vger.kernel.org>,
	linux-ide <linux-ide@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: 回复:[PATCH 1/6] PCI: Add Loongson vendor ID and 7A1000 device IDs
Date: Tue, 10 Mar 2020 10:31:56 +0800	[thread overview]
Message-ID: <2ba6de2e-7880-d322-a0f6-5cea2647ea50@loongson.cn> (raw)
In-Reply-To: <170be7ca00e.133ea84fa2305.7803335422925759322@flygoat.com>

On 03/09/2020 04:50 PM, Jiaxun Yang wrote:
>   ---- 在 星期一, 2020-03-09 16:23:21 Tiezhu Yang <yangtiezhu@loongson.cn> 撰写 ----
>   > Add the Loongson vendor ID and 7A1000 device IDs to pci_ids.h
>   > to be used by the controller driver in the future.
>   >
>   > The Loongson IDs can be found at the following link:
>   > https://git.kernel.org/pub/scm/utils/pciutils/pciutils.git/tree/pci.ids
>   >
>   > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>   > ---
>   >  include/linux/pci_ids.h | 18 ++++++++++++++++++
>   >  1 file changed, 18 insertions(+)
>   >
>   > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>   > index 352c0d7..0125ab4 100644
>   > --- a/include/linux/pci_ids.h
>   > +++ b/include/linux/pci_ids.h
>   > @@ -3113,4 +3113,22 @@
>   >
>   >  #define PCI_VENDOR_ID_NCUBE        0x10ff
>   >
>   > +#define PCI_VENDOR_ID_LOONGSON            0x0014
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_HT    0x7a00
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_APB    0x7a02
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_GMAC    0x7a03
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_OTG    0x7a04
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_DC    0x7a06
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_HDA    0x7a07
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_SATA    0x7a08
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_PCIE_X1    0x7a09
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_SPI    0x7a0b
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_LPC    0x7a0c
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_DMA    0x7a0f
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_EHCI    0x7a14
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_GPU    0x7a15
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_PCIE_X4    0x7a19
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_OHCI    0x7a24
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_PCIE_X8    0x7a29
>
> Devices IDs are unlikely to be reused by mutiple subsystems, so probably we don't need
> to add them here?

Hi Jiaxun,

I think it is better to define the device IDs in pci_ids.h,
otherwise it seems a little disorganized.

Thanks,

Tiezhu Yang

>   
>> +
>   >  #endif /* _LINUX_PCI_IDS_H */
>   > --
>   > 2.1.0
>   >
>   >


  reply	other threads:[~2020-03-10  2:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09  8:23 [PATCH 0/6] Add basic support for Loongson 7A1000 bridge chip Tiezhu Yang
2020-03-09  8:23 ` [PATCH 1/6] PCI: Add Loongson vendor ID and 7A1000 device IDs Tiezhu Yang
2020-03-09  8:50   ` 回复:[PATCH " Jiaxun Yang
2020-03-10  2:31     ` Tiezhu Yang [this message]
2020-03-10  2:37       ` Jiaxun Yang
2020-03-10  9:28         ` Tiezhu Yang
2020-03-09  8:23 ` [PATCH 2/6] AHCI: Add support for Loongson 7A1000 SATA controller Tiezhu Yang
2020-03-09  8:23 ` [PATCH 3/6] MIPS: Loongson: Use firmware arguments to get board name Tiezhu Yang
2020-03-09  8:36   ` 回复:[PATCH " Jiaxun Yang
2020-03-10  2:38     ` Tiezhu Yang
2020-03-09  8:23 ` [PATCH 4/6] MIPS: Loongson: Add DMA support for 7A1000 Tiezhu Yang
2020-03-09  8:44   ` 回复:[PATCH " Jiaxun Yang
2020-03-10  2:40     ` Tiezhu Yang
2020-03-13  8:24   ` [PATCH " Christoph Hellwig
2020-03-13  9:03     ` Tiezhu Yang
2020-03-09  8:23 ` [PATCH 5/6] MIPS: Loongson: Add PCI " Tiezhu Yang
2020-03-09  8:47   ` 回复:[PATCH " Jiaxun Yang
2020-03-10  3:03     ` Tiezhu Yang
2020-03-09  8:23 ` [PATCH 6/6] MIPS: Loongson: Add support for 7A1000 interrupt controller Tiezhu Yang
2020-03-09  9:07   ` 回复:[PATCH " Jiaxun Yang
2020-03-10  4:28     ` Tiezhu Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ba6de2e-7880-d322-a0f6-5cea2647ea50@loongson.cn \
    --to=yangtiezhu@loongson.cn \
    --cc=axboe@kernel.dk \
    --cc=bhelgaas@google.com \
    --cc=chenhc@lemote.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lixuefeng@loongson.cn \
    --cc=tsbogend@alpha.franken.de \
    --subject='Re: 回复:[PATCH 1/6] PCI: Add Loongson vendor ID and 7A1000 device IDs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.