From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7536AC433FE for ; Thu, 17 Nov 2022 14:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q/JmIS4uH5/Y++AtguQlJ3xY5MAoD88tSSKu7Xv/E+A=; b=SXa4iIboQmJdLK yRq4bAeKpaMoToNHktKpbMBGYJZRu/ZafDIGCtr/AH4phbggn/AKg6ypt2SU5R4iq4G7lGU0ehBuc rqNw+QgpZ+VKQULpiLLBa9UuGT9Y21tsCt+ehLREWlwx3n95KthGtpUaGZ8eZ2q4WTnfFAM8X+cZv Wtxwb9fN35fVhX1UGozZDj/qNOxV//z3wTTZpwuVfFCEO301jMZq+jaeYRdUnlr1L+3IejVPpi6Wl ghT0Y2neL9vO+hDwbZ9i692qVCFKn59U1L7CMd5re1Gvlgy4f+tTpfpb/BhwXTi9YfiRJ3Y1Fa22g 1XXvDjauWSpc1vcP8NaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovg2M-00EtKG-6J; Thu, 17 Nov 2022 14:38:42 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovg2J-00EtIX-8m for linux-arm-kernel@lists.infradead.org; Thu, 17 Nov 2022 14:38:40 +0000 Received: by mail-lf1-x12c.google.com with SMTP id g12so3121556lfh.3 for ; Thu, 17 Nov 2022 06:38:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rPV44nh+46de5qjmklnTJqvI+EmgDgrM3eGckL4oXVU=; b=BtLli3cdca6cthH2E96q+YeyeSiE3oEPU/UIo9vemH2w8Dxw3jTdNnZ1LH3M+JMLyj conKEKeFBplvGpgfZFd9WA6pFTJd+6je4UOZOXSNtRHH7+i4W6SzErLsK2A4ZcF6eUej NES449c36GxQVANSAEW09xzcwtMZGxnCCjXfT7ZpQQDhorivmBPIEK+y86KuZXMtbioR uNVHRd5NXEA2HXn7ghXqYfYwFkf1kE2X/E+QTG72kAdzbxrOGscnoeEoGT3V2FYtB+EX n0hv6IurE2/YyrsY99U+ZfUuevF2QSOSb5huqcAWa2grobUtd9ENwrPcUTGw2mYkwTiF MSSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rPV44nh+46de5qjmklnTJqvI+EmgDgrM3eGckL4oXVU=; b=jlbRLL2gqMNlzkAk/q/zkFChQzMF8mKx/5J6HVhalU35Ep+61dZlYjeJxkdiRcY8O7 ywGl65CJEXjofMp7J0zOIGkFzvlg2Xe7Irl1+WRph/0PgcqqTicQNIpTYXcZRP315QjS zS9F4wD6JEzkap+Jmfcwzls/Cf29aTxiS77B2+cT30xN/Fc0wbLMtL+/ayoDivSeUqCs mfYqnFEZAg3Sk5dzLKRJXTaxjHNHomyYYhEjVsQz+lABMmLzh5grRMzBuFdxV7+TfwIR amg+yfMG+Pr3P0N+Pj5F0o5JtMHiGos+Vn4A/56Ke8ceMyy/m/V3USNC3vIfXH4Di+A6 PMaA== X-Gm-Message-State: ANoB5pmpPAzVsHl6LMm5p8DvUpqjHS7Ye2LitFfjs942H48/1B2kqyO0 DEI/SYu+adVwzvQyjXB9a8fEtA== X-Google-Smtp-Source: AA0mqf5of47onPVxf1U0StkSQtcKO7wq0myM0VLB0Sf6df3dYnecUyMAc3diaiLX0Tpfj97Mp/PfSg== X-Received: by 2002:a05:6512:25a0:b0:4a2:bbdc:1430 with SMTP id bf32-20020a05651225a000b004a2bbdc1430mr952848lfb.404.1668695913881; Thu, 17 Nov 2022 06:38:33 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id s22-20020a056512315600b00497a0ea92desm176055lfi.135.2022.11.17.06.38.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Nov 2022 06:38:33 -0800 (PST) Message-ID: <2bc5b167-a453-bbb4-9feb-c03913874740@linaro.org> Date: Thu, 17 Nov 2022 15:38:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/4] ARM: dts: imx6ull-dhcom: Add DH electronics DHCOM i.MX6ULL SoM and PDK2 board To: Christoph Niedermaier Cc: Rob Herring , Krzysztof Kozlowski , Peng Fan , Shawn Guo , Marek Vasut , Fabio Estevam , NXP Linux Team , kernel , "linux-arm-kernel@lists.infradead.org" References: <20221117103134.6452-1-cniedermaier@dh-electronics.com> <20221117103134.6452-3-cniedermaier@dh-electronics.com> <2333f957-5ff8-da99-7862-ba9eb794c20c@linaro.org> <31567c6722b34abba179f330cab004db@dh-electronics.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <31567c6722b34abba179f330cab004db@dh-electronics.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_063839_358613_D070348B X-CRM114-Status: GOOD ( 12.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/11/2022 15:11, Christoph Niedermaier wrote: >>> +&fec2 { /* DHCOM ETH2 */ >>> + phy-handle = <&mdio2_phy1>; >>> + phy-mode = "rmii"; >>> + pinctrl-0 = <&pinctrl_fec2>; >>> + pinctrl-names = "default"; >>> + status = "okay"; >>> + >>> + mdio { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + mdio2_phy0: ethernet-phy@0 { /* SMSC LAN8710Ai */ >>> + clock-names = "rmii-ref"; >>> + clocks = <&clks IMX6UL_CLK_ENET_REF>; >>> + compatible = "ethernet-phy-id0007.c0f0", >>> + "ethernet-phy-ieee802.3-c22"; >>> + interrupt-parent = <&gpio5>; >>> + interrupts = <5 IRQ_TYPE_LEVEL_LOW>; >>> + pinctrl-0 = <&pinctrl_fec1_phy &pinctrl_snvs_fec1_phy>; >>> + pinctrl-names = "default"; >>> + reg = <0>; >> >> compatible first, reg second, then the rest of properties. Same in other >> places. > > Sorry, I have sorted it alphabetically. > Should the status property be sorted at the end or also alphabetically? You do not have status here. For the cases where it is present, depends on the preferences of subarch maintainer. Usually it also goes to the end, but not always. > >>> + reset-assert-us = <500>; >>> + reset-deassert-us = <500>; >>> + reset-gpios = <&gpio3 23 GPIO_ACTIVE_LOW>; >>> + smsc,disable-energy-detect; /* Make plugin detection reliable */ >>> + }; >>> + Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel